Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Arnd Bergmann <arnd@kernel.org>, Rob Clark <robdclark@gmail.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Arnd Bergmann <arnd@arndb.de>,
        Randy Dunlap <rdunlap@infradead.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Alex Elder <elder@linaro.org>,
        Akhil P Oommen <akhilpo@codeaurora.org>,
        Rajeev Nandan <rajeevny@codeaurora.org>,
        Abhinav Kumar <abhinavk@codeaurora.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        freedreno@lists.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20211013144308.2248978-1-arnd@kernel.org>
 <25ccdc75-67da-a955-b8ef-641a2f007d13@amd.com>
 <CAMuHMdWKp-v=df0JA_tr-YgNnyfu7NS9dA3Zr+bqwZX9JuBAGQ@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <ad5d95ab-7cb5-aef7-9904-eda0befe8519@amd.com>
Date:   Mon, 18 Oct 2021 13:40:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CAMuHMdWKp-v=df0JA_tr-YgNnyfu7NS9dA3Zr+bqwZX9JuBAGQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTV3MzRMVlJXSjZDNW1LZHNpOGh4Mm5ra1M5Zlp6MWlpSFJLUUdCei9EQlZp?=
 =?utf-8?B?WEoxTlFMY041bWtPQ0pEN3VYRXpod3RXemUwVE8zWEZjdDR5ZmU3dzdocUIr?=
 =?utf-8?B?THBGS0ZGMTBZb2hTdHlOOHYySGo2T3ViTmJJMXpOLzRJQzc1RGZ2UnVORk1j?=
 =?utf-8?B?cStHbk5vUjBHMmFXMVAzWXlIeDcvUGRTUHFXaGs0cDdybXN4SGo4QnV3SWJM?=
 =?utf-8?B?WHRIYmxNNk9WSzlVSzlESDZySEw0SHZxZjN3bnRMSXg2WE9HMnNLWEJPN1lw?=
 =?utf-8?B?WnNtOVBsbzdUQnBTT0RLNTFsNG1FbTc3QjRIYTRmYU1NQkt1UTRSSExLSG0z?=
 =?utf-8?B?akZOQUlycDN0ZUtLK1NHU25jYXJmMmMrS1NoOHhXUTdvejhjcmdFNER0eWhP?=
 =?utf-8?B?RTNsN0w1STY0ZUxkNW1MbWtvM0hpNlNLUFp4MWRHWjVPSEtvekpjN1FsekJ1?=
 =?utf-8?B?NlpGREYrZmJibDJjVHlybVUwSDBidkE2Q2V0aUx5Wjlpd3Y2NFZ0OXJ6eDNG?=
 =?utf-8?B?OHA3S216YWVraEg2WXJnaVBkN1poODR6MmlvUWplV3JMU0VEVXA2M1g5VC8x?=
 =?utf-8?B?b3lXbDRUTFM1OGNvMmw1Q1FjbFdkd3JoaFpkZFJqL1I2eFpJWm1lTmVxYUs4?=
 =?utf-8?B?TnlUZVVGQ3o1S2t0ZG0vQUN5YUFmenBnc3BveXE3aHI1TDdwbjcwamkxVFll?=
 =?utf-8?B?WUdkdFViMjZGNTkvQjIzRk44ZXlTSHNYWUZwZDVWUHlSYUovKzdRYTNxQTJG?=
 =?utf-8?B?OFkzbTMxOVNHZEx3KzBUTDRPVXYxZzJaekh2V1hrc0prcEw4S1YvTURNdjVo?=
 =?utf-8?B?ZDI4dUdBRzFZSVBlU2NWWHJObnRSOEV6YjZmN0MzOFZpNnhYQVNlNUswRmgr?=
 =?utf-8?B?Y3dBRGtKS0VHSjJwSSswOXFibmZndHp6b2d2MjQxS0dOWW9RSUdQdVhtalIy?=
 =?utf-8?B?am9CQittMDdqV3JjUVhRbUQ3K0tqOFlXdGN0SlhwZ2tKeFFHdDRxYTZvZW5U?=
 =?utf-8?B?UkNCS09zaWFRSkVvb3B6dEtxN2kzUEdGN2xJbXZsT2xJWXVGTTg2Z0gzNTFp?=
 =?utf-8?B?KzQ3Sng0VUh3S0V2WnllQ0k2eFJKWUIwa0psMmJCMWF0RnpTYzlKekZnN0x0?=
 =?utf-8?B?ZzdCVnpKU3FyamwyTjRsVXp3dGxSS0pUUEtJUVo5M2hNajZOOGYxK0R2YXdi?=
 =?utf-8?B?ZForQVlUM3BJelptaG0vNHZoQ1krY0VUNWhtYm5XazNWSFI0Z01sbTdlQXh1?=
 =?utf-8?B?bHNBZTlOTGJ6cU5ORmsvZ2xtUXZrdUVSbHllaWNsWU5Rb3FUbzJkSU1OWG91?=
 =?utf-8?B?bmdTSEdhbFowOWlFejlYWDY3TzNBV0VwQ3FEeEtJOGROR24zbENnSkxlVEZZ?=
 =?utf-8?B?ME1DbnlUdExWdWp3WDYyeTJsbW9DUCtRZ0tJMnprTzRjVG5Bci9YV2NYTlpW?=
 =?utf-8?B?MnkvUU9wMGFWa2hhQU1TdXBZT3UzeVR3dEtLeENnWENlNkZleTc1Q1RDSVFR?=
 =?utf-8?B?YTk3SU45bjJ6Z3QzWFBjOEFhSHhKRWl5Q3NoOUZXMFo1UnVWYmlHWUJkVDJZ?=
 =?utf-8?B?WWx1MURWNGZtTWVSRUxjcXg5alVlb1p4QnR3K2hBUDV0ajhkQmdqZWlKcU54?=
 =?utf-8?B?ZCt2dWx4dmJBRFFzNUduU2tSTlE2T080ZTBWZnd1ZmtiQjBHLzVYeTdSNXdJ?=
 =?utf-8?B?SWtYTDBTWm1yeEswamd1bmwzTVJjMkhnUGJ2anowZjBtTXVtdHRGd1ZpVno0?=
 =?utf-8?B?MWpUcExCTSt3SCtNYkJoY2ZKUEoyYjhORzJXVUU5SkhuTXV0ZWZvRmt4clJ0?=
 =?utf-8?B?Q25tY0RFUzJMNTFpRFlDYkpUZTdmZ3ByQk5jb1h2cWpkdzRCbjFmQmVtYmpZ?=
 =?utf-8?Q?9X7NIe5ANUdLj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc525342-9577-4ec3-c3c7-08d9922c2b1f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:41:05.1873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ek6gLXCSst9w0XAlyqpri4cP2bpIDgwN++FSrmzJrdTqlSaGu3LVPnldATxtQ4y3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1149
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.10.21 um 13:38 schrieb Geert Uytterhoeven:
> Hi Christian,
>
> On Mon, Oct 18, 2021 at 1:37 PM Christian König
> <christian.koenig@amd.com> wrote:
>> Am 13.10.21 um 16:42 schrieb Arnd Bergmann:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> When CONFIG_COMMON_CLOCK is disabled, the 8996 specific
>>> phy code is left out, which results in a link failure:
>>>
>>> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
>>>
>>> This was only exposed after it became possible to build
>>> test the driver without the clock interfaces.
>>>
>>> Make COMMON_CLK a hard dependency for compile testing,
>>> and simplify it a little based on that.
>>>
>>> Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
>>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>>    drivers/gpu/drm/msm/Kconfig  | 2 +-
>>>    drivers/gpu/drm/msm/Makefile | 6 +++---
>>>    2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>>> index f5107b6ded7b..cb204912e0f4 100644
>>> --- a/drivers/gpu/drm/msm/Kconfig
>>> +++ b/drivers/gpu/drm/msm/Kconfig
>>> @@ -4,8 +4,8 @@ config DRM_MSM
>>>        tristate "MSM DRM"
>>>        depends on DRM
>>>        depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
>>> +     depends on COMMON_CLK
>>>        depends on IOMMU_SUPPORT
>> We also need a "depends on MMU" here because some automated test is now
>> trying to compile the driver on parisc as well.
>>
>> I have absolutely no idea how a platform can have IOMMU but no MMU
>> support but it indeed seems to be the case here.
> Huh?
>
> Parisc has config MMU def_bool y?

Then why vmap isn't available?

See the mail thread: [linux-next:master 3576/7806] 
drivers/gpu/drm/msm/msm_gem.c:624:20: error: implicit declaration of 
function 'vmap'

Thanks for taking a look into this,
Christian.

>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds