Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tGBXMkmoyYRHZlZESqgtnQ2Q74cKe722DeHSyLj3hmpwyM0y2lhimqy7Sut0XzCTtvckD6t1m+
 hPG8tQbsrsqNAfCLtr33EZG+StF/YBZmQE4jIu407z1rnZSI0njJAL4uAFCVR/xv7dqsd70xah
 tldc2xt2j1KQBFdL1l20zbVn5ecJdTBOrPueXOF6mxpTxKvNxizhIIULeTyXm/pNBad15hAj/M
 0+2Yrh73yPjKC1IJSM0dUti8I+HxaSKIf0KDQSuMG/cnRV1Z1D5LOzGiZW5teJ42ZxCy6q4uiR
 8KLmFRLKuTU+cwFJ9548HoCq
Subject: Re: [PATCH v8 2/3] dt-bindings: clock: lan966x: Add LAN966X Clock
 Controller
To:     Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
        <robh+dt@kernel.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
        <Eugen.Hristev@microchip.com>, <Manohar.Puri@microchip.com>
References: <20211008082635.31774-1-kavyasree.kotagiri@microchip.com>
 <20211008082635.31774-3-kavyasree.kotagiri@microchip.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <c17e542f-3216-b251-11e4-ade6cc02f055@microchip.com>
Date:   Mon, 18 Oct 2021 13:55:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20211008082635.31774-3-kavyasree.kotagiri@microchip.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/10/2021 at 10:26, Kavyasree Kotagiri wrote:
> This adds the DT bindings documentation for lan966x SoC
> generic clock controller.
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

If it can speed-up adoption:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
> v7 -> v8:
> - No changes.
> 
> v6 -> v7:
> - No changes.
> 
> v5 -> v6:
> - Removed "_clk" in clock-names.
> - Added Reviewed-by.
> 
> v4 -> v5:
> - In v4 dt-bindings, missed adding "clock-names" in required
>    properties and example. So, added them.
> 
> v3 -> v4:
> - Updated "clocks" description.
> - Added "clock-names".
> 
> v2 -> v3:
> - Fixed dt_binding_check errors.
> 
> v1 -> v2:
> - Updated example provided for clk controller DT node.
> 
>   .../bindings/clock/microchip,lan966x-gck.yaml | 57 +++++++++++++++++++
>   1 file changed, 57 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml b/Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
> new file mode 100644
> index 000000000000..fca83bd68e26
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/microchip,lan966x-gck.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN966X Generic Clock Controller
> +
> +maintainers:
> +  - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> +
> +description: |
> +  The LAN966X Generic clock controller contains 3 PLLs - cpu_clk,
> +  ddr_clk and sys_clk. This clock controller generates and supplies
> +  clock to various peripherals within the SoC.
> +
> +properties:
> +  compatible:
> +    const: microchip,lan966x-gck
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: CPU clock source
> +      - description: DDR clock source
> +      - description: System clock source
> +
> +  clock-names:
> +    items:
> +      - const: cpu
> +      - const: ddr
> +      - const: sys
> +
> +  '#clock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clks: clock-controller@e00c00a8 {
> +        compatible = "microchip,lan966x-gck";
> +        #clock-cells = <1>;
> +        clocks = <&cpu_clk>, <&ddr_clk>, <&sys_clk>;
> +        clock-names = "cpu", "ddr", "sys";
> +        reg = <0xe00c00a8 0x38>;
> +    };
> +...
> 


-- 
Nicolas Ferre