Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] hwmon: (tmp421) Add of_node_put() before return
Date:   Mon, 18 Oct 2021 08:15:37 -0400
Message-Id: <20211018121538.16482-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S2EdTVMfQpvtGWh20vwugMu8jzFwmTh0J35cFw/ZNuaXumEwvPvZgWCnP5Re?=
 =?us-ascii?Q?3A6mtPjpEokAUPfQfRc++K7ATzP/WvpxN9+80li3Zet+fN+hdsOyZn0u//fS?=
 =?us-ascii?Q?iMMLHe1gl1wk8JYUp+azuHd3KHQBICDLWkCGzp0Baia+ec8VLNg8NWTdXajl?=
 =?us-ascii?Q?sqyewLGJh4sU/pAmsj6InI7xkVdJaHSrZaX3lcdRuJ40yNNPvJ1PiXFrHt/F?=
 =?us-ascii?Q?JpL1aEyEM/ZeKB1IRYAkWVFv892pi7XUamXCwpXMhcf+Frqags/eLRYD594R?=
 =?us-ascii?Q?WaXceAWZv18wK6mGSbgi4XKjcxL1zuxT4RDXoLnEVuLumLyyIFgM3TUEQjFX?=
 =?us-ascii?Q?A7O4VbI1u/7b4gVglJesRN1JQo8VZghyCGiGABQEkbnvMFxIkF3V4IyG3BEq?=
 =?us-ascii?Q?LMS6cOh5ylIceU6qoTiyoGOYWP5lYMTLyYv38mxJ++f9OQXoM0hZBrDPnJyK?=
 =?us-ascii?Q?xLh2DPaLQMz2gscBUKZ97+nJ0nUqYl4K0KA9Bi6Fo8+X+vVdRT5jnAdEKBzt?=
 =?us-ascii?Q?6RwYQBuzaPFzthtlc6G3hOD9s7Yq1KE5KYV9czxYE8wAynL57WYEWW334loI?=
 =?us-ascii?Q?D6tcksA/J5uIGB8b2Lo1joDFFwCAvr95/Wml9bw+WZHYJ0d6RNd3S2rr716Y?=
 =?us-ascii?Q?mk1O908dkcLD/ebMceqEvwbPs5TyljSy3/6SclNBP5UW1XyepwA1rGUNUslW?=
 =?us-ascii?Q?rWpF1lczxv8NCLfZkdFSsNB0QxQ4KO1plFEAy6hTcYURjvTmNgsboULwFQzL?=
 =?us-ascii?Q?gNLuhCRD1GzixbWryZP8UXNFwO5S9TnT9nlE1G8FcpClCJWRBbZH9Z2w0djr?=
 =?us-ascii?Q?RXAm7V2KCMSTT/escp0Me/5lLmf+dFK8ryDBHAuAiQk/Icg94Sl6kIisfkBo?=
 =?us-ascii?Q?DYV2DcP/txquZTHMJkMWYXHBcUdlfy111dt6sJj44YPrU14RoM+cXhdX9GfR?=
 =?us-ascii?Q?8VIu/pmrGqovjZ1VVL4ckgY93X4pQVWJf4Rdh+NJoHgrIjzTTdkhVIuolpVJ?=
 =?us-ascii?Q?56UUvRE5iEJd7k3xZyGAkBq4MrvMUZ1dUJU5k+QMU48C4PhR7CoagS4Ly77h?=
 =?us-ascii?Q?uxtdOrXt2edNDKMEmuGm7M29oGdBd78Xsh+Kg3bilv/PV6FcAFAvytLFGndG?=
 =?us-ascii?Q?dWgkml0O5dvHO0KQdyOl6WFZ+JcCX6KavrKW4o0/7ImwY+1SkloArDH1wxDL?=
 =?us-ascii?Q?5DgW8Kaukjw71KjGPA9UGKaetSCzLod+fwmvE0jmJj6SX246hpEgXwWNqT3s?=
 =?us-ascii?Q?wrpdI6mxAD6c1KIiWZMSgREYDPC1MPpp81qJXdOSBx8kFCoSIid1KHx0b3k3?=
 =?us-ascii?Q?ynPEWsmIrev7RjFz/cOQ6qNY?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 127a649c-3642-4602-cd00-08d9923115d2
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:16:17.0313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GJupaujZ0RBa8IdVRRBAQ5s8ZoORCCqh8sYZf3qOH9JFlP14pZ7vI43TJiD2jLSDWP9fgH/q5QjPTjwpqY4Hhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2123
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/hwmon/tmp421.c:416:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return.

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/hwmon/tmp421.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
index 31e95b5749c8..1fd8d41d90c8 100644
--- a/drivers/hwmon/tmp421.c
+++ b/drivers/hwmon/tmp421.c
@@ -418,8 +418,10 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
 			continue;
 
 		err = tmp421_probe_child_from_dt(client, child, data);
-		if (err)
+		if (err) {
+			of_node_put(child);
 			return err;
+		}
 	}
 
 	return 0;
-- 
2.20.1