Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Oct 2021 21:17:25 +0900
From:   Takashi Sakamoto <o-takashi@sakamocchi.jp>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     alsa-devel@alsa-project.org,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire: Fix C++ style comments in uapi header
Message-ID: <YW1l1U4/isAd2xzc@workstation>
Mail-Followup-To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org,
        Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211018063700.30834-1-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211018063700.30834-1-tiwai@suse.de>
Precedence: bulk

Hi,

On Mon, Oct 18, 2021 at 08:37:00AM +0200, Takashi Iwai wrote:
> UAPI headers are built with -std=c90 and C++ style comments are
> explicitly prohibited.  The recent commit overlooked the rule and
> caused the error at header installation.  This patch corrects those.
> 
> Fixes: bea36afa102e ("ALSA: firewire-motu: add message parser to gather meter information in register DSP model")
> Fixes: 90b28f3bb85c ("ALSA: firewire-motu: add message parser for meter information in command DSP model")
> Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/r/20211018113812.0a16efb0@canb.auug.org.au
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  include/uapi/sound/firewire.h | 70 ++++++++++++++++++-----------------
>  1 file changed, 37 insertions(+), 33 deletions(-)

I completely overlooked it. Thanks for your reporting.

Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Regards

Takashi Sakamoto