Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH for-next 1/3] dma-buf: Fix pin callback comment
To:     Gal Pressman <galpress@amazon.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>
Cc:     linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        Oded Gabbay <ogabbay@habana.ai>,
        Tomer Tayar <ttayar@habana.ai>,
        Yossi Leybovich <sleybo@amazon.com>,
        Alexander Matushevsky <matua@amazon.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jianxin Xiong <jianxin.xiong@intel.com>,
        Firas Jahjah <firasj@amazon.com>
References: <20211012120903.96933-1-galpress@amazon.com>
 <20211012120903.96933-2-galpress@amazon.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <912154f1-5809-3854-f205-61f0b7545a1c@amd.com>
Date:   Mon, 18 Oct 2021 14:59:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211012120903.96933-2-galpress@amazon.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHFSWVFRcWVFcHQ5SUY5OU5WQ2MwRXRMOXFLclJqY1lIcU1JVzRNM0xqRy9P?=
 =?utf-8?B?TCtZekJkWmx2QTNzNmRpS0tHcFRkbHBCMlE0dzUxZ0VrcWpZTFp6RzI0WnVn?=
 =?utf-8?B?VzRHUDNrMlE0QytBMDU4clBzN25mT2V4bERZSnl4bG0rR1JQcVV0L3JQUTIr?=
 =?utf-8?B?Y3l0VTBhbmNTNWRCVkhSMExXYVNydEFTbHdRb3oyMkgvSHo5VGFoWkFKVTg4?=
 =?utf-8?B?aGlQb3huUzArS3l5VnZaNElvN2VVNHBHSkJub3ltY0ZSdXVQQzYxb3VXUEZm?=
 =?utf-8?B?cmhyd2ZqNEQreG5MRFV0S2hTNjB4NEppTytTVi9PNHUzSzZwSUw3WlAzcEh0?=
 =?utf-8?B?cExBeUg0N2wxbWJMbXVRTGZ2YVAzZHNQUStHakwyUWk1M2Y1eThnVzI0cFBx?=
 =?utf-8?B?WW9pS0dwaUlScERBbzBhUE1IWVRCdS9zNXZMQ3VlNUp0OWpsZkRxRmNHMjE4?=
 =?utf-8?B?Nk9aNENKNkpqM0h2T0pKN1RVK2tOZXF3QWM2cVNQVGUzM3B3NFhUOWhEcE8r?=
 =?utf-8?B?ZW4xcjFZQkVWUlNWVVJKUUFHbWxqb2Q0bTFBUGtVaDlCR0hrenhEKzJyQUQr?=
 =?utf-8?B?clJpQklhTGFIT0VWdEVHTStQVlZUS21mZWxERmNiRUVlNUtWcjVLb2ZMNlNY?=
 =?utf-8?B?TlYxbWpEa2xaUUY2aW9Hd2M4L1JDQW1SRVNQaG5sRitGNk9JYW9aeHVKOExn?=
 =?utf-8?B?MWZGSHE1bENlWmtqT0F0ZHBGR01NYUswb05LVVJLYnNhWENGeFlMdTd4UmJl?=
 =?utf-8?B?SmdvT1djT3QyMm4xWFNMVm5CZW1LUkhWeEtFTzJsOUpsNElra1ZMbjQzVVdj?=
 =?utf-8?B?aVBNQ2NpWDhVK0hCTG1RdzFPc1RqNmlxY1BaOFdtVENSR0haaWVhTmIvenRq?=
 =?utf-8?B?NWpHMXhkcUxXU1FOdS9mWDAyaGxubXpSOU9ITjU5UXFJcmR5Z3FhUzhwc3dr?=
 =?utf-8?B?REJ5S2RnMjdYNG1WTG5tQTBHcVhyTXYrdFN1UWdBYWt1c0JHOVMxTlZmQTY5?=
 =?utf-8?B?RVBxZjVDam5aMVRhTDFQSXBVSGo0eDJiTU85UHZWMTMrK2hMV0hRclNzT2Vx?=
 =?utf-8?B?VUhXejZPRTlBb1JJNmpjWFJvck1hcHFJd05xTEo1SHlwNlFjNVNhS2YvRU1l?=
 =?utf-8?B?WXdYS01DdVAxbFhvam1pRHBlUHM3Vm55Z0E4SzB1OFNROGFhTXQ0YnV1ODB2?=
 =?utf-8?B?eG1HNUhLR21vcG82djYvK3FsTlVGdFBLQVdyNzNvZjgzYlo0bm5ERXRPcDFi?=
 =?utf-8?B?MHFvbDlISUo0SmZCQnc4Ykw0cHpKSytiVWlaeWl4SGd0TGNSKzg1ajRzTU5S?=
 =?utf-8?B?MmNsNFdWOWd1N0VndFAreTRtT0htbERVaWRQY0xpbisxZ2FTZHMwTVFraU5z?=
 =?utf-8?B?NThQUlZ6YlYzd2lPRDFCL0xuQXUyKzNYcjFUb0lCVXN1TmJMQmRXdk1VRzdq?=
 =?utf-8?B?UXl1eCtKVzArdUs1U3ZKakxPK1Nsd0JDcHdpRWpmVDhZQnFSTXl0R09UcDB5?=
 =?utf-8?B?SUg1YzlFdTVaZU5yRitxUHhtZGpEUDZSdExESUFVQjkySXkwcHd0Q1RhSVpn?=
 =?utf-8?B?YWZvZjR1MTNpcVFiTmpqWit3ZlpEYmc2QzFVbjVVVThyaFVzQ2JieVlwSjBw?=
 =?utf-8?B?c1dnNFE4bGtOQ2tndDY0SnBneFZYMXpMc3pHWWJmVjczalQ1L2NCV0pLN3do?=
 =?utf-8?B?T2FTZUtiVW81T2hvSFlseW9DQUI3SFZ1Ui9UTnh1YWpPc2piRXg2WGhGRHBL?=
 =?utf-8?B?OWtYTzJJWnRGM0xobFFNTFpTTzRNMkJsOGpjZFBoZk0yU3VYelRjc3VsamlE?=
 =?utf-8?B?WHdMY1Fuc3EvS2t1QVBXQTVPMjQrVTg3WjdtQW93MTFSUDNINDBWeHJIMDBG?=
 =?utf-8?Q?h7O66mYs58d4r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a7da1c8-5c67-42fe-abee-08d992373133
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:00:00.3518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CvkdnlTCyfbQZRuln3cXMWdH8AAMdAJ7nqGStDenpax0f2sZET3v+SQXD70SMHiR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1341
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 12.10.21 um 14:09 schrieb Gal Pressman:
> The pin callback does not necessarily have to move the memory to system
> memory, remove the sentence from the comment.
>
> Signed-off-by: Gal Pressman <galpress@amazon.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   include/linux/dma-buf.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
> index efdc56b9d95f..225e09caeb98 100644
> --- a/include/linux/dma-buf.h
> +++ b/include/linux/dma-buf.h
> @@ -86,8 +86,8 @@ struct dma_buf_ops {
>   	 * @pin:
>   	 *
>   	 * This is called by dma_buf_pin() and lets the exporter know that the
> -	 * DMA-buf can't be moved any more. The exporter should pin the buffer
> -	 * into system memory to make sure it is generally accessible by other
> +	 * DMA-buf can't be moved any more. Ideally, the exporter should
> +	 * pin the buffer so that it is generally accessible by all
>   	 * devices.
>   	 *
>   	 * This is called with the &dmabuf.resv object locked and is mutual