Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3021273pxb; Mon, 18 Oct 2021 06:46:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuL+1WASezdPC9/dqQ5OfH0eG2USkrip8c4OxiVN/wkZiUPO/glCxpSV/wQ30LAOEw92w9 X-Received: by 2002:aa7:9d0b:0:b0:44c:62a6:8679 with SMTP id k11-20020aa79d0b000000b0044c62a68679mr28929347pfp.0.1634564762535; Mon, 18 Oct 2021 06:46:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634564762; cv=none; d=google.com; s=arc-20160816; b=TP26iz6H938LB55DnqE36kTKKwZEXg3ErZKOiXxBmpnLbQKu04Ko5XiLVYCxrHCQCo C+BqhcxU4sNGKO3DcwFwgC4towqGIf9GjibFc7H5+zcqCH7aZS5akT+rDo6RxbwluWS1 7qCOo5TFkWCkG0wEfVkEkN10zbbcTUmyardrZ6FPcUhk5bFk1PeJb5y4QR42yR8Ecol7 cawBy2j9ApscqXPPxwVRIJ6yT2zzUC1JsCeWuy7PzefiiTC21iijbxiTjcbucpugEjpP 2ikQCP0tnkp8kEA7DgAFL3q+Ahu6RjW2Ii6f4xWcpXu/W280gQvGBuzVo7t36qfHOzyb msfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BWqOfWWEAGvZknd1YvkrVTnPQNRuUACekOE9i82xolw=; b=HtgIyevF6eWiUiBzXLFH+Bje0j/zdw/5xvwBJfggaj7sCM7c5gkElzenVMzXwKHK1a 5w2zuaUBhbiLITRbVbHEM3o0we6s1RKEcN+CjcjXe9ZGJoRdKigBYR2MXTZ5gtb6ph+D oPBxvlX5zbbVUfZXSOJSahprmwM0z8WqX8bNYdJ+nhfYP9Ec1yHp1n2qixRRB3Odgefw VFheDNAIRt2XMkxQb7e/FNqWFgrI2Y4kurHkA1xwHl0hl4skxvtHl575zzmbU85zWF/B mkqp+X5Sqeauh8Qtp4E1jMLmLNzYdOdRNGcBPHLp1MpxYRInnXZJXiq7ZUJyzTO/tmZI nQ2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IzoAXzVq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a19si22842299pgl.425.2021.10.18.06.45.47; Mon, 18 Oct 2021 06:46:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IzoAXzVq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232165AbhJRNq6 (ORCPT + 99 others); Mon, 18 Oct 2021 09:46:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:40198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbhJRNoR (ORCPT ); Mon, 18 Oct 2021 09:44:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 33A66615A2; Mon, 18 Oct 2021 13:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634564106; bh=gg5zbCoLkAUDPeZuF+J83cdG60cdoGIwWITkWnl0mQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IzoAXzVqPuoGhcrGOGe4zpGcJQwlSL5AQmV4SEFIbWVeftLXOqCPIaP8dSekE17i4 rZIc/r3jHqatGm3lmNYfBdWpHXlJUcE7uozfpE3wL0s0i78UvdCzXSkgGTWnRUNkiy JsQPhR8QxpTLt13vbGNzNT3k2JLH/NWrJN6H1P+g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sagi Grimberg , Keith Busch Subject: [PATCH 5.10 067/103] nvme-pci: Fix abort command id Date: Mon, 18 Oct 2021 15:24:43 +0200 Message-Id: <20211018132336.995230343@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211018132334.702559133@linuxfoundation.org> References: <20211018132334.702559133@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keith Busch commit 85f74acf097a63a07f5a7c215db6883e5c35e3ff upstream. The request tag is no longer the only component of the command id. Fixes: e7006de6c2380 ("nvme: code command_id with a genctr for use-after-free validation") Reviewed-by: Sagi Grimberg Signed-off-by: Keith Busch Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1342,7 +1342,7 @@ static enum blk_eh_timer_return nvme_tim memset(&cmd, 0, sizeof(cmd)); cmd.abort.opcode = nvme_admin_abort_cmd; - cmd.abort.cid = req->tag; + cmd.abort.cid = nvme_cid(req); cmd.abort.sqid = cpu_to_le16(nvmeq->qid); dev_warn(nvmeq->dev->ctrl.device,