Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3027066pxb; Mon, 18 Oct 2021 06:53:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4wf/j8qD16Oj13UitELDQraM8bSQHvro1gA61S6DwVrOH2MzZ3xLq9H0F1FKScoqbYbgP X-Received: by 2002:a17:902:968a:b0:133:e2c5:4908 with SMTP id n10-20020a170902968a00b00133e2c54908mr27358434plp.2.1634565218243; Mon, 18 Oct 2021 06:53:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634565218; cv=none; d=google.com; s=arc-20160816; b=KHAjPXkMwxC81KMskV7qUf83kpYZDOqLC4dLB1E/fgpFB9AAHAFiBgDFHVuaDFkI3Y clJUEnlxZm6WSytUjehW6IaWXNbfy22AJT2LD/uHdDVTOgeLiT7pgCp+ohEoxiJ3AyI8 yEBLMLiIWCWN9NsBtWBiWWowQdBAvzSNbvcUBh8HfMIhP9HDJ552blFmXHGYh7Tvwai1 RGefiR3FRbjpbgEdRsgmb6KUOrsOvZ2M9uvLkgm0P/He2n7t7AQtZ5g84HFK3AAf6EO7 TDIIuxmtpyUOUN41ROWJ03+Vmm/ucs+PoNdljfYCglaGFfzNNYsNxBq3TyxevtgD2ScZ GAOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nW4Co8X1Oa3IbP+Mz2GP2Zu2gvwkghIZiL+BZFm+xnc=; b=sjRZ5rvYwKAorNj/Af3uaP0tCC9pJlFaLR4lrnu3Gk1c0w8vIEUOr+RmQZNPk0oYpj I0ckwbCeiSEurmiEhDTXFnADUPpsYI9TwnEBLJtO+VCJCTcWzNN6oB3BJEm118nXG8ER bQtCj86MMY3t1Z5akVFCERZYVPZ9hIGr8dC7NXjFAGUeLoGBocLzIEsAuI91cirwvMMN iHFNNg84YoPbYtNORPKQgjA9+bVWC4/NmKJFOnUDgY6OegO/t48gNpsRFlDVIFBm/AdJ PSU/BdwvR53mRQsHqskujjNPAK+nw7ZpoD3MEInGITNZSGebm3tgtkquESxpql/tkm7q PnwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx4si34157884pjb.28.2021.10.18.06.53.24; Mon, 18 Oct 2021 06:53:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232788AbhJRNxL (ORCPT + 99 others); Mon, 18 Oct 2021 09:53:11 -0400 Received: from foss.arm.com ([217.140.110.172]:38312 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233098AbhJRNvD (ORCPT ); Mon, 18 Oct 2021 09:51:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6A5A101E; Mon, 18 Oct 2021 06:48:51 -0700 (PDT) Received: from e121896.arm.com (unknown [10.57.27.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 43F4B3F73D; Mon, 18 Oct 2021 06:48:50 -0700 (PDT) From: James Clark To: acme@kernel.org, linux-perf-users@vger.kernel.org Cc: denik@chromium.org, James Clark , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org Subject: [PATCH 0/3] perf inject: Add vmlinux and ignore-vmlinux arguments Date: Mon, 18 Oct 2021 14:48:40 +0100 Message-Id: <20211018134844.2627174-1-james.clark@arm.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Perf inject was missing the --vmlinux argument so I've added it. At the same time I tidied up the argument checking that already existed in perf report and applied it to all tools. What I'm not sure about is whether it would have been better to check the accessibility of these files further down in a common place? It seems like vmlinux_name is also used for a non user provided name at some point so maybe this would be more complicated than just applying the existing check everywhere. Thanks James James Clark (3): perf tools: Refactor out kernel symbol argument sanity checking perf tools: Check vmlinux/kallsyms arguments in all tools perf inject: Add vmlinux and ignore-vmlinux arguments tools/perf/builtin-annotate.c | 4 ++++ tools/perf/builtin-c2c.c | 4 ++++ tools/perf/builtin-inject.c | 7 +++++++ tools/perf/builtin-probe.c | 5 +++++ tools/perf/builtin-record.c | 4 ++++ tools/perf/builtin-report.c | 13 ++----------- tools/perf/builtin-sched.c | 4 ++++ tools/perf/builtin-script.c | 3 +++ tools/perf/builtin-top.c | 4 ++++ tools/perf/util/symbol.c | 22 ++++++++++++++++++++++ tools/perf/util/symbol.h | 2 ++ 11 files changed, 61 insertions(+), 11 deletions(-) -- 2.28.0