Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3031317pxb; Mon, 18 Oct 2021 06:58:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqJt4ZddHUlfMR1MROOTctrMK8RSGa1r8rk+xf4kgm/C+gZh6BI2MzBya0i4Ocvikz6wB7 X-Received: by 2002:a17:90a:d24b:: with SMTP id o11mr17811267pjw.207.1634565525172; Mon, 18 Oct 2021 06:58:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634565525; cv=none; d=google.com; s=arc-20160816; b=yxDmMsRfsCvT/HUZESy9wTwsuFTzx3XfaFCH87bRpj2L/c9cJjYD/j7diDPWIY6HaM 2qNs7yIfiz4ALie6C5xlr5TSvynK2kHdfVTSoxgzhVls0QzK7h+Th4cS6830tWGZQy4h IAs+2jWA8qoJBFo3CeCwxxrGEtcQEm95hnldj1t9Tl8L+0x+2IoJKjD2bGweMYHhsR13 wIe9di9a2P8+KfLbfkbNE6RETfvDAItZL6PV0Uvr9Aw3ZZcTc5uVo3e5Y/CD6lgTtmun k7j+sbPyxJdz1kR6SeRIn0Gmv3SRJq50BZn7L/gucc+kaMY0qk9gRo6C1pyTRb0NBVaT mKSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kbyIbTFzdncEUJlNAwVCAQt+MM0og5Cg/77Qdpozhx8=; b=dFLMYZjuuZ3XYFMlCttvLgoALmk4OQVbRKI6URs2twtnjwR57ThcXRE07aOYqEbqWJ iXaGwoRDsUEVH0nJCGPQZXAivl/AcLvrGpAHFWgrmOHrzo9YFSznsIQCsKXVCLzQDquZ 7zEQ0iqszeJRHr77PyRbJ29oAwZ9ETwhmaluNLvf4dajePfxWputgDBmkmKon7OzaJDc Ba8Um+PG5GAlUyYNcsFCianKPxzB6toAdhI8jsPNw3T9ZZSmomDbnkpzJnbeHN18XrZc XYzIbzX/01gSakwh1A7StrNBdj+l0ZivxgaovOxWv/j00tOhNY96I9XBiZfvXudrl23B RIvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PwYP4SU5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v12si23400677pfu.224.2021.10.18.06.58.29; Mon, 18 Oct 2021 06:58:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PwYP4SU5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbhJRN7c (ORCPT + 99 others); Mon, 18 Oct 2021 09:59:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:57776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234116AbhJRN5Y (ORCPT ); Mon, 18 Oct 2021 09:57:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B6E4A61A52; Mon, 18 Oct 2021 13:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634564460; bh=J5hh4JfP+qOe5Gp7tcBGciG7iJE8Fdu59ov/wmhnTaY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PwYP4SU5HWrg8qI7LzkRzePWCYRxo27QCjsw5Ifqr/SdKf4W3MfL3fMzE+aK0qnEV yXfivNS1Zd5lYIqaoy4yv7jEJ8nISZWXsRkGdlqPFfCV6YYnsZUb4uFlwcQtXw4GQZ zjK45bLytqrXUkQSfzTarxHhbqIKl/W12KTgjphM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexandru Tachici , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.14 070/151] iio: adc: ad7793: Fix IRQ flag Date: Mon, 18 Oct 2021 15:24:09 +0200 Message-Id: <20211018132342.965244028@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211018132340.682786018@linuxfoundation.org> References: <20211018132340.682786018@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexandru Tachici commit 1a913270e57a8e7f1e3789802f1f64e6d0654626 upstream. In Sigma-Delta devices the SDO line is also used as an interrupt. Leaving IRQ on level instead of falling might trigger a sample read when the IRQ is enabled, as the SDO line is already low. Not sure if SDO line will always immediately go high in ad_sd_buffer_postenable before the IRQ is enabled. Also the datasheet seem to explicitly say the falling edge of the SDO should be used as an interrupt: >From the AD7793 datasheet: " The DOUT/RDY falling edge can be used as an interrupt to a processor" Fixes: da4d3d6bb9f6 ("iio: adc: ad-sigma-delta: Allow custom IRQ flags") Signed-off-by: Alexandru Tachici Cc: Link: https://lore.kernel.org/r/20210906065630.16325-4-alexandru.tachici@analog.com Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/ad7793.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/adc/ad7793.c +++ b/drivers/iio/adc/ad7793.c @@ -206,7 +206,7 @@ static const struct ad_sigma_delta_info .has_registers = true, .addr_shift = 3, .read_mask = BIT(6), - .irq_flags = IRQF_TRIGGER_LOW, + .irq_flags = IRQF_TRIGGER_FALLING, }; static const struct ad_sd_calib_data ad7793_calib_arr[6] = {