Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7 05/10] x86/tdx: Handle port I/O
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>
Cc:     Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20211005204136.1812078-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20211005204136.1812078-6-sathyanarayanan.kuppuswamy@linux.intel.com>
 <87v91v2zkk.ffs@tglx> <eadc3025-a32d-3641-de83-e5f05728a755@linux.intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <51511837-f712-35e2-fdb7-05a2c3f473cb@amd.com>
Date:   Mon, 18 Oct 2021 08:52:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <eadc3025-a32d-3641-de83-e5f05728a755@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1dCWFREVHAvSTNxS1Nya2lFajlpYWdMYmZLN1pSN3Z5MnpKWTZCTi9HaGpq?=
 =?utf-8?B?QmxpNXBDOXMyOXV3anlRWlhiTVBud0xSMkRnaUMrcjIwSTJ2MzNKenBUNWRE?=
 =?utf-8?B?TFB5Q2ZIMkRpRGRuMk1DVGM4d1V2b2R3dXl0SFdKNEphR2REM3dudUxYZUEw?=
 =?utf-8?B?a2ZXVnNlaUhpaDMzQXN1djBtSFJ5N01ubmQ3Y1hBM3dSaEFKWlVmVTNKcUtW?=
 =?utf-8?B?YjhSbTlMMDdOWlZrL1E4YUJCeFRmQXJnWUkvNnJRYVZXTFJ3NlliV0ZSZHY5?=
 =?utf-8?B?UGJ4SzF6TW9uZXVwdHJvRFNtVFdUN3pZWEJDR0QzNUprdWxFNWpsL29teWpR?=
 =?utf-8?B?U01PeHl0a0pvR1hvUlBUZlBicGl1K2lTWU5pWHV3anJvT2Z2S29HSzFXZ1kw?=
 =?utf-8?B?MmZlVHJLS2lGTnVpbDFyMHNqQ2lhTzh5SkpKeWJrdVc2WkxDTzNlTVZnakI2?=
 =?utf-8?B?ZUZPSW9WOXl3eXlUZnAwQ01jYXJoc1lGeFI0QXpOUFhvcWxVMWxUUmh0RDZ6?=
 =?utf-8?B?RjVFTm5VOGUyQzRmZDhhVjJuNytLVXBhNzlGOCt5OGxCNXhZQ1F4dW1RZFJ1?=
 =?utf-8?B?VHQ2QURMUjlxamFvNFF6M2hrUVFWSWI1UlFGR3hqQWwzUFdOenJlbEdwT3ZD?=
 =?utf-8?B?OTBGUXZxTlpOMVZQNGkzdHVkOUV0SlRyT0hyZVB6amMwQTlmWVVJQThZZncy?=
 =?utf-8?B?OElqVm91OTZYRGxXSXM2SWxyVDFINVlaTnVKOVFNdVMzZS8xR3E3d2tQVWcy?=
 =?utf-8?B?dXQybFpvbDQraDEyZ0s5bVJQU3lUbkFmRGdaaVR6Z3E3ODlFQnFwdEcvcTVH?=
 =?utf-8?B?a0cxQVBXLzFRY3hUQllpLys4Y0UzMndMQkdpTUNpK0d5cTkyVG5NZ25VNkhH?=
 =?utf-8?B?d3dSVDRUMUZlYlQrWXJTT0Z3cnQ3bDFuYkZQSnRORUNyVlhqNERjSFU0Nkha?=
 =?utf-8?B?b3Npbm1wWTNvTXVWL3dhNVMzZDAvQ3hJV0d5R0pxVE50VVliZGRNd3RZNjV0?=
 =?utf-8?B?Q2RuSC9WV0RhRkh5QlFsL3hmUm12NXFiSVhVMVloem1CbTNWbEVobTNtdkJI?=
 =?utf-8?B?c1N0TUFGOUJpQm81SnhXTEEvaDJhME9XY0pMWGxDc2lMbEdjL0VvMkx6UEZM?=
 =?utf-8?B?dElrMUxmdEFCTEVjUUMzSm1jczgvMWNQZE1xU1h0SEd4cyt2dFdPYzNVV0pi?=
 =?utf-8?B?WGRiTjd3NUVzT0R5YnoxeGlBOERlYU1oY253MDZOUjkrbHNhZ3RwMzU3SXNK?=
 =?utf-8?B?bC81SzFQM1RTaWt3eEZRV2dCQU5vck5jWWFSUStLRmRoRmpnZlBkR3dyTER5?=
 =?utf-8?B?bjYwRnRiQ0hnOG9jNmdVdi9DbTk5RGVkakxtb3pLanU0MW8zQW1JbFZRbklG?=
 =?utf-8?B?L3pxRDIzTDN1Z2FDeG1NK3oxd0p3YTVyM1VKOEZhSytrR1Y0ZDVNYXJJbjdL?=
 =?utf-8?B?MFRhMm5iYWxTa1BMTk5CSW51MmVPZG8zWWtDdnVaM2tCRDlPdUtwUlRWY2g0?=
 =?utf-8?B?SjVSL1RpNjRRZm9ZblVTdU81QzU5UWhvT2xUQ2UrTldiRDJtVlFrc1ozS3lI?=
 =?utf-8?B?OTc5QUZNaFhaU3Btd3UvbXozYS9UNWZCbkVMdkhDTHlCZzZtR0NjTHEwMm1U?=
 =?utf-8?B?UitjNmdmZVo0ZXlzdUlvejFuVVlkcnA0dE5zb2FVMW85QmdGWEJvaWc0eFYr?=
 =?utf-8?B?Qnl0MVhzSVpZOG1vbkNzL3pHZDh0Q0JGU0RmN1FDWFptaTVxbVVSL1NVUjc5?=
 =?utf-8?Q?hWb1RvmLLaXYWRwpCEEBxYR80lVzFCHSMATkvjN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ddc09f4-175e-4b47-617e-08d9923e8906
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:52:33.6669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9JnOLfytaj6uw4AyYxfAVESqpjD2I39Jy1/o+Hrv0lMT19skz7ulSeUFN7Z4B/uI03i+GUzSgTRgCWYR4UvxWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5448
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/17/21 3:35 PM, Sathyanarayanan Kuppuswamy wrote:
> 
> On 10/17/21 12:58 PM, Thomas Gleixner wrote:
>> On Tue, Oct 05 2021 at 13:41, Kuppuswamy Sathyanarayanan wrote:
>>>                                       \
>>>   static inline void outs##bwl(int port, const void *addr, unsigned 
>>> long count) \
>>>   {                                    \
>>> -    if (sev_key_active()) {                        \
>>> +    if (sev_key_active() ||                        \
>>> +        cc_platform_has(CC_ATTR_GUEST_UNROLL_STRING_IO)) {        \
>> Instead of adding an extra check, can you please replace that
>> sev_key_active() with cc_platform_has() completely?
> 
> Yes. sev_key_active() can be removed and replaced with
> cc_platform_has().
> 
> Thomas Lendacky also proposed to introduce as common
> static key which can be set by both AMD SEV and TDX code.
> 
> @Thomas Lendacky, any comments?

Either way works for me.

For the cc_platform_has() path, you will need to update the 
amd_cc_platform_has() to return true for CC_ATTR_GUEST_UNROLL_STRING_IO 
for SEV only, i.e.:

	case CC_ATTR_GUEST_UNROLL_STRING_IO:
		return (sev_status & MSR_AMD64_SEV_ENABLED) &&
		       !(sev_status & MSR_AMD64_SEV_ES_ENABLED);

Thanks,
Tom