Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3043894pxb; Mon, 18 Oct 2021 07:11:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIMeYqOlqfNQedehQ68Y2JjpHA/FlPYl5+reSMitaBHmAl48yiU54Z0s7D6lZgJ5MEixK7 X-Received: by 2002:a17:907:1119:: with SMTP id qu25mr29422681ejb.245.1634566279253; Mon, 18 Oct 2021 07:11:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634566279; cv=none; d=google.com; s=arc-20160816; b=AVPrR35LLnxdD+H58/wU2MuY7/IabOzsAymxzWCYOH6jzoNmontF6J6bwu1YtpiIu/ RjNq6PUrGTIFAc0qyYz8ygB07iO0ScYY8vXjIUCloLSNk/3Z177iqkorGtL9bbSEbA4r yWgbnQBcKEjRqtrzjhiYGqxws98ieDzpcwOlDRIrbJ3mM7OEFJz5QDQxCRB95Rb1FUCG y9hF+yDzDQmehfTBATBsSoeic+wdXpeZzT4HNf4LqVOulBofqSdWmjOHK9ciyxDkpo0B oS0jCH/elPvzjrs0IFkWJF4ria8XROKm6jWy069YSuW7XXUBIX6kn7cSi0n7VgDYbPFv GShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1tJYLIHYHewbnMqLCg7v0aQOvcz498ZvveryP9D9sB4=; b=uSJKQ6kjtsz9KRJg/3kbwQy1lr4kJm3HU9a0VvWCZFNad9FrZD64GhyJn6PDuZpkEb gU9dxNSfkODJh/1jMFdg6MYed888Sk0ZSnf4x4MxJDn5XSn+dGfhIksXX762txeqSO36 VOi0W2QakmqQm3I13/WmRskcLfJyNlKE4WtZfLnQl4IGqUY7DDQmNBTHqz+AeU8veMmO Ymlp3Dxj02xaFBn9MJeEUgBKlE7F6HX1MEQcClAuIhiYQ/oq4CA09Gp6N1ui8rtgS9im fgPIuAfSIfs+vHEgd2SEcCwxaKiSGqlzp0gjgs23tlGdyPgGdJpsPZfLoRnyQ4Jmvuog Zw0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eTzEfIZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si19580010edr.343.2021.10.18.07.10.53; Mon, 18 Oct 2021 07:11:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eTzEfIZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234456AbhJROHO (ORCPT + 99 others); Mon, 18 Oct 2021 10:07:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:39178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234795AbhJROC4 (ORCPT ); Mon, 18 Oct 2021 10:02:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B628361A59; Mon, 18 Oct 2021 13:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634564603; bh=9pu9bCzrkzvnXahF8HG3r/5hRxwLV8WZqkBLM5MNi2Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eTzEfIZd2R76YpwIdY8UiHTnEMHBnpTb3PlWSZ0wJn6Cy057lRi5CHzxtWTcxXcIT Y82V/Si7u2gQHSr9fpuHh1HuRD3kpUTd6IAZYwLVx9QMiO3K9d3DtgMp+A/StkYtYt rSzbtNrAo1ECiNcjlB3oEkqg+hecZz91jQ3XjwEg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , chongjiapeng , "David S. Miller" Subject: [PATCH 5.14 140/151] qed: Fix missing error code in qed_slowpath_start() Date: Mon, 18 Oct 2021 15:25:19 +0200 Message-Id: <20211018132345.210751418@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211018132340.682786018@linuxfoundation.org> References: <20211018132340.682786018@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: chongjiapeng commit a5a14ea7b4e55604acb0dc9d88fdb4cb6945bc77 upstream. The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start() warn: missing error code 'rc'. Reported-by: Abaci Robot Fixes: d51e4af5c209 ("qed: aRFS infrastructure support") Signed-off-by: chongjiapeng Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qed/qed_main.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed } else { DP_NOTICE(cdev, "Failed to acquire PTT for aRFS\n"); + rc = -EINVAL; goto err; } }