Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Oct 2021 15:02:34 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Kai Song <songkai01@inspur.com>
Cc:     thor.thayer@linux.intel.com, zou_wei@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: altera-sysmgr: Fix a mistake caused by
 resource_size function
Message-ID: <YW1+eiaWZDRTet21@google.com>
References: <20211006141926.6120-1-songkai01@inspur.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211006141926.6120-1-songkai01@inspur.com>
Precedence: bulk

On Wed, 06 Oct 2021, Kai Song wrote:

> Fixes: d12edf9661a4 ("mfd: altera-sysmgr: Use resource_size function on resource object")
> 
> The resource_size defines that:
> 	res->end - res->start + 1;
> The origin original code is:
> 	sysmgr_config.max_register = res->end - res->start - 3;
> 
> So, the correct fix is that:
> 	sysmgr_config.max_register = resource_size(res) - 4;
> 
> Signed-off-by: Kai Song <songkai01@inspur.com>
> ---
>  drivers/mfd/altera-sysmgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog