Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Zheyu Ma <zheyuma97@gmail.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Return -ENOMEM if kzalloc() fails
Thread-Topic: [PATCH] scsi: qla2xxx: Return -ENOMEM if kzalloc() fails
Thread-Index: AQHXw8Nn3ujM+Rx9pkqyuGt9dVCDEKvYzygA
Date:   Mon, 18 Oct 2021 14:20:47 +0000
Message-ID: <D717C3AD-1753-4785-80EA-B20A17506750@oracle.com>
References: <1634522181-31166-1-git-send-email-zheyuma97@gmail.com>
In-Reply-To: <1634522181-31166-1-git-send-email-zheyuma97@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rm04xfklupqNt3Dj5pasnG26bmdHyOvAayjQd+m3TrPcFeDzFrGYPnpUs+3D?=
 =?us-ascii?Q?1mQTaDu/zZJlTCGvno5FrHJbbQWaMcdU7Kfges6869jtGT/ejeldom9oCKoC?=
 =?us-ascii?Q?RGCTNCpW0llr1ScvEU6PDNsUWP92gjSmUmPu6diaFcvwmLaaw1QdT9L6/dEv?=
 =?us-ascii?Q?47U8hUNjMOdnd+WX/m2J2njeDJTcO46NiRvILhNvV+BJrZwlx+IJ07s3lz54?=
 =?us-ascii?Q?2FrZi7Z3V2y5ztfgAVYB5jY4dhGXuv9xJ7JcNRdwASMfcc03G99aAdQa+YY1?=
 =?us-ascii?Q?3tFA6ezmYsggmbw3GcyNcTtZRKXIy1gZNBF+u8eaYQp6Eb3pWJzPllIXL5rh?=
 =?us-ascii?Q?e9y1okLYozTyO4639j0wsDA54D5BgTfgk8pCvgvzVnS9uZqEJHLgFqJtyimR?=
 =?us-ascii?Q?9MlkHsGV50K/jA7f6I3sPlK89Gl+mozAO1BHA2rK7/bL8eBKn8k7VpsuMXBv?=
 =?us-ascii?Q?m+1XZUvkiVtM7bNG1+9E4gWmdt99+KMGvWMtYKEUPhfe9G8B4zhQbIkr7uny?=
 =?us-ascii?Q?2TwNKZ39xYe2Zo+Lzq8ysEMo67rKiolrtL/kogYkQxgUOnG6kJjNExD9HTNk?=
 =?us-ascii?Q?/WYmSTTVXKuV2qu9SnOSUT7p2AXl+IREXURgyCUQWZVifEqWod535u1Pir6+?=
 =?us-ascii?Q?XDfmlPBleVRhMh+4lco01goMhfNh+OOM6SqFi4p1xJXj7cRPvgCpGCGaSCSf?=
 =?us-ascii?Q?ttq4/pCtlRiDY9x4cVc9YdMp94g3JdL56Av/IOhs+m4nYU0T1g+ZdiRuxOem?=
 =?us-ascii?Q?nfDOdW6a8ISehrH8hUccY0n1ahXoTAxjGkQR+t7oa3EYG98jr/IifERfgrey?=
 =?us-ascii?Q?/m2v1t4Vw8I1Dgp2WQCv5MhbalKpPGS9KpmUvxAx3otlA3u/OgDR5ukwsaWB?=
 =?us-ascii?Q?bBDb1NClgYez5phAedtVDLZvyd0e9d9Vf8op0qvoepYc0/JjC3ZnNHP4Z5Mb?=
 =?us-ascii?Q?myp4St3RluX0ideDjcrhpNpN6Tsp4x4OTVw5otEozvT8iMLSj4RqZ+PcmB9Z?=
 =?us-ascii?Q?FsyslDYImXq9BC2C/PVTdMW7zS/9JRaEJA+DBk+q5vQXuYSHeFcXOYv7ikUe?=
 =?us-ascii?Q?QDPzAtWhb5ByjGhnLQ/pluRi9LcN1Yuakum6vJrvgq6cZ4/gBVANQ/CK+Uz5?=
 =?us-ascii?Q?eoGnLkukTRZfnxIBdtM6mHeNxgjlTIxlc8TAAWC4oudFQYkinvNueXaatTEB?=
 =?us-ascii?Q?NerrnS+AHJ+rMulz6cCchhL/3CNlgR5ZOWQEMS26wY7bEFuQcgaobEDjhMGs?=
 =?us-ascii?Q?Vkm0HfAWVz4oZFkh2+GbTo5dxAuAX0vC1ZAYpsVlFXH7Vv1mO9picGxI02Ns?=
 =?us-ascii?Q?4d0TDsMoPyNPbKpzISRBLBvq?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <67CBBB9D40F29A4EA0BE25AF20A68CE9@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2932.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2fd6ee4-212b-44db-9ecf-08d992427abf
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 14:20:47.3601
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BB5jZDhOBQJlDuD0AJqCoU0eENURVbtMTfM9yQL5S8QZpIsEcKd2KJ24De0ArxYnbuv+hx7xSF6HzospbJZOg93q7jRx33QAkKMickCm4cQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4013
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10141 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110180089
X-Proofpoint-GUID: VJ7TefrFTWmfiqqAUnpcQpQTFwE4WK-k
X-Proofpoint-ORIG-GUID: VJ7TefrFTWmfiqqAUnpcQpQTFwE4WK-k
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Oct 17, 2021, at 8:56 PM, Zheyu Ma <zheyuma97@gmail.com> wrote:
>=20
> During the process of driver probing, probe function should return < 0
> for failure, otherwise kernel will treat value > 0 as success.
>=20
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.=
c
> index d2e40aaba734..836fedcea241 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4157,7 +4157,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t =
req_len, uint16_t rsp_len,
> 					ql_dbg_pci(ql_dbg_init, ha->pdev,
> 					    0xe0ee, "%s: failed alloc dsd\n",
> 					    __func__);
> -					return 1;
> +					return -ENOMEM;
> 				}
> 				ha->dif_bundle_kallocs++;
>=20
> --=20
> 2.17.6
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering