Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Mon, 18 Oct 2021 07:24:21 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] hwmon: (tmp421) Add of_node_put() before return
Message-ID: <20211018142421.GA1151312@roeck-us.net>
References: <20211018121538.16482-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211018121538.16482-1-wanjiabing@vivo.com>
Precedence: bulk

On Mon, Oct 18, 2021 at 08:15:37AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/hwmon/tmp421.c:416:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before return.
> 
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/tmp421.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
> index 31e95b5749c8..1fd8d41d90c8 100644
> --- a/drivers/hwmon/tmp421.c
> +++ b/drivers/hwmon/tmp421.c
> @@ -418,8 +418,10 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
>  			continue;
>  
>  		err = tmp421_probe_child_from_dt(client, child, data);
> -		if (err)
> +		if (err) {
> +			of_node_put(child);
>  			return err;
> +		}
>  	}
>  
>  	return 0;