Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     leoyang.li@nxp.com
Cc:     youri.querry_1@nxp.com, linux-kernel@vger.kernel.org,
        Robert-Ionut Alexa <robert-ionut.alexa@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: [PATCH 5/5] soc: fsl: dpaa2-console: free buffer before returning from dpaa2_console_read
Date:   Mon, 18 Oct 2021 18:10:34 +0300
Message-Id: <20211018151034.137918-6-ioana.ciornei@nxp.com>
In-Reply-To: <20211018151034.137918-1-ioana.ciornei@nxp.com>
References: <20211018151034.137918-1-ioana.ciornei@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y773kxi2IPvLAAVAB4oknzBFpxFiDXW4BAqclG7qtaYabXtV/aSjbl1twMKI?=
 =?us-ascii?Q?ogXCWoraCVQHO8rNL6WIFYBrT23TFTZAoF7QFpxXPoxyAb5T4OTVYATm5g3A?=
 =?us-ascii?Q?tIlf/HvY4FqdH1J9VHBKqntZGyanJo52MlyzPqjBj/fPvpKGQAeDVOtH7wix?=
 =?us-ascii?Q?6gHxF3EwaJNnaBJT08vU9Dxcf/5qhph9NlHHcwuyQ+TECTb0mLaCzhsyONOS?=
 =?us-ascii?Q?eKLd5izd9o5buX8QOCRDdhBRCpdSA7Yj+GgWJo5/Dktr+MaoS+O2hnPXdwjI?=
 =?us-ascii?Q?0wspfXOdouafO4RgC1aA7lqEEVvDCOoOL1VDa6gjSgpAFIpk5/R6wUSDNc42?=
 =?us-ascii?Q?6t/lDYZjnhR07mH/9NOvA0jkmbGbTL7UoCwdDJQyUhkWki5GKA50gqR0fD55?=
 =?us-ascii?Q?aLbw3koonP+ESQX7npUZTa23hCZ3ZkZw3UHgRw+vM30wJq91TADZC9RUi3Ix?=
 =?us-ascii?Q?w3WUpoglXI9PPYVMKq67dTjEd2GAvLZGmNnCa12akCEDJtk7TzlWe0UobrZI?=
 =?us-ascii?Q?udvlJs1FBEBQ7dOLnR2tGxjW3YvVKgJh+mucQFO816ZmclzX+5FVNT55NO/i?=
 =?us-ascii?Q?YRPkeQBxmj6UAFPb67As0sKxmYEiULoONVYxoBKGZvTq9kCl9gpfOR4ZP7TO?=
 =?us-ascii?Q?pFxeiSWnPXn59AQCM2EcZhQVn9aSzH0I3eXp6OM+8dL7ONnwy/Vswp82Bh3z?=
 =?us-ascii?Q?sA+k4Ga+bZ4anT48StlUfQP9/CrF+Bekj62X7GLBu69imVrWXETOVY6O8IOh?=
 =?us-ascii?Q?XMZNZz+pccBF2iTuQ389m50vPBjq6olnxOIXf0Z8zU4SJI/FE2WrBFk9Oc1i?=
 =?us-ascii?Q?kHQR3KtpbscLjSroafqkpHxcUyUIG7KtaLamXvvjchd8h9ylTuJZoB7rDEog?=
 =?us-ascii?Q?Pquha9AdOnfW5kVyXafPf751uX8Ts5GFfb92TqmSzkxoSxF7RB7flA7QwZko?=
 =?us-ascii?Q?hTxlwdvoAhyqNNnzkkbP77WRANaamOG6xxGhjnUO//ZhQ0cf6za5bCkj4GWe?=
 =?us-ascii?Q?6dtDJiQdswo6+i7IiYfCXIHJgLW/0oNWmCqlAn5r3BJpiqx9MvSQzAXaPz0G?=
 =?us-ascii?Q?jsV0pFpyfiNnNCH2HHitRyBGunnLhwJZU35eK/qOQvRRDt+D/N0NKlWGFtRl?=
 =?us-ascii?Q?xQLU/pw2EnRJuZYDGxSTqoD+0Hw94wz5WVOsSaP74ZMUsmcq/qGQ41yuDZbq?=
 =?us-ascii?Q?fzZ/WdOzqPCTfFpUKzoXZRCVf8TpQ4EcGVqpYGCSfi5CqRQZBSv3zzLlBlny?=
 =?us-ascii?Q?Cjh9Xx496K5H0/1uhCt6Azok9TMIaJMBYtBFfv7rlrPE5q/dQQSXPQvxJnyq?=
 =?us-ascii?Q?V9rOAUXyFYY72w3SWt1yXhRi?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 016bf510-5e8c-4cce-acd3-08d992497ea6
X-MS-Exchange-CrossTenant-AuthSource: AM4PR0401MB2308.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 15:11:00.6675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZlCZtAxJ/FZXC3lwLqKCWJ0rB3/Othka5VEKtx+4kojt8QtwN2yZZ6p4/T6Z+EHY25BQOJAKRpIpnIGL8T8rHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7268
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Robert-Ionut Alexa <robert-ionut.alexa@nxp.com>

Free the kbuf buffer before returning from the dpaa2_console_read()
function. The variable no longer goes out of scope, leaking the storage
it points to.

Fixes: c93349d8c170 ("soc: fsl: add DPAA2 console support")
Signed-off-by: Robert-Ionut Alexa <robert-ionut.alexa@nxp.com>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/soc/fsl/dpaa2-console.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c
index 27243f706f37..53917410f2bd 100644
--- a/drivers/soc/fsl/dpaa2-console.c
+++ b/drivers/soc/fsl/dpaa2-console.c
@@ -231,6 +231,7 @@ static ssize_t dpaa2_console_read(struct file *fp, char __user *buf,
 	cd->cur_ptr += bytes;
 	written += bytes;
 
+	kfree(kbuf);
 	return written;
 
 err_free_buf:
-- 
2.33.1