Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Oct 2021 09:06:57 -0700
From:   John Fastabend <john.fastabend@gmail.com>
To:     Wan Jiabing <wanjiabing@vivo.com>, Shuah Khan <shuah@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, linux-kselftest@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Message-ID: <616d9ba173075_1eb12088b@john-XPS-13-9370.notmuch>
In-Reply-To: <20211012023231.19911-1-wanjiabing@vivo.com>
References: <20211012023231.19911-1-wanjiabing@vivo.com>
Subject: RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in
 cgroup_helpers
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> than once.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Fix the commit description.
> ---

The Subject is a bit unusual. Typically it would be something like,

 "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

For the actual patch though LGTM.

Acked-by: John Fastabend <john.fastabend@gmail.com>