Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754974AbWL1UvI (ORCPT ); Thu, 28 Dec 2006 15:51:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754976AbWL1UvI (ORCPT ); Thu, 28 Dec 2006 15:51:08 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:33654 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754974AbWL1UvH (ORCPT ); Thu, 28 Dec 2006 15:51:07 -0500 Date: Thu, 28 Dec 2006 21:50:55 +0100 From: Pavel Machek To: David Brownell Cc: Linux Kernel list , Andrew Morton , Andrew Victor , Bill Gatliff , Haavard Skinnemoen , jamey.hicks@hp.com, Kevin Hilman , Nicolas Pitre , Russell King , Tony Lindgren , pHilipp Zabel Subject: Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers Message-ID: <20061228205055.GA2311@elf.ucw.cz> References: <200611111541.34699.david-b@pacbell.net> <200612201312.36616.david-b@pacbell.net> <20061227175344.GC4088@ucw.cz> <200612281248.21325.david-b@pacbell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200612281248.21325.david-b@pacbell.net> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 41 Hi! > > > From: Philipp Zabel > > > > Missing s-o-b? > > Yes, still ... > > > > +static inline int gpio_direction_input(unsigned gpio) > > > +{ > > > + if (gpio > PXA_LAST_GPIO) > > > + return -EINVAL; > > > + pxa_gpio_mode(gpio | GPIO_IN); > > > +} > > > > Missing return 0? > > > > > +static inline int gpio_direction_output(unsigned gpio) > > > +{ > > > + if (gpio > PXA_LAST_GPIO) > > > + return -EINVAL; > > > + pxa_gpio_mode(gpio | GPIO_OUT); > > > +} > > > + > > > > And here? > > You're looking at about the oldest version of that patch. > Admittedly there were too many floating around... I think I've looked at the newer ones, too, and this particular return was _not_ fixed. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/