Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3163472pxb; Mon, 18 Oct 2021 09:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxt4jKCVZMjuXxg0zelM/X3PAu5ulhNHjpb6GzlGtx4LX0vqO2rLEzrV5Mnlaz8DiyXjvHR X-Received: by 2002:a17:907:16aa:: with SMTP id hc42mr26925797ejc.39.1634574177774; Mon, 18 Oct 2021 09:22:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634574177; cv=none; d=google.com; s=arc-20160816; b=Tiud9xPDASf6gayi0+oywARBWlBREXdEBv6usbeCn9NK8QT7xIGDGH5DN6Czm28Uvc pDGuJ4+ic3bXa3MTRoWYHA/oMXFFPNB9/N1QVTnTruMEa/an791YbX3WYF1VmKUKOU3D ArBJN/zFCMoEy7Rr5nWCwGx0QRPTsZfv9PcQ+Y8IB+wBV75BhnEfdsuMYNaYJsBQ2MYx IYeOGfwAaG2dkjJz5kVHGA3n/FNgpWQeUBdzq8VA1I+HAtm4vCf4qj/svCSmdKCGWpBI ILh6Osgv6NJdppnUv+onW/0KWBf3D3f2En5piHnaGfhJC/qoLBYSvZNZZQNW8+VrE4aA fpww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=tCa2ZXn2lj7SQc6pTjXTaeYtdJGeIQzfHH1jMZ3fa6E=; b=JpYwoIeXkk/xh4KOXcuw8sJsmmy03mV15zLDJPC29y8/YZwjFQ1fM7Xqjas6BZvPrb 0UVQS+9n+Oci4BdCEJrH3xbDZxL4QBKBep7K10Namjh5o/DIENq033yR10MaFqXpZa4R 9sbAyM5EMkusQMG1DXoDDJeZMjlxNOuxqrzJ97cREcS8wqITiwBNzXUNHY6NdZIyhJ7j 5ZemndYRHLZwo/Fu2RkKyF5xzdlJ6Zoi/D7OUAZ8a8yoagoUKHwtwWkYnhkX8KGABtuN j+72rI5NtL2v1gk3tls+b96Cocf720tGkB2QdmcFZmgqOngnOBEO/1dPjqLtf7Ne65zU o4aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sb9si21069509ejc.163.2021.10.18.09.22.34; Mon, 18 Oct 2021 09:22:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231787AbhJRQUz (ORCPT + 99 others); Mon, 18 Oct 2021 12:20:55 -0400 Received: from elvis.franken.de ([193.175.24.41]:55145 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbhJRQUx (ORCPT ); Mon, 18 Oct 2021 12:20:53 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mcVLT-0008Tz-03; Mon, 18 Oct 2021 18:18:39 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C05E6C2616; Mon, 18 Oct 2021 18:18:00 +0200 (CEST) Date: Mon, 18 Oct 2021 18:18:00 +0200 From: Thomas Bogendoerfer To: Wan Jiabing Cc: Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] MIPS: Loongson64: Add of_node_put() before break Message-ID: <20211018161800.GD16375@alpha.franken.de> References: <20211015070122.11467-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015070122.11467-1-wanjiabing@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 03:01:22AM -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > ./arch/mips/loongson64/init.c:174:1-22: WARNING: Function > for_each_node_by_name should have of_node_put() before break > > Early exits from for_each_node_by_name should decrement the > node reference counter. > > Signed-off-by: Wan Jiabing > --- > arch/mips/loongson64/init.c | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]