Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a77dd608-1297-1522-7161-197258906ac0@intel.com>
Date:   Mon, 18 Oct 2021 09:27:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH linux-next] e1000e: Remove redundant statement
Content-Language: en-US
To:     luo penghao <cgel.zte@gmail.com>
CC:     Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        luo penghao <luo.penghao@zte.com.cn>,
        "Zeal Robot" <zealci@zte.com.cn>
References: <20211018085154.853744-1-luo.penghao@zte.com.cn>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20211018085154.853744-1-luo.penghao@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmJjOFd5cldCWC9lUE5kdk13YVFzRmRrS1BCdTRReVh6V2YvdUFGYzhpMGVV?=
 =?utf-8?B?L0ZVeDM1WkZiYmpXbllST0RhRStSL0xTbGE0NjNvb2RBbFU4bnJHa2ttMmtT?=
 =?utf-8?B?bE1JRzlqbFVYY1pkazlPSDROdUxKMmlGOU51ajZ6MTV3UjgwMmhOSEs5WmJl?=
 =?utf-8?B?Vng0N2hvT3dJK2RSZE43ODJCZUFNcGJ0dW1uT0J3NUtDZzdweWlTbFMxQ3Nh?=
 =?utf-8?B?akdYc2w0NnVyWU9VMjFvYUZOMlZmVytvL0VJZitjYVgrRzdWOURpL3J1dGN4?=
 =?utf-8?B?T1NiRTZTN2RHRFZmQmVscmxETUEzUVNDRGlQaVVITEZsZFFSRXBIeTZFWmdV?=
 =?utf-8?B?RFVEaDl3eW5DYTlCak9wNUJVZzBNbTdmeVNlUjhnd1BCem05OVkzK095NHAx?=
 =?utf-8?B?Z3JIWnZmSFRoOWFkZUx1UEliTEdUODBuaEFIaVdqTmlvSEt1T0tCZ2g5bkNo?=
 =?utf-8?B?RmhCZDhTQkJjcnpJU3lWU0Q3RUVORXlyUCtxcytlMDc0dVJpRXlIaWk5VEFz?=
 =?utf-8?B?UGtHRHZLUkhYRnpJTkFhUTZsbU9vU0k2TCt1TzlYeGpkUXd6Uml3ZHR6ZnZF?=
 =?utf-8?B?L3Job09ORkI2WWJtaTMwS1QzUXFYRnI4UkVNWUlmNUV0WlVIbHQyUGFYVkxq?=
 =?utf-8?B?OEczU1B0WEdwNnhwcGhBMHRuMHBDVkpncytrMklFMHpzOG9MU0FKOVRCTFYv?=
 =?utf-8?B?aXgyanRwUzUvV3dXYU1DYWZlem84NDhlMm56ZEJ6aUhaNEVzNW9zUlovTXRw?=
 =?utf-8?B?VklpTGY5UC9IWitGRnBwTWgzd3hUdDVHdVBNMnZqc1lmMHp1U1U0aWJFVWZv?=
 =?utf-8?B?R1JISkRvV0pFUVdQczJ3RHBCZnpSdzFYWEdGM0N5ZjIrMVpJNTJ3Y0pFWmla?=
 =?utf-8?B?MW5UcWJ2SGtEZmZmS3ZjcGwzNVZkK0RYZlh1N2lVdTYwcEw1U1FQQTUrYnpX?=
 =?utf-8?B?aWlQaXRqTDZVTHVxY0pKL2dleWY2R0NsTEtmOEIzdkRUazEyN1pjdDZMYnVz?=
 =?utf-8?B?aXFMOUh3dUxSOGUwYkpjTk1hSldaQi9TYUdyNkh2eHRMeGcyZUU0Z3lZRnJo?=
 =?utf-8?B?NlRVdXV4R05RN2VYdXl3YjZ1WUQ3cjdMM0ZaZjZML1V4aDBkWitnWTZ5aW9a?=
 =?utf-8?B?ZHhtOGVRQWFCeWNtMUwyRS9LdlNhVVRrLzN3S0pVbUVkKzEyVmVTcnBsWGQ3?=
 =?utf-8?B?WktYU3F2WFJ6eXpkLzNZaGdpRWR6UW40MHJCekNXaFp1Ly9yWUhqZFQ2cWRq?=
 =?utf-8?B?N1VEazJEYUxKRHI1SVd5REhsajZZS3h5TlFoNThtRXJtc2RJOW0vVm9xZEIz?=
 =?utf-8?B?Q2phdU9KL1FMMXplMkpicFZySDN2MnZoTUdPNVo4NVFjQi9TYnZUeE5XS2hY?=
 =?utf-8?B?b0hvbkdkSWhCbWlLVmg5aFJyNGxId0M2eDNWZGY2dC9haUdNR3gxWjlSYTRW?=
 =?utf-8?B?UjYvYjdRRHQ5ZDVMa3dNZGJuNmdkNzAxTE9MTXRna2ZTdTBXdktVZ0RnYzk0?=
 =?utf-8?B?QmZ5L1Exa01aU3l1QzM1RVo1d3BST0sxczJhbXJreE9lelQxWUR6dVlVa1RW?=
 =?utf-8?B?Mk1lN2FOZU1Fb1pxYUUzYVNEalFMaE1CdEZIKzZoaXhUSUxKQUZ0aUlQOWox?=
 =?utf-8?B?dkQxWUExVDl1N0VXakN1MHNoR2lYeVJJZjFpRi9RVDlnMTJjUW50Z1lTZ2Vh?=
 =?utf-8?B?Wm94cUpENzhVY3BndnZEWlVuZjAzWmxlN3phdWs4Z2srNEtodkJlNVZ5Q1lQ?=
 =?utf-8?Q?DttiR8JEZ8yRia0S7vmxDam5gdw1e+h61r0C06S?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 722b968c-3810-4737-6d55-08d99254299e
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 16:27:22.4405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jh3NB9fQutHGFbx8aM/OsMIL6o6mBBY+PmrXKt49GtRxAf3zMJ9XtWkCyBi2qPbux5lWw53Jxdp99s9NbqG1T6GyUnix/lRVb2e0v704Cwk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4602
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/18/2021 1:51 AM, luo penghao wrote:
> This assignment statement is meaningless, because the statement
> will execute to the tag "set_itr_now".
> 
> The clang_analyzer complains as follows:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:2552:3 warning:
> 
> Value stored to 'current_itr' is never read.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>