Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbWL1VAF (ORCPT ); Thu, 28 Dec 2006 16:00:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754986AbWL1VAF (ORCPT ); Thu, 28 Dec 2006 16:00:05 -0500 Received: from rgminet01.oracle.com ([148.87.113.118]:63264 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754982AbWL1VAD (ORCPT ); Thu, 28 Dec 2006 16:00:03 -0500 Date: Thu, 28 Dec 2006 12:58:05 -0800 From: Randy Dunlap To: Andrew Morton Cc: Tim Schmielau , lkml , Al Viro Subject: Re: [PATCH] remove 556 unneeded #includes of sched.h Message-Id: <20061228125805.2edc0a2b.randy.dunlap@oracle.com> In-Reply-To: <20061228124644.4e1ed32b.akpm@osdl.org> References: <20061228124644.4e1ed32b.akpm@osdl.org> Organization: Oracle Linux Eng. X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 28 On Thu, 28 Dec 2006 12:46:44 -0800 Andrew Morton wrote: > On Thu, 28 Dec 2006 21:27:40 +0100 (CET) > Tim Schmielau wrote: > > > After Al Viro (finally) succeeded in removing the sched.h #include in > > module.h recently, it makes sense again to remove other superfluous > > sched.h includes. > > Why are they "superfluous"? Because those compilation > units pick up sched.h indirectly, via other includes? I'm half done with a patch to remove includes of smp_lock.h. For the files that I have patched, I checked each source file for all interfaces in smp_lock.h to verify that none of them are used, so the #include is just waste. > If so, is that a thing we want to do? Nope. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/