Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fae1a43259879b797bb13ac8dcc2579246977b2e.camel@perches.com>
Subject: Re: [PATCH] s390: replace snprintf in show functions with
 sysfs_emit
From:   Joe Perches <joe@perches.com>
To:     Vineeth Vijayan <vneethv@linux.ibm.com>,
        Qing Wang <wangqing@vivo.com>,
        Stefan Haberland <sth@linux.ibm.com>,
        Jan Hoeppner <hoeppner@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <2b1b939e1ea960c2268791f3007305955a70a90f.camel@linux.ibm.com>
References: <1634280655-4908-1-git-send-email-wangqing@vivo.com>
         <2b1b939e1ea960c2268791f3007305955a70a90f.camel@linux.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
MIME-Version: 1.0
Date:   Mon, 18 Oct 2021 07:20:39 -0700
User-Agent: Evolution 3.40.4-1 
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-10-18 at 13:50 +0200, Vineeth Vijayan wrote:
> Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>  
[]
> On Thu, 2021-10-14 at 23:50 -0700, Qing Wang wrote:
> > show() must not use snprintf() when formatting the value to be
> > returned to user space.
[]
> > diff --git a/drivers/s390/block/dasd_devmap.c b/drivers/s390/block/dasd_devmap.c
[]
> > @@ -731,7 +731,7 @@ static ssize_t dasd_ff_show(struct device *dev,
[]
> > -	return snprintf(buf, PAGE_SIZE, ff_flag ? "1\n" : "0\n");
> > +	return sysfs_emit(buf, ff_flag ? "1\n" : "0\n");

It's more common to use

	return sysfs_emit(buf, "%d\n", ff_flag);

> > @@ -773,7 +773,7 @@ dasd_ro_show(struct device *dev, struct
[]
> > -	return snprintf(buf, PAGE_SIZE, ro_flag ? "1\n" : "0\n");
> > +	return sysfs_emit(buf, ro_flag ? "1\n" : "0\n");

etc...