Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Oct 2021 22:02:04 +0300
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
To:     Maxim Levitsky <maximlevitsky@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        linux-realtek-soc@lists.infradead.org,
        Oder Chiou <oder_chiou@realtek.com>,
        Ping-Ke Shih <pkshih@realtek.com>, nic_swsd@realtek.com,
        Derek Fang <derek.fang@realtek.com>,
        Hayes Wang <hayeswang@realtek.com>,
        Kailang Yang <kailang@realtek.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        LKML <linux-kernel@vger.kernel.org>, info@ayaneo.com
Subject: Re: BMI160 accelerometer on AyaNeo tablet
Message-ID: <YW3ErLKGtmyhSFd3@smile.fi.intel.com>
References: <CACAwPwb7edLzX-KO1XVNWuQ3w=U0BfA=_kwiGCjZOpKfZpc2pw@mail.gmail.com>
 <CACAwPwYQHRcrabw9=0tvenPzAcwwW1pTaR6a+AEWBF9Hqf_wXQ@mail.gmail.com>
 <CAHp75VcEZ19zUU-Ps=kAYJDX1bkxmOqmHii36HE2ujC3gROkNQ@mail.gmail.com>
 <CACAwPwaj_ekK6j9S4CRu6tRTPyjffgDhL3UFnhoYSyJSkAkmpw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACAwPwaj_ekK6j9S4CRu6tRTPyjffgDhL3UFnhoYSyJSkAkmpw@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Oct 18, 2021 at 09:02:40PM +0300, Maxim Levitsky wrote:
> I also suspect a mistake from the hardware vendors.
> 
> I attached all DSDT decompiled, which shows that they indeed use that
> ID, and I also attached the windows driver .INF which was published on
> their website  with the driver (https://www.ayaneo.com/downloads)
> 
> They are a small startup so they might have used the realtek ID by mistake.
> I added them to the CC.

Thank you for sharing. Seems they indeed used (deliberately or not) the wrong
ID. So there are questions I have:
- Is the firmware available in the wild?
- Do they plan to update firmware to fix this?
- Can we make sure that guys got their mistake and will be more careful
  in the future?

Realtek probably should make this ID marked somehow broken and not use
in their products in case the answer to the first of the above question
is "yes". (Of course in case the ID will be used for solely PCI enumerated
product there will be no conflict, I just propose to be on the safest side,
but remark should be made somewhere).

> BTW, I also notice a rotation matrix embedded in DSTD, but the linux's
> BMI160 driver doesn't recognize it.

This is done by the commit 8a0672003421 ("iio: accel: bmc150: Get
mount-matrix from ACPI") which needs to be amended to take care about
more devices, somewhere in drivers/iio/industialio-acpi.c ? Jonathan,
Hans, what do you think?

P.S. As I said, the commit message and the code (in the comments) should
be very well elaborated and only accepted in case the firmware is already
in the wild on the market.

-- 
With Best Regards,
Andy Shevchenko