Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3359083pxb; Mon, 18 Oct 2021 13:34:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykWCpA/DOfGDuRlNr3GwhBRaeKsl34y+Z4kcVJnIZdM+fJgNNOdo2jbjoZ9WceNITcJrSg X-Received: by 2002:aa7:914f:0:b0:44d:6f5e:f11a with SMTP id 15-20020aa7914f000000b0044d6f5ef11amr30636302pfi.10.1634589273319; Mon, 18 Oct 2021 13:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634589273; cv=none; d=google.com; s=arc-20160816; b=AKpma9HBENmSqVXO4E+ne/WkKjYIiPjj4lmX9SdilBPhgEN9K9qMrc7GAv/BI38Pig S1kUyOu67HAF/v9q4sLQlW2ZsVV5w02+k53hJGKonCKO2vMTFsfK1WPTPOVqosSo+Ero sirPFcgMNNUIQtjObPpZMRP+8Z2BkJQ83ZFWP/e7KJ4h5Fu3vGMSsFAnn7SHgV6miRVh ItVlHTVTJuyOs2T5FLiAZIBNmMIq/tybA32Fxpf3Cohj/weCR0l+y/NnIBHOEX4RdN+o DZMC8MiHm0+ou8OyfPhaWbPD5gwJfCExBB4ZE3i2pFqVfladKql7/t+VfbZeqOLd3lBC 5pGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OBMvbiCZ3mmK4xvpOD56mvuToBpo4s4ONuPdaMpMXso=; b=WCceYPRtDXNIyrJvSmxZtMGOSnlPhNmpIxIMT9jp4RpUqLfRPLmwrUeZH1AopF3yav 6IBLSVKp+zJLcPv3dYR9+Iw6P5vnARX4/nhDnN8cBx0XsvJFZEBR4Ob7NFh7Eo8Fb8bm WIpVlR6vmWO/lumsA5V8bjn0q0V1zqy4hb1mGrybXwXl7/R5JpLaQ/PPShu5iJVShH+O 212NyhhshKv9Sfl81xDAvwJMawcFIaOJ3XliJboiyzfR9BWP+6qjgsWBLjntUl9O8cjw 7VVfII9zlr7NnZfk2GezxqNmzfNLBiAvcXDLbG/h4jkaU7iESIDKUVJ8euZGESxYEgmd PqKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=TIkzxO1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oo11si956265pjb.9.2021.10.18.13.34.19; Mon, 18 Oct 2021 13:34:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=TIkzxO1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233070AbhJRUec (ORCPT + 99 others); Mon, 18 Oct 2021 16:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbhJRUeb (ORCPT ); Mon, 18 Oct 2021 16:34:31 -0400 Received: from bombadil.infradead.org (unknown [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D981DC06161C; Mon, 18 Oct 2021 13:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OBMvbiCZ3mmK4xvpOD56mvuToBpo4s4ONuPdaMpMXso=; b=TIkzxO1O7vQd0T1PMQ31eP873s pPHNaKNwfjx7mTwD9RmpK0u2Dr52r7UfxNzSSDXj8Ur4f/57iSBP9syn65/BRLw+Qf0YqEROqC1+F /VG4vFcKrZ4lPNCkYzTKj7o2L7DwvWpMe/Cj9lb6MSKQzaI23JMePqdIEZskz+65OByIz865kTj2M S7C7JWy6K7A2w9h6miRNVROzQSV0cHn3nsz/ISMK8rBY/sbh7syYv+06of00RqsVQ7L8TnPZCsvnm bLR1p6dai2RCCksWMX0lknKUYeC/2U9k2JV7oYNMmdKjgqpOgr1yAHVsYweFfh4DDrfwCTLAV00Ez KwZhXR7g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcZIX-00HDlV-C4; Mon, 18 Oct 2021 20:31:53 +0000 Date: Mon, 18 Oct 2021 13:31:53 -0700 From: Luis Chamberlain To: "Martin K. Petersen" , axboe@kernel.dk Cc: jejb@linux.ibm.com, agk@redhat.com, snitzer@redhat.com, colyli@suse.de, kent.overstreet@gmail.com, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, roger.pau@citrix.com, geert@linux-m68k.org, ulf.hansson@linaro.org, tj@kernel.org, hare@suse.de, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes.berg@intel.com, krisman@collabora.com, chris.obbard@collabora.com, thehajime@gmail.com, zhuyifei1999@gmail.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com, miquel.raynal@bootlin.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com, linux-bcache@vger.kernel.org, xen-devel@lists.xenproject.org, linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk() Message-ID: References: <20211015233028.2167651-1-mcgrof@kernel.org> <20211015233028.2167651-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 16, 2021 at 10:51:48PM -0400, Martin K. Petersen wrote: > > Luis, > > > We never checked for errors on add_disk() as this function returned > > void. Now that this is fixed, use the shiny new error handling. > > > > As with the error handling for device_add() we follow the same logic > > and just put the device so that cleanup is done via the > > scsi_disk_release(). > > Acked-by: Martin K. Petersen Thanks, would you like Jens to pick this up and the other scsi/sr patch or are you taking it through your tree? Luis