Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3407149pxb; Mon, 18 Oct 2021 14:43:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmxUaUJCE9ri2dNXK9nyFTI+KqHPW3Ekc55/ghT4LbXnptse+aPCwBgYX2zFRQT9EYrsXr X-Received: by 2002:a17:90a:5b0c:: with SMTP id o12mr1677083pji.11.1634593408314; Mon, 18 Oct 2021 14:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634593408; cv=none; d=google.com; s=arc-20160816; b=v/DN105bOWMPDbb8zBcaJnQsjZVnin5OoqW7bJdNS5i0Orxs+PFIwuDYrarWVyQ42E csaj1nhWV1/7723aa6exYZDEXan4wTCZ1AVOStYP+7sKAtIQPH4vY/gsz0hmaT+zqIbb Zuct/zyPGAarLZggWShVAsT4hZHFQmf5KpEktYSAO0FEbGOhSij7V3sTI/QfQ6ZGkwG/ UR0ZeIyClz4ompIAwxRhg4pkrHR1+MAPMmO81QY7xPmN2Z9z5v5PLMkC0qzauTeQZ7YN ENzVoI+YVHl1KltVCPy6P016WOpOQJHVE1eZECmQKuHt3JdzaZI9aAC+/23OPdmiXToe lunA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xfigqgq3auU+bCIeWSNZA5J9X0KkjzeCETQout6wr6M=; b=mmBZHFyO0uf+/1S92cOi9mMIu+7huEYYSc9f7wzTn04irrjONG0z/G7oOfHa8+XuMh VGA7XCXlk037wtgjFMp5I8YIoeUBbP6A5gtEQTZHET2m6sG0OaJw65gsqIFIAFe6FhQU dXjGX7+CbjqNg1WRnbFU/aDlf1Uu+YbtqwXT8IYUlt7K0J5E/bHJ5FQgjuGHfVKX7cYn cmrtvPlbzQMrfFR88/34o4ZU/6rR26fe++vBTIaAgBqTAGMoO6zydoun0zeu45R73UBe ViHPUH52FfXBrkuOkPYzMyXG1LZyIjR7mDSwHV6wM3BXLylTLrOGuqTQsY6N06fQpNsZ TOLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3yMPr3eZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k14si1085122pji.19.2021.10.18.14.43.11; Mon, 18 Oct 2021 14:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3yMPr3eZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232286AbhJRVoW (ORCPT + 99 others); Mon, 18 Oct 2021 17:44:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45310 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhJRVoV (ORCPT ); Mon, 18 Oct 2021 17:44:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=xfigqgq3auU+bCIeWSNZA5J9X0KkjzeCETQout6wr6M=; b=3yMPr3eZ5OdQtCAuApxpT3neYa NbsSRR7udUU0C4mU8ION2UuSpkoDCNfcVbxTOMj3Gp4mCmnWFkl1l6LoLlS3/TaqnnM5fA3MZ4OlN Agz1QfZFF9IqOzngHqk6/XDmn6npyRGTVKv3BbBdKgq+WgHMRB9utF+O9/mCrvQDCamM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mcaOT-00B0p6-6U; Mon, 18 Oct 2021 23:42:05 +0200 Date: Mon, 18 Oct 2021 23:42:05 +0200 From: Andrew Lunn To: Luo Jie Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH v3 06/13] net: phy: add qca8081 read_status Message-ID: References: <20211018033333.17677-1-luoj@codeaurora.org> <20211018033333.17677-7-luoj@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018033333.17677-7-luoj@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int qca808x_read_status(struct phy_device *phydev) > +{ > + int ret; > + > + ret = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_STAT); > + if (ret < 0) > + return ret; > + > + linkmode_mod_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->lp_advertising, > + ret & MDIO_AN_10GBT_STAT_LP2_5G); > + Could genphy_c45_read_lpa() be used here? Andrew