Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3438296pxb; Mon, 18 Oct 2021 15:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAv/UJ/+ThJu8HcjmxKfSZUpV79GSLmU6y08y/5uWwUhY+pZVj9noeb6x22XSqS0Dlrnki X-Received: by 2002:a05:6a00:140e:b0:444:b077:51ef with SMTP id l14-20020a056a00140e00b00444b07751efmr30589331pfu.61.1634596218319; Mon, 18 Oct 2021 15:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634596218; cv=none; d=google.com; s=arc-20160816; b=HfMFSmhLGHk8j53z5Zo7rcCg9oKFoEua62Wu2XSIW9nmrKMTnd3K5l3NAUJOwU/SkM TN73b8Ds1F7aRU3sDoCk4EVzUaH5oj5L+Ey5/19fHh0pxw70oypgoZ75JtiYhYJJEVat Rz0k5d7Ob6UKr4JpXYWnimD5umzDIlg9g8y0HMn8Lv6r89a20RBM9C0YF349425vlp99 RJW115swt0qMTK4gg+hLu0/Sapm7B8Gh+IaSLic1g5dwjjZwosFMrKn+OGvDG20tDt5f HzcFJtF26R6TVsRu/rt1V15hEU84gYz/g+xT2kGp4Yx3DgoclKRikYP4EV1MCOC0zren p7IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=9zuoZMKbiKNaH3XCwS1R+3sTXVzpWLyuoW871drFzkY=; b=tktA14g5Y+0nrRP7IYUxQB6cSw8cSMcpf/6Fmvgxo5T79bTXDUsDfqV9BeR6/ViSi6 cxEHNVZRyne3iHJFjhjXsoqJbdUcVxxfze5arADH29hCN7nRT/op184P0KaAA0qoGm/l y8fxCRU9x6JNgY439rZcZvQAu67Moo0tQJ7vk5tNF+CoOX773vr0xGIQBnEIqIzlTEAP dV+rFm0vr4q5lG3VxxQiPpkGBIiq6E20XAfnn7pyy7LeStHs0Yfaps7jSpkHq6mxA1TH mc94f8e6B1HHi4iXOYiAiaFlPg1Vs3Q2x3aMfI6e9l/ZclYqzTwtNtgpW22+TWiur+fL W0tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=vgTflpxr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f31si24957950pgf.371.2021.10.18.15.30.05; Mon, 18 Oct 2021 15:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=vgTflpxr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230251AbhJRWbW (ORCPT + 99 others); Mon, 18 Oct 2021 18:31:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbhJRWbU (ORCPT ); Mon, 18 Oct 2021 18:31:20 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C02CC061745 for ; Mon, 18 Oct 2021 15:29:08 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id w19so4868430edd.2 for ; Mon, 18 Oct 2021 15:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9zuoZMKbiKNaH3XCwS1R+3sTXVzpWLyuoW871drFzkY=; b=vgTflpxrKVgoupN0TqS1G+MlxzzTMNQ4cy0i6FsdRsw2JtJSfFg9cyPkIzPXdjnvk4 kYaOvVEPAq9oVlkU64zq8+aOqCBFgzp4uCbGvfWEVhNJ/thHuzmzVwnvx6urAjGprYvs 9DlrONk1sQ8l0KykDCbCmLzAnDQbKpGLYisagMZOb0UdLsB0QhLrkbRsKGTJsYQ7ZC2W NLBrpyFFtv1+gzfIvdKnlshG+Bd/nVSwV9KIIE5NNAkYqKnbNLVP/wN0JpM5L0Z37v7n X01Xy156gkFDRedPZPwhB+D+3KplU494K102kmSLHmrDXIcRPp8GDx3FhFN3o14DY8IN 0wJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9zuoZMKbiKNaH3XCwS1R+3sTXVzpWLyuoW871drFzkY=; b=ZEi+Qf4Wb4nNJIY9qYYizVNv8z2NazS364juojzpi5pg+gbV1dsRp8NwxKfoexlRHE HNCAQTemFAes+ss7hpUi+Ry0/SuYdXzw+D2ynVw1/f4Y/fOMPX5ny9QIeg49lPQOmU1C XH+P+yFNs+3llj1acrYmjOwefFJLz6Q/QggYh2jx/GePr2DGmZPqxIKmtsZD3AEZoJeu FY1Kul1qSUH8D4D3+QtqMg0NuAQ1geVw4z1aeVsdJ6QeSj2Dog0KbN+a72cPosdLhwBP MijFlAY+mjojwyrIr1ned4dUJ9WONgtwmzpmN/e+D36ZV+IfSy+iVepfdrvC48I85Lgt CiCA== X-Gm-Message-State: AOAM530n9lj8sO8M+dFQfDUVXujNf0GdDPR52HH5KPccAVE7ABUOzhjE Jhjqdi56c2nGKvQzpi6wpsH+LtzDWts737x67K7w X-Received: by 2002:a05:6402:5114:: with SMTP id m20mr47737847edd.256.1634596146578; Mon, 18 Oct 2021 15:29:06 -0700 (PDT) MIME-Version: 1.0 References: <20211016072351.237745-1-cuigaosheng1@huawei.com> <20211016072351.237745-2-cuigaosheng1@huawei.com> In-Reply-To: <20211016072351.237745-2-cuigaosheng1@huawei.com> From: Paul Moore Date: Mon, 18 Oct 2021 18:28:55 -0400 Message-ID: Subject: Re: [PATCH -next,v3 1/2] audit: fix possible null-pointer dereference in audit_filter_rules To: Gaosheng Cui Cc: Eric Paris , rgb@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org, wangweiyang2@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 16, 2021 at 3:21 AM Gaosheng Cui wrote: > > Fix possible null-pointer dereference in audit_filter_rules. > > audit_filter_rules() error: we previously assumed 'ctx' could be null > > Fixes: bf361231c295 ("audit: add saddr_fam filter field") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Gaosheng Cui > --- > kernel/auditsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thank you for the patch; I added a stable tag and merged it into audit/stable-5.15, I'll send it up to Linus later this week once it has gone through some additional testing. -- paul moore www.paul-moore.com