Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3439747pxb; Mon, 18 Oct 2021 15:32:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyb0hFfhJU6MFUxseevf40viW2rhV2HaCGiC/7GuqjYDuRmeMY0igbj73lPXyGg73/xendz X-Received: by 2002:a05:6a00:168c:b0:44c:dc5a:7ee0 with SMTP id k12-20020a056a00168c00b0044cdc5a7ee0mr31464652pfc.40.1634596331630; Mon, 18 Oct 2021 15:32:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634596331; cv=none; d=google.com; s=arc-20160816; b=K/GyXpPMjzjNfjuzNhg3HhtNxqSSBFQQy/7JOE/610uUL2TZbjm8noCWle1wD8SyHL /l/pwXAWC5cClqA7MSo2uKLCsEZFe6o0HPTEgUrYKav5l+FztCDvwH7Ie3FgbAcn6P+6 YXzbbl+tCsf/tefg4UI5aXWUMenQYis6VLigkEvIq5wbiCwP8X1ch36uXW18ObB4pJWv tf3pjYA0uc20x+tNNBNcLpngm5VICZFhnpAW0jFEBVwCBIElraHflNkugv+7/YUyn8No P8LbA8n09MZ94hT0I3jfTk0DgA3FUbsf3sIKV/prhq24cDNhvoX2GhyQ3aLX3wz8X4OZ SSSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=WItCIYqsbUPD72nHnvN17yFYFOS1ObilaTg0MnWhimM=; b=TEZxNijqNhcnnzLzf7QGwRnAHdRvdIiUjlLThoyCAmIOVSSBkLT53eKX3ULfaC01+6 tS0++3GIORrn717uh17y79EkjdS9AiFkuzvLkVyHlvf4QQ+kY1ln/vGFi5C+nwddJSVR AvOHqjECXxnfxlzArmKcXW565dXjCTmsH29h+lQar/OSdVYq/hd0r9DUr0pleHoehxX+ lJklOmwaGARxrGe/ILhYVAR1X/hsAaH71ZlT0KRm4T6scesuHwgDQXUWDuJE2a5C8nsk k4cW0v7wzO7HQhh+IprkwB2Jws8SZvLDE2S/egStTVJ8bElzDYNWjhDcWbFFDUh+Blz3 M58A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="dfoc7S8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r13si850640pla.38.2021.10.18.15.31.59; Mon, 18 Oct 2021 15:32:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="dfoc7S8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232815AbhJRWbm (ORCPT + 99 others); Mon, 18 Oct 2021 18:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhJRWbm (ORCPT ); Mon, 18 Oct 2021 18:31:42 -0400 Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BCCEC06161C for ; Mon, 18 Oct 2021 15:29:30 -0700 (PDT) Received: by mail-ua1-x92e.google.com with SMTP id h19so5072526uax.5 for ; Mon, 18 Oct 2021 15:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WItCIYqsbUPD72nHnvN17yFYFOS1ObilaTg0MnWhimM=; b=dfoc7S8/Ww6cb3NZc2WR8BnkW61SdjoUUknDFAqPDsTjN2OGWw5ekLyXgujJ1yiH56 xodp4yJUDU7UjrsrhGXw5UsRD8R646yFugInFb1Y8ANaKFhmod9D4CPiDOX/miZa39Gi BgL9Pxb2c593rdhJAsq/ItBTN3tdvyDE/cpQZmh+55gJZ1ZVumx0Pdkd8DS4fLae+D5v 3PPyB2ykikWT8CgLz+3XUfcR/GMKTdiHkdz39If8nz4Joj6c9nhKSvWqXga1XhdQsqPT Eh+/Bt80zk2VboT+ji0IjxTOU2kTvHu2Sd09C3XXmc9GVYmc4hUziJMnWbuUfn7tIYpn ccuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WItCIYqsbUPD72nHnvN17yFYFOS1ObilaTg0MnWhimM=; b=eDWRq9L7dYRC71bjlyaWOlySM39wkoI7yJTGUrio+NGfjQBVchxrKD0kqZIJVBfCmP l8aTUPFKYkZA5vlYApGZBlr4D1OPTvL2O8jIPFfLu5LMtyAFLfQ/ZdFZpxdK3b54yTeT NO8/6/DQnA5Ag5r6371CyYCVITkhr92k3RsjJKRdY6iE6XCciJ5FD4Zud8dRQLbjSTZp wjCo3Cp8DIsDewOwJ8QABL79FQ9lh5bhFM/D36B+ex5z2lTG1dwmTX8lw4XpnBP01ET+ XN5pZF8qiBTL7kj9iTiDc9sScDaW/ogN/6fk78fMEEd+7/vxSZ8/QbkqeikAxuzCnRs2 cF6w== X-Gm-Message-State: AOAM531jeSnLrvI79kzA/dEtZbGA/O3ZXuCaux4M7vJPn28YYoDztHUD Sq6l3Yt2CVCK1xKoaq9p/LiNDDeiFxJEyywh/P7nzw== X-Received: by 2002:ab0:49ca:: with SMTP id f10mr28590033uad.61.1634596169392; Mon, 18 Oct 2021 15:29:29 -0700 (PDT) MIME-Version: 1.0 References: <1M9_d6wrcu6rdPe1ON0_k0lOxJMyyot3KAb1gdyuwzDPC777XVUWPHoTCEVmcK3fYfgu7sIo3PSaLe9KulUdm4TWVuqlbKyYGxRAjsf_Cpk=@protonmail.ch> <87ee9pa6xw.fsf@disp2133> <878rzw77i3.fsf@disp2133> <20210929173611.fo5traia77o63gpw@example.org> <20210930130640.wudkpmn3cmah2cjz@example.org> <878rz8wwb6.fsf@disp2133> <87v92cvhbf.fsf@disp2133> <87mtnavszx.fsf_-_@disp2133> <87fssytizw.fsf_-_@disp2133> <871r4itfjw.fsf_-_@disp2133> <877dearzfo.fsf_-_@disp2133> In-Reply-To: <877dearzfo.fsf_-_@disp2133> From: Yu Zhao Date: Mon, 18 Oct 2021 16:29:18 -0600 Message-ID: Subject: Re: [PATCH 0/4] ucounts: misc cleanups To: "Eric W. Biederman" Cc: Alexey Gladkov , Rune Kleveland , Jordan Glover , LKML , Linux-MM , "containers\\@lists.linux-foundation.org" , Hillf Danton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 11:55 AM Eric W. Biederman wrote: > > > The following changes are a set of miscellaneous fixes that makes > the ucount code a little bit easier to read. There are all things > that I ran into while helping hunt the crazy reference count > bug. > > I am aiming these at the next merge window and 5.16 rather than bug > fixes to get into the current 5.15. > > Eric W. Biederman (4): > ucounts: In set_cred_ucounts assume new->ucounts is non-NULL > ucounts: Remove unnecessary test for NULL ucount in get_ucounts > ucounts: Add get_ucounts_or_wrap for clarity > ucounts: Use atomic_long_sub_return for clarity > > kernel/cred.c | 5 ++--- > kernel/ucount.c | 20 +++++++++++++------- > 2 files changed, 15 insertions(+), 10 deletions(-) Thanks for the cleanups. Tested the whole series on the latest 5.15-rc6. Tested-by: Yu Zhao