Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3444925pxb; Mon, 18 Oct 2021 15:40:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqtWNQ4elA50/zu3sC19/HxvMg9A2MQp030+Xp1TBFgAE9cd5Zk1BBCfn5cZlYQHWOQ2H2 X-Received: by 2002:a62:804a:0:b0:44c:5bfd:7765 with SMTP id j71-20020a62804a000000b0044c5bfd7765mr31260691pfd.83.1634596826992; Mon, 18 Oct 2021 15:40:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634596826; cv=none; d=google.com; s=arc-20160816; b=JsVf3mdNpfiGc2p5NA8h4Chlr1t0AVZNtKA98yMu2iI9CvVLkTaFUWRvGDZ8mI7sIA 9Za/9nA+225KOrxtWVtFEuXfqUdTftaZmTbPsHffIRy3fxN+LdFyDNTQ3eaLk5Y/amxj 8w3SdE/Wczj3YdGLftmePVKy0rm3X5LuJNTglYeOneJRezD5KCV9W9uNt8TLIehBHHFr UiS8G/L13xyvm+nOklf++k1O99rm851AIjNp5T/TcZCm3QwID93c3zUOFfHdbXYscso3 BeBPe/XEN35bEXDcR6+aTFbNevsnIusQDjQmY191jYcUTWXwjyZI7Rw77ZujVEi+cO8Y UEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=eJDfmyop/V4rvl65JIYoaDp6WS/FqduuNkWdpWg5ihg=; b=bd9jzbI7csTNoRWAzGSYNFj9JGu9GwLRsoKS7HXf44uaR+sA7JbEIKRbLmTjztscio fdWqpiBTJfebg2BZQuHhy7lTRQWlKDfSXdin8pIc/elVzkBFSJVXoJcYODCSPDbpYJZF QCW8WcodvJ64m4xYr/na0eFoCko1qxFgUj08FO1k1nKGN8yGRyCupVavwX26be82aqMy nK0DZ0VaT39LiPPGeu8HpQgH5bJmzYOHUl6DGSnopXSYlyPq5Jgje+ggsN2M4h804uj0 AlN7MtIiFRtgWufVPT8VPm/K9iNl14gnLOiSwrMAzuGcei0kPsyT9D7bi6FGfRaJE12W n6SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=PgO0iBVz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pf8si1508777pjb.84.2021.10.18.15.40.14; Mon, 18 Oct 2021 15:40:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=PgO0iBVz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbhJRWkv (ORCPT + 99 others); Mon, 18 Oct 2021 18:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhJRWkv (ORCPT ); Mon, 18 Oct 2021 18:40:51 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48122C06161C for ; Mon, 18 Oct 2021 15:38:39 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id y30so4281409edi.0 for ; Mon, 18 Oct 2021 15:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eJDfmyop/V4rvl65JIYoaDp6WS/FqduuNkWdpWg5ihg=; b=PgO0iBVzgV2hk1s+hEvbt/eSwhu0I08HyB7L60bLVrL3Pdf4qansEmG8o1q17wMICs aixjwdnWs4xyV8ymGwX0DrJUhv7b2ZXhoRlFbCYPw2/a/xobdtgqCJvgXUAYbvGPjpTq qmd0tidfmy55WhN3S8kNCYXEYNEaDbEmMnPjKD3bqfjCaoBld9BLyo61LTk0aXhqgm9m d0yoFRXWa3tjnGXx0jQFqSnH8Aeca7FCsjWYRM9SDm+xtvh07tvHDH4p8GaYuyjunljt ldEC9rTS8gUg0MfpezZzAbsN18e86VQeNezSQWLpXXjpu7BKwKTwxotVunq8s4/avW0P rSaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eJDfmyop/V4rvl65JIYoaDp6WS/FqduuNkWdpWg5ihg=; b=IyI1/Oy1yMPkiwhjag8e6scgiVKKqfmVZvpJBVm6xL2ZdnhEZIopSqMZKvtRV4Kl51 ewP9mYHJ7md8Dil+Mo+/7ZAfFqutPNHY4Td1gBEjIO+RAw88x1LCYyTwrFaDzre9H3gC wIRgX99GMG97Mh6UjPb5z1V8y1ojEj3udp+WzIWuKfo+DYZh0vCRljCXEYG+L8+QplN3 3+RiDG/rfn8lnFBnioFazYHt5NvENYmnPG0iHV5gWzAZspnuvbt1mZCAhuL5DI3UN64+ 5mMSkh4nVn4xrxD49ytNVhlxcv5/SKE17lqtV9783R6fMh5hKfeMKyqq6VGWbv1INrxj YFsA== X-Gm-Message-State: AOAM533PxWcNwrTN4pM+Na21mkYS/v02iyKc6NOkHZzkD6omxBfANQyQ 7CeQlwFK17Oc6Hnk21uoAManC947mQInmUZLovsE X-Received: by 2002:a05:6402:5114:: with SMTP id m20mr47802673edd.256.1634596717804; Mon, 18 Oct 2021 15:38:37 -0700 (PDT) MIME-Version: 1.0 References: <20211016072351.237745-1-cuigaosheng1@huawei.com> <20211016072351.237745-3-cuigaosheng1@huawei.com> In-Reply-To: <20211016072351.237745-3-cuigaosheng1@huawei.com> From: Paul Moore Date: Mon, 18 Oct 2021 18:38:26 -0400 Message-ID: Subject: Re: [PATCH -next,v3 2/2] audit: return early if the rule has a lower priority To: Gaosheng Cui Cc: Eric Paris , rgb@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org, wangweiyang2@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 16, 2021 at 3:21 AM Gaosheng Cui wrote: > > It is not necessary for audit_filter_rules() functions to check > audit fileds of the rule with a lower priority, and if we did, > there might be some unintended effects, such as the ctx->ppid > may be changed unexpectedly, so return early if the rule has > a lower priority. > > Signed-off-by: Gaosheng Cui > --- > kernel/auditsc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Merged to audit/next, thanks! -- paul moore www.paul-moore.com