Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3469276pxb; Mon, 18 Oct 2021 16:15:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjzFDKDPypyiAXVxkpcglAfjLIuAxCFClh7eA8lW3oOL6C7tvo9BDZeDNY57bxgtRjgD+b X-Received: by 2002:a63:9841:: with SMTP id l1mr16219607pgo.318.1634598917571; Mon, 18 Oct 2021 16:15:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634598917; cv=none; d=google.com; s=arc-20160816; b=eHlvSJB6PMBYHvbXfnHbar4hnffCVnLo4LBJoTENE1Ebx0pJBez190PLLQC0MuMJ8y 7G+XGF0SM/QtQqIIHuPJifNlNrOOPWWyYf7BQSnAtNkrQy9L9DmBEiWjjzwSyZN3uH6C 1UD2s469LQKcaqRWPV6PeZnL//l+t/qJLyIgEPHfEGjtxrX+H6/MwWgv/WMXzcbWDP7H +gQ97daO7HQtN1onrqsndmiRgATr8c481NZSaiGxV+vM0tYwwaCuGxccoR6bLuXwdhMU GDM96XP/FrgtQaSsWmC9ROeluBzC3ILJaPE0K63U4UimFYQlcZKzcD6Tf+qlRjddSogq k0Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date; bh=b8L7FaZPGvbxhQTcqnUilJevH1NDP74rPqwpFPPVzlA=; b=N4ul0mUVT5w8XXxdPw/ARvecN5PVoXp1EEOX41bq3kMtsurAudBIHHc8wgwCJuqdE9 bxXkbkg6SvyLNbHMbMBAzDPF6RDWleGViXpIh79NYZGA9iF+m3qLB78J2zQPT4pkAmQb 0o4Ll66xGR4VX0B4/gHrWzVjYxvvNlznt5+y9sjYVgn34ZSUsEaf5zbeqUkAt1P9/cb2 cma255tAeB5VMcNaVCaVFQ4z4WLxoCIe9Gc4wnPxaUu40KWcVz6nSYcGKAZ0f41bgmbj PN3nGHu70iGJbvyG2n5laOpXChSEC10os0cGUCRn0VUJ4sHhZ68vAGXHoj5gO3IvaPk/ GdCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e24si1134082pjr.129.2021.10.18.16.14.45; Mon, 18 Oct 2021 16:15:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233309AbhJRXPt (ORCPT + 99 others); Mon, 18 Oct 2021 19:15:49 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:39568 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232424AbhJRXPs (ORCPT ); Mon, 18 Oct 2021 19:15:48 -0400 Date: 19 Oct 2021 08:13:35 +0900 X-IronPort-AV: E=Sophos;i="5.85,382,1624287600"; d="scan'208";a="97627693" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 19 Oct 2021 08:13:35 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 5865B400C727; Tue, 19 Oct 2021 08:13:35 +0900 (JST) Message-ID: <875ytusz8g.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Christophe JAILLET Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mikhail_durnev@mentor.com, joe@perches.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ASoC: rsnd: Fix an error handling path in 'rsnd_node_count()' In-Reply-To: <4c0e893cbfa21dc76c1ede0b6f4f8cff42209299.1634586167.git.christophe.jaillet@wanadoo.fr> References: <4c0e893cbfa21dc76c1ede0b6f4f8cff42209299.1634586167.git.christophe.jaillet@wanadoo.fr> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > If we return before the end of the 'for_each_child_of_node()' iterator, the > reference taken on 'np' must be released. > > Add the missing 'of_node_put()' call. > > Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module") > Signed-off-by: Christophe JAILLET > --- Reviewed-by: Kuninori Morimoto Thank you for your help !! Best regards --- Kuninori Morimoto