Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891AbWL1Xwq (ORCPT ); Thu, 28 Dec 2006 18:52:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753900AbWL1Xwq (ORCPT ); Thu, 28 Dec 2006 18:52:46 -0500 Received: from smtp.osdl.org ([65.172.181.25]:43304 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbWL1Xwp (ORCPT ); Thu, 28 Dec 2006 18:52:45 -0500 Date: Thu, 28 Dec 2006 15:51:59 -0800 (PST) From: Linus Torvalds To: Rusty Russell cc: Andi Kleen , Andrew Morton , Ingo Molnar , Neil Brown , lkml - Kernel Mailing List , virtualization Subject: Re: [PATCH] Use correct macros in raid code, not raw asm In-Reply-To: <1167348861.30506.46.camel@localhost.localdomain> Message-ID: References: <1167348861.30506.46.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 19 On Fri, 29 Dec 2006, Rusty Russell wrote: > > This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y. Why doesn't this code use "kernel_fpu_begin()" and "kernel_fpu_end()"? The raid6 code is crap, and slower. It does "fsave/frstor" or movaps or other crud, and the thing is, it shouldn't. It should just do kernel_fpu_begin/end(), which does it all right, and avoids saving any state at all unless it's being used by the user RIGHT NOW. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/