Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211017125022.3100329-1-mudongliangabcd@gmail.com> <20211018104759.t5ib62kqjenjepkv@pengutronix.de>
In-Reply-To: <20211018104759.t5ib62kqjenjepkv@pengutronix.de>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Tue, 19 Oct 2021 09:44:12 +0800
Message-ID: <CAD-N9QVziDjvdSwqADX2hDdepHBeDF7FxzPLfH5UGhGvUxshcg@mail.gmail.com>
Subject: Re: [PATCH] can: xilinx_can: remove redundent netif_napi_del from xcan_remove
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>,
        Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        linux-can@vger.kernel.org,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 18, 2021 at 6:48 PM Marc Kleine-Budde <mkl@pengutronix.de> wrot=
e:
>
> On 17.10.2021 20:50:21, Dongliang Mu wrote:
> > Since netif_napi_del is already done in the free_candev, so we remove
> > this redundent netif_napi_del invocation. In addition, this patch can
> > match the operations in the xcan_probe and xcan_remove functions.
> >
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
> >  drivers/net/can/xilinx_can.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.=
c
> > index 3b883e607d8b..60a3fb369058 100644
> > --- a/drivers/net/can/xilinx_can.c
> > +++ b/drivers/net/can/xilinx_can.c
> > @@ -1848,7 +1848,6 @@ static int xcan_remove(struct platform_device *pd=
ev)
> >
> >       unregister_candev(ndev);
> >       pm_runtime_disable(&pdev->dev);
> > -     netif_napi_del(&priv->napi);
> >       free_candev(ndev);
> >
> >       return 0;
>
> Fixed the following error:
>
> | drivers/net/can/xilinx_can.c: In function =E2=80=98xcan_remove=E2=80=99=
:
> | drivers/net/can/xilinx_can.c:1847:20: error: unused variable =E2=80=98p=
riv=E2=80=99 [-Werror=3Dunused-variable]
> |  1847 |  struct xcan_priv *priv =3D netdev_priv(ndev);
> |       |                    ^~~~

For now, xilinx_can already enables "-Werror" proposed by Linus?

That's my problem. Sorry for that.

>
> regards,
> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |