Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Meng.Li@windriver.com
To:     Roy.Pledge@nxp.com, leoyang.li@nxp.com, ruxandra.radulescu@nxp.com,
        horia.geanta@nxp.com
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, meng.li@windriver.com
Subject: [PATCH v2] soc: fsl: dpio: instead smp_processor_id with raw_smp_processor_id
Date:   Tue, 19 Oct 2021 10:32:41 +0800
Message-Id: <20211019023241.17466-1-Meng.Li@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PAGSCP/Ywe1dY0HfsqJJRBhpSSdV/ZelfSIJcTr9gQti/RqAqBLZVJNYvmyn?=
 =?us-ascii?Q?C6w8NFyN+y7dk3EAJHipaRxg912mRe04/2O3yV9XnGDrW3/s0i5yoa/JAUZk?=
 =?us-ascii?Q?qU2ckQGJqRX0SOZH0kOUBmUq6riTt8r8n5mQHyp0A2aef5HF/qJXcpMCNcRY?=
 =?us-ascii?Q?+XntiBINrMKoaItk6OK0iRTau64upWLZz1KTN4WTZVdyNVVk3Wzo/r5xPhG2?=
 =?us-ascii?Q?U3y73Eb8KlrY/1CQJJmfiXOSrxlwWOnkf4qOA6KF7c9gSXtAtR0SdkuPu2WK?=
 =?us-ascii?Q?ajIuqPT3/yh+/VijelM7/fM1tCjwzFgDNW7lZKD1VAvUZmV43/0SEQIn3IO+?=
 =?us-ascii?Q?pc5m4fz9vE6T6KvKBN0Ns5ZQ7K0wAG5EdeeRaO7ImIWfWcVNe+4Dwxgg7QNT?=
 =?us-ascii?Q?7YdDO+FrpEmwvdYbOPeDXZ9K2276+244x0CtU0nva/edoP8330VAb5AMduzb?=
 =?us-ascii?Q?AH4m65ZWYH2R616YIKBkvNxYXfEXttZUnQfy/lFL8md44hZiGjAVajz03aKE?=
 =?us-ascii?Q?FYKFZilWE8FcB8EjzoEgPFGu1aDCHe0xpv4n+YOzlqUhTBblt5efoGOo+oQv?=
 =?us-ascii?Q?l3WK3UihZQ2rOIuXA2LArQQ7a6Z5vjiv0OF9cSwaD+dmFn5zOZgoOzJ5akJ0?=
 =?us-ascii?Q?1232ny1SB9ZXQN5TuYpCmsuAztKkb/2PJwRLTg3hBxzMkP+xh7ojF2x0IZZB?=
 =?us-ascii?Q?FOHFLokU0aKsl8chL12qTvh5g8fgR24eZyaS0DWp4/vdWCUv/bhw9czIauVx?=
 =?us-ascii?Q?a4172z1ghZ2BnC86DDwMfTXcrWRZGpu1Tw45rXnNvgOrZ+WSCcy+JxIYNHvL?=
 =?us-ascii?Q?KHdW4e19KtGWe7l1LJHcjZWR7KdgpO8NDW4qvhH/RnwtktvOqqiO6c8WaDfG?=
 =?us-ascii?Q?j+Ed+KkxikYIdxSwmf071QUGh6pzMgbGJnl3sb5MInb5dzS9Ca1tC22sonTZ?=
 =?us-ascii?Q?u3F+LPvNUV2WSHWlKZDK+dhS203SlfBP80q1/TORmGrR3pfpZTyMidv1/dB0?=
 =?us-ascii?Q?m86j0gB6GS4I1vm1kbCoJmjWBJaRcAwPTxwy+qkBNxFGWYmSG0R1WgzQXY2O?=
 =?us-ascii?Q?DpaFSFondigrGjbxf91dMKRPQgbfdgBXw0g7CySCyWiBq359Nu2MbleddsfG?=
 =?us-ascii?Q?0GENd/5uztzxu7fy24C/huvP9y+Q4m6exoivFEVQsDV8+S87m3SISB77vudW?=
 =?us-ascii?Q?y+0FbLG0qwM7LrQh8w8sYWplCuYCy972i1O6Ui2+XP4KUkMSweiRxVeSdxAi?=
 =?us-ascii?Q?Rm4N9phzEzCCL2bG5IseuuFunNaLrBHXJBz2zvUHlrBFlZ79EgqZeWunXv55?=
 =?us-ascii?Q?8Gi5NnxxiDjDqN657ZZs5Zdp?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5507326-17aa-43f1-f70a-08d992a8c997
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 02:33:08.5987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OvfVVu6CJ9T8oolwXwTi+ET1+Yk6dtSqR88Sn+pVn77q8mnZ+s4QtNiCZVp8sWU7cjcVTU//PZgjUocWLkuiQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901
X-Proofpoint-GUID: j5dDbfU9ZfirxDKTWg77VGEJKPdQJt17
X-Proofpoint-ORIG-GUID: j5dDbfU9ZfirxDKTWg77VGEJKPdQJt17
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-18_07,2021-10-18_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 priorityscore=1501 adultscore=0 mlxlogscore=615 clxscore=1015 bulkscore=0
 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110190013
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Meng Li <Meng.Li@windriver.com>

When enable debug kernel configs,there will be calltrace as below:

BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
caller is debug_smp_processor_id+0x20/0x30
CPU: 6 PID: 1 Comm: swapper/0 Not tainted 5.10.63-yocto-standard #1
Hardware name: NXP Layerscape LX2160ARDB (DT)
Call trace:
 dump_backtrace+0x0/0x1a0
 show_stack+0x24/0x30
 dump_stack+0xf0/0x13c
 check_preemption_disabled+0x100/0x110
 debug_smp_processor_id+0x20/0x30
 dpaa2_io_query_fq_count+0xdc/0x154
 dpaa2_eth_stop+0x144/0x314
 __dev_close_many+0xdc/0x160
 __dev_change_flags+0xe8/0x220
 dev_change_flags+0x30/0x70
 ic_close_devs+0x50/0x78
 ip_auto_config+0xed0/0xf10
 do_one_initcall+0xac/0x460
 kernel_init_freeable+0x30c/0x378
 kernel_init+0x20/0x128
 ret_from_fork+0x10/0x38

Based on comment in the context, it doesn't matter whether
preemption is disable or not. So, instead smp_processor_id()
with raw_smp_processor_id() to avoid above call trace.

v2:
Remove the preempt_disable/enable() protection, instead smp_processor_id
with raw_smp_processor_id.

Fixes: c89105c9b390 ("staging: fsl-mc: Move DPIO from staging to drivers/soc/fsl")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 drivers/soc/fsl/dpio/dpio-service.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c
index 19f47ea9dab0..3050a534d42c 100644
--- a/drivers/soc/fsl/dpio/dpio-service.c
+++ b/drivers/soc/fsl/dpio/dpio-service.c
@@ -59,7 +59,7 @@ static inline struct dpaa2_io *service_select_by_cpu(struct dpaa2_io *d,
 	 * potentially being migrated away.
 	 */
 	if (cpu < 0)
-		cpu = smp_processor_id();
+		cpu = raw_smp_processor_id();
 
 	/* If a specific cpu was requested, pick it up immediately */
 	return dpio_by_cpu[cpu];
-- 
2.17.1