Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp67990pxb; Mon, 18 Oct 2021 20:50:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxcvtcQt1s3y82dhGWNX78Z9UXXvZouz8OxxxL1BluzUZD5ARVP768rv5QVAT0j0+yws6R X-Received: by 2002:a50:be8a:: with SMTP id b10mr51043257edk.235.1634615409974; Mon, 18 Oct 2021 20:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634615409; cv=none; d=google.com; s=arc-20160816; b=BgiC4GGcJK+v43Z31REPIcDncFSwu9REUZF1TFPyDu/qBqs16PB2lNBBYJ6T1PVo2c RvdFV+yITXWgRgpUvDVCW7b9Lm2xHRl8bBgpQmougMe60S8GxOQ/VfyrciEtWINlln6J j2Ukyxy7s2Mb++I+Q+Yk/VdVIxzARo4c3YauXt3HIMc8HTWvknmSeSgvkiZyou2FQWQt bMiGNIuzj8i/N4d1oGIFlPMnPEz1CQCv1GiL6IzaylcniQElh9Rr1h/+HFt6Hw2AS/S7 53PevHKuZp/4UP0HFjmZSn3S0mIeNrgU1rBqyizCmqHMnjX3ZsR+STgD8bqjdjixXGEN jPSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KJiWubGMNyWOQmJE10qT2Q36ZJt5GUJhKqw9DNxgJQ4=; b=WSZuPO8/+2oanw0E5gGK19mlawbYBdJvMICFQXm6Buz5GQxR3VNho3OjVvWIWNKA8S Eighdj77kQ0YOFf9V8f5/N2EsU4mpesbawm32zFrlN4Ej40dRbFq3Lu8fYMr66gFdp0p XMZDtTxmyNqLUuWL0rwxAcxzLimK/xRZohW2FHmuK4wGiwv/pCj3qMt87J56vsP95Faf V8NNmIIXEOR4GjcTa1rrZLN0FtZPdOCZme72gJd/BUyTg/HZvFKyRcZjdqo6o8VbIWIc dogJPYUzyMYn5aE9UrfX6EIgRSUXZgCwDelN7RT3JNa0E2tvFQRMAjhD8+lDSG6CVZL0 Eilw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=ZB4zg4rd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sc11si20740387ejc.129.2021.10.18.20.49.46; Mon, 18 Oct 2021 20:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=ZB4zg4rd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbhJSDqS (ORCPT + 99 others); Mon, 18 Oct 2021 23:46:18 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:40542 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbhJSDqR (ORCPT ); Mon, 18 Oct 2021 23:46:17 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19J349Re015244; Tue, 19 Oct 2021 03:43:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=KJiWubGMNyWOQmJE10qT2Q36ZJt5GUJhKqw9DNxgJQ4=; b=ZB4zg4rdRs0Vcc+913MwHxrfk5sAq15IHJFAjX9nyws0eep02QnntyJV5phXiBuX1z03 a7I+hsyjPiAUCvHuAt3R+/FR1nITZy4MOHjyeWBH+Is7f7ZfUJvMDkcGGShg0Otl+4KL GMlZ9NCRo2cNyLeO+GpU4T44xEAEiMdBc4pPNjBi4DkP9XSWxM4gxT7qhzlk7JRBfmEk 5BifvxWs+63m9FqRc3de5xhrTL5pTIueC4zEYaiJLP3vCADTW8GyewZ6NRK9cWdt6eC/ SRs8hGvV9iyHDMCHF9ZDrots3VKAjZMVQEUI61FNHo6xISYVn0K4/o8ygViwpRnYy2sQ NA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3brnfhqskj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Oct 2021 03:43:48 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19J3ZT3a077053; Tue, 19 Oct 2021 03:43:47 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3020.oracle.com with ESMTP id 3br8grmmtg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Oct 2021 03:43:47 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 19J3hhHf101685; Tue, 19 Oct 2021 03:43:46 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by userp3020.oracle.com with ESMTP id 3br8grmmrp-4; Tue, 19 Oct 2021 03:43:46 +0000 From: "Martin K. Petersen" To: Martin Kepplinger , Miles Chen , Matthias Brugger , Bart Van Assche , "James E . J . Bottomley" Cc: "Martin K . Petersen" , linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com, Stanley Chu , linux-mediatek@lists.infradead.org Subject: Re: [PATCH] scsi: sd: fix crashes in sd_resume_runtime Date: Mon, 18 Oct 2021 23:43:40 -0400 Message-Id: <163461411521.13664.305092538440750987.b4-ty@oracle.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211015074654.19615-1-miles.chen@mediatek.com> References: <20211015074654.19615-1-miles.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: gKb9G-3VbOOMGIm4I_ziIPWhbKimffoM X-Proofpoint-GUID: gKb9G-3VbOOMGIm4I_ziIPWhbKimffoM Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Oct 2021 15:46:54 +0800, Miles Chen wrote: > After merging commit ed4246d37f3b ("scsi: sd: REQUEST SENSE for > BLIST_IGN_MEDIA_CHANGE devices in runtime_resume()"), I hit the > following crash on my device. > > static int sd_resume_runtime(struct device *dev) > { > struct scsi_disk *sdkp = dev_get_drvdata(dev); > struct scsi_device *sdp = sdkp->device; // sdkp == NULL and crash > > [...] Applied to 5.15/scsi-fixes, thanks! [1/1] scsi: sd: fix crashes in sd_resume_runtime https://git.kernel.org/mkp/scsi/c/85374b639229 -- Martin K. Petersen Oracle Linux Engineering