Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210923130814.140814-1-cgxu519@mykernel.net> <20210923130814.140814-10-cgxu519@mykernel.net>
In-Reply-To: <20210923130814.140814-10-cgxu519@mykernel.net>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Tue, 19 Oct 2021 10:15:28 +0300
Message-ID: <CAOQ4uxj4no4zHaOKSXyefUpP+JuMsjeuMPzpZ8BAm1xrs2h+Aw@mail.gmail.com>
Subject: Re: [RFC PATCH v5 09/10] fs: introduce new helper sync_fs_and_blockdev()
To:     Chengguang Xu <cgxu519@mykernel.net>
Cc:     Miklos Szeredi <miklos@szeredi.hu>, Jan Kara <jack@suse.cz>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        overlayfs <linux-unionfs@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 23, 2021 at 4:08 PM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> Overlayfs needs to call upper layer's ->sync_fs
> and __sync_blockdev() to sync metadata during syncfs(2).
>
> Currently, __sync_blockdev() does not export to module
> so introduce new helper sync_fs_and_blockdev() to wrap
> those operations.

Heads up: looks like __sync_blockdev() will be gone soon,
but you will have other exported symbols that overlayfs can use

https://lore.kernel.org/linux-fsdevel/20211019062530.2174626-1-hch@lst.de/T/

Thanks,
Amir.