Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [syzbot] divide error in genelink_tx_fixup
To:     syzbot <syzbot+a6ec4dd9d38cb9261a77@syzkaller.appspotmail.com>,
        davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
References: <000000000000809ecc05cea5165d@google.com>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <535d2ad0-1667-403a-9771-ad9c7b9748a8@suse.com>
Date:   Tue, 19 Oct 2021 10:30:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <000000000000809ecc05cea5165d@google.com>
Content-Type: multipart/mixed;
 boundary="------------A85C016ADBAF231019FF2A12"
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MW9jQ2ZVN2g4Nm9NL2t6dS9GMG12RVpaZTBIaXJTYjYrMVY3ZnNTQTA3UUg4?=
 =?utf-8?B?dmRqdWpFMmhnaW1JakkxQjFDSlh4S1lPTXpuK2tVUDNJRVFDSUhvVmlmZS8w?=
 =?utf-8?B?NTRzU0tGbzRwVldkNzFjazNzeDVHRjE4enJjenp0R1lyaDgwZGlMMDdDMmRU?=
 =?utf-8?B?S0lrUEhPUVYvTlBLVGsvc0JibzZ1Nzc5cHIyckFSOFhZcFBMUjlBZC9Rd2h5?=
 =?utf-8?B?U1RneHlYWnV0SkpscjN2eVJMVVF4OC9nbkxycTdTaDUvOTFFWHhqak9LemdY?=
 =?utf-8?B?cnhRSHN4VkZIb2NNdjdJVFZEekttT3kwWXlmZGI4b05NQ1JEU3RUcHpiT0Jl?=
 =?utf-8?B?YVR3eXdJdlM1SHdqQ2xDY0J5R2htcmdMZlZlSk5LZGxTb0dVNWZZWW9MYTVw?=
 =?utf-8?B?VVFSTTY5eGxURUJHY3duV2xzSnAweE1UN1pZRHJXYTNlc202ZCtaV1RkQnda?=
 =?utf-8?B?TzZwN1M5UVJ1YjFOdUJ6YXpCUDlubnBCYnd1M2RGV3hBeUc4bWc4MU9pVzBX?=
 =?utf-8?B?bk5ZL2wrby9VLzdXRnNmS0RtSmhTQXVNVE9uc2c3WnBaYzZmN09jNHFBSTV1?=
 =?utf-8?B?WWlaSVZaTU4vQXRGazlpRGt3TUw2dkcxQmpzNGkrc1F4bWRuZHRmWjdUV1U3?=
 =?utf-8?B?NnRQeVJ5QVRtUmVFSnA4M3dJcUtZOENwTElaS29weTVXakVBYW9oRTdxRlBY?=
 =?utf-8?B?Q1Y5K3JYRU0yaFp1S1VmZjlwblhQS0dMWXVabVBTK3FoWVhSbUY0SExjc0tJ?=
 =?utf-8?B?Ly90aDBCemJyT2VCK0VtOVhPSUtJbnAySTJYbktSTUVUTlBYa1Y1OVdDRktN?=
 =?utf-8?B?TGR5L0l4emxIUE43M0dyRGVjQkJBRzFlQSs4amJ6NTJDR0FrRFJhazZNN3Zp?=
 =?utf-8?B?dWxEK0RuSEgrM3pmcTBGUjRzMjVKc2EybTRZRzVwTitsY2t5NXRhNzcvSURM?=
 =?utf-8?B?c0M0OHdZd3ZaR2ZJa09Tc29oTm11SmNRWHJNTDgzbkc3WFhZOHNNTW5JOUxk?=
 =?utf-8?B?UWJBSGJYVWsyTTNHendVMnprdFVHeTFvdzZ5VUJmV21UcFdDaTcvT1J4SnRG?=
 =?utf-8?B?NTFVOVJBNDZKSG13Sm9xK20rUUFTUVFXU3gzbHF2dEVRSHNxeDBDeVFMZEUv?=
 =?utf-8?B?QTZJUE5aUnAwL0ltMzNHc1FDNHpHMmZTRXEycWtVSUw1cFhlZHNma3FUeFhm?=
 =?utf-8?B?eFNuWkE1L1JTNU1kMmYzaDFhWlozUGFKZ0MzdndpVUhwVlFaUGd6bnM3VVJC?=
 =?utf-8?B?N3dWb1hxY0YvK20zNU9lSlFXUG5jN3BQa2FtY2t0TE1qY0lYUXpaT0dwdW04?=
 =?utf-8?B?dFFyc0FnTG1zcWNwR2RtVEdKa0RadWtOU2cvZEUyWExYMVpKd3lzYWI0akph?=
 =?utf-8?B?T1ViOUtWQmNVVW5Vb3pKVE9rd041bUlnMHQ3L09hdEMvcHlaenE4T1NIODNE?=
 =?utf-8?B?Vk9FZ1hNOVdOUEtVWU0xWmgxNDJZa1dKWmR5N2VVd3Q0UE95eFlaOG5sbUtp?=
 =?utf-8?B?RS90Z0RnZU1ieFhtbkZYVzJSaFhIa3NZK0srT010ajhOTGlQSnF6Q2k2bDF6?=
 =?utf-8?B?VzVxTW91dU1WTVpqOG1kZmF2S0hDQVlyaWJmV0tpOXZrNms5UmxsdmFtVFVB?=
 =?utf-8?B?R2w3NncxT1ovNmgwV1NyR3ltb0NpTlltaUIveGphQ1prVWxVdFZIZUl2YXJh?=
 =?utf-8?B?cHJhQmN1aWRqa2wwLytOOFdoc25iTWxXUnlkcTJObnBxSDk2aEtTdFJGUDhh?=
 =?utf-8?B?TzByQ2o0TFlxUis5OEZNWjhoTG8wdjhoVHJLWjIxRlRqdmRIR0RZWjFXektl?=
 =?utf-8?B?b3pzS3FtZkpaWUhJdFVsZysrL2diemg4TUt2WUdjdDU3OWtZbGFPeEZiNmhB?=
 =?utf-8?Q?LcJ0rOE3khaLr?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 999575bb-2f73-4c5c-b3b8-08d992dac5bb
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 08:30:56.9123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: abbRp0yeCwVS7dVhccMbvDi7pvvWhpsfQr7XQeD/s4oo7j3MHcZ3yRu4eqQ0GA5k0z6LQGmQz8SUEJEMIZDO+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2598
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--------------A85C016ADBAF231019FF2A12
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


On 18.10.21 20:55, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:    660a92a59b9e usb: xhci: Enable runtime-pm by default on AM..
> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> console output: https://syzkaller.appspot.com/x/log.txt?x=1506ccf0b00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=5016916cdc0a4a84
> dashboard link: https://syzkaller.appspot.com/bug?extid=a6ec4dd9d38cb9261a77
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11308734b00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12f56f68b00000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+a6ec4dd9d38cb9261a77@syzkaller.appspotmail.com

#syz test:https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git c03fb16bafdf


--------------A85C016ADBAF231019FF2A12
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-usbnet-sanity-check-for-maxpacket.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-usbnet-sanity-check-for-maxpacket.patch"

From a5270791d4480e9a6bc009c69a4454039aa160e7 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Tue, 19 Oct 2021 10:02:42 +0200
Subject: [PATCH] usbnet: sanity check for maxpacket

We cannot leave maxpacket at 0 because we divide by it.
Devices that give us a 0 there are unlikely to work, but let's
assume a 1, so we don't oops and a least try to operate.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
---
 drivers/net/usb/usbnet.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 840c1c2ab16a..2bdc3e0c1579 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1788,6 +1788,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 	if (!dev->rx_urb_size)
 		dev->rx_urb_size = dev->hard_mtu;
 	dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
+	if (dev->maxpacket == 0)
+		/* that is a strange device */
+		dev->maxpacket = 1;
 
 	/* let userspace know we have a random address */
 	if (ether_addr_equal(net->dev_addr, node_id))
-- 
2.26.2


--------------A85C016ADBAF231019FF2A12--