Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oliver Neukum <oneukum@suse.com>
Subject: Re: [syzbot] divide error in genelink_tx_fixup
To:     syzbot <syzbot+a6ec4dd9d38cb9261a77@syzkaller.appspotmail.com>,
        davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
References: <000000000000809ecc05cea5165d@google.com>
Message-ID: <649fd15d-4e23-f283-3a58-f294d59305c7@suse.com>
Date:   Tue, 19 Oct 2021 10:40:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <000000000000809ecc05cea5165d@google.com>
Content-Type: multipart/mixed;
 boundary="------------FA2C7BB85455DE572841162A"
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlRmU3ZucmNDTFJjMk5jVFpmMWI1NDVzY0NYT1BZbzE5SEczLysrNlp5WXlo?=
 =?utf-8?B?bTZ6UkhTdkZ6dFN6ZElNa3B0SThkSitLMTJTMDQ5RzNXdlRVL2FlZWM4UkdW?=
 =?utf-8?B?dDlaRkJDWHpmRnZrSUUvNStOdEJYaEsva2sxOVBFV2VackU5WnlTOFY4a3d2?=
 =?utf-8?B?Y0ZiU3o5cmpBS0xOM1d2Q3hyaHpNUi96cHNVaDRsTjFIU0JkT1dHOTZhdTFv?=
 =?utf-8?B?OEY4ckZhcThaWTlXSEdmdU52T3hQZURoL3d6eW04WWd1dmJTNTRMeldtTk5J?=
 =?utf-8?B?RllRT0QwMGgxMzhZdkNBemVSeXp3S205OWJ3UC9RZ1oxQ2xLWlZpOVZFY2ZF?=
 =?utf-8?B?NG91YlpEV0VlRDU0VTF0aUliSWh1cnA4dmxCVndFWjhkdjhOdWs1UkVDSnRK?=
 =?utf-8?B?QVRBN0lmdWhWVTN1WUl0V0FQOGdvMUh6a0JqaW5TVHNkd0tIRUV1TkVqL3Mx?=
 =?utf-8?B?WlpQVGpjbXRoaVdIbkc3dUpzSE11ek94ZWpNcVZWNWNJSGRTRDlZNVdqN3RL?=
 =?utf-8?B?SDh1M2sxUFllR05FT0tWalZQQU8yUnBuWUFVakdPK1JBQ1lnSlB6cFNFQ0Ir?=
 =?utf-8?B?VHBOYXRqTGgxNTZsYmlMWm5NRTYyTGdWZHJ1enlINzlZQmJmdHM3UEpQVEx6?=
 =?utf-8?B?OFRNa0F1ZktvWTNCSjBHM01yODBLM3ZTd0xpaUQ4MUxQcWhmM1c5aURHd29m?=
 =?utf-8?B?K1kyUkh2aGFiRzJocDAxdXJQYVRhdVpEaGpDM2dFUjZFSEltZFR6SVNVK05m?=
 =?utf-8?B?TUdGTjNEYXk0cGNzKzljd2pTQ2JMU0lVWE9HcnA4dk1SQ2Y4NHNTYWRrMGRn?=
 =?utf-8?B?VExpMnJEVml5QjF4ZHV0MGlWdkpzMEhLOGpQb0p4ajY5N1lSaERqR0svOFMr?=
 =?utf-8?B?bFpZVTBiM1hibVhZY29LOHdzdk1CdU9vWTl2V2Y5ODlLSk9BcGVDYm9razd4?=
 =?utf-8?B?Wm1idVBYSVNmcmFMUU1nZXoza0swMjhyUGZoWXNrSnFNVlpnVnZCZGFURjli?=
 =?utf-8?B?NUlXc0YvUEp6TWhUeTdkQzdheFlhNFpaWDBsRCt3MkJrMmwzSFBZWHVEZWI2?=
 =?utf-8?B?Ny9Da0VTUDM1VlArb1JaSVJQYUYvVE91c2xFOFdWZ3dra1I0amhzbUZobEpM?=
 =?utf-8?B?TmpwWTNZbFB5OE5RaGxvc3hIYVhaam15aDBUeTJoWlZGbXByeVFsV1hOTzFZ?=
 =?utf-8?B?R0NqMmRLZ2R1eHJVbFIxeEpzZjJJS1FSRUVRUkVGSHE4NXJJZTdSR0dvOXVp?=
 =?utf-8?B?Zm84eFk1ck9EeEpNeFd2MmgxK0VOSS9VbGlpaFN6VHBYbTFFK0Y2UEx1RWxk?=
 =?utf-8?B?K204VWlVUUlrdkJ4UDNPak41anZ2b240MnBNbnpXTzZjWTFOSGhVV25jNDRP?=
 =?utf-8?B?RnArcXJYZHZ4Q3V5cGtJcDUybVc0eDdGUWRETjdKWHJqZUZNN1d1NGdZZ3hl?=
 =?utf-8?B?cy9XVmdNbUZNZ1cxeXVENjZNemJjamdTSlFja1B4WFVyWmREMXlmNjZjQjJ4?=
 =?utf-8?B?Q2tia2k4Q3gzeVRubEN5enRKV1BtdXhzNVZqWE85UDFZbzZPcWhuUW05RXd3?=
 =?utf-8?B?eW1wWStmaUZKNE5tTGI2MHQzeUxIMmxYanBJWWRWcWpkUUNVZDJDaDBtM3Vl?=
 =?utf-8?B?ZWFYTnduN0FsTVZ4TVJscFVLSHU3ZitMVmFycy8vcnloOHNXdVBxNWkvcjZI?=
 =?utf-8?B?WC82REYvZW16RUpuUUYrNWtiUGJwdzNLLy9lTzVEU29YN3NUZnN3bUVZYi9w?=
 =?utf-8?B?RTVwN0hQbmFoVW9XUkpvSTlnMzZlWVM4YmtiMVU2ejBJUlJyMGN6ZjhBa0VN?=
 =?utf-8?B?b3hvcktQeEVhYzJLR3VPU1dRK3dpVVV4OTZ5dE9VRUJjMHJPK0Z0bE01Wk5j?=
 =?utf-8?Q?n4+6v6tVQplnn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 598cf07d-6c25-4808-e173-08d992dc2aaa
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 08:40:55.7067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BwVOqtp6DBZnWt+8G+8ytaUoA+8Ch31WzGs9pZwuzM/qEgPLo1VV7I50sYTqWh8LiUqgvT5GNkNhE2ETjcxY9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2293
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--------------FA2C7BB85455DE572841162A
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit


On 18.10.21 20:55, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:    660a92a59b9e usb: xhci: Enable runtime-pm by default on AM..
> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> console output: https://syzkaller.appspot.com/x/log.txt?x=1506ccf0b00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=5016916cdc0a4a84
> dashboard link: https://syzkaller.appspot.com/bug?extid=a6ec4dd9d38cb9261a77
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11308734b00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12f56f68b00000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+a6ec4dd9d38cb9261a77@syzkaller.appspotmail.com

#syz test   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git c03fb16bafdf


--------------FA2C7BB85455DE572841162A
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-usbnet-sanity-check-for-maxpacket.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-usbnet-sanity-check-for-maxpacket.patch"

From a5270791d4480e9a6bc009c69a4454039aa160e7 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Tue, 19 Oct 2021 10:02:42 +0200
Subject: [PATCH] usbnet: sanity check for maxpacket

We cannot leave maxpacket at 0 because we divide by it.
Devices that give us a 0 there are unlikely to work, but let's
assume a 1, so we don't oops and a least try to operate.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
---
 drivers/net/usb/usbnet.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 840c1c2ab16a..2bdc3e0c1579 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1788,6 +1788,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 	if (!dev->rx_urb_size)
 		dev->rx_urb_size = dev->hard_mtu;
 	dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
+	if (dev->maxpacket == 0)
+		/* that is a strange device */
+		dev->maxpacket = 1;
 
 	/* let userspace know we have a random address */
 	if (ether_addr_equal(net->dev_addr, node_id))
-- 
2.26.2


--------------FA2C7BB85455DE572841162A--