Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp252173pxb; Tue, 19 Oct 2021 02:04:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGHrBcjAACSyGa+PC+itpakxuTyqEGm9+AmY0TjEeCVKfEWiiuy6d/gki7I6ZVp/7aeHF0 X-Received: by 2002:a63:4c5c:: with SMTP id m28mr27681344pgl.67.1634634262342; Tue, 19 Oct 2021 02:04:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634634262; cv=none; d=google.com; s=arc-20160816; b=PUwqio8EoEyOEhfqMg8xy+7tY+tZH60ZXt39oPP75FNUIEV2EN2LzwQfRo7lvXuXUo zT3/zX2iVSedLwjXWaa9CbE3wQZqW3nxzE+B05NDn24W6AHY8OMSIpdbu9iWlWgo2pDU 1QZR9A0vvCGrs92EelaDEq8d0weditcdijymffP25SodONrceaCVImgQ6DduRgYl7azu efJgp93rSX/+/fRd21f8/NVAY+iRU+L/gj0KtbF+I6G0hUm3j5t/gi7ofOs0rGvurN/W Rq+XUvEIQMoajcPxoy0XmbviIQJ7McGk64VWtRK3kQ3i6SAI5knkJ8abVnO6ODghyWsN 9iLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HpiJk6DxzbC1o+VZA0pwju2L2kvMCw3qK1VwL6TgAQk=; b=F61luRtYeupkM+LBRTK+cm6162gjeJwW0KaHLojNpFTeuuHyrMGYBJ+3BGHfZZwLM7 3Byk220O4hxL4LShjcpVBgzB/oG8Cnv2U9FKIMYxa3P2hrewC6QbbhfbNoU6Q2aof3PJ Bt9WFGtkmLxWLOO+1oyty4nZHpgV76jdkYABESATZzR+nHLXIGudTeUM0Y5wmdnMvSYx 55+AFNeMqoyWK1QlDqxifkZjNA9Vji0Ylo09th5HMaqMCYuNizTBxxnKg345be9pnKJd oBpIGSBeOXFem4+wAZ6M2BqbvOfan9WS7z4gqmvwgpsYoBoe3Be5bCPltFKIySDHaCcV TTew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a20si4932575pfv.198.2021.10.19.02.04.05; Tue, 19 Oct 2021 02:04:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234955AbhJSJE0 (ORCPT + 99 others); Tue, 19 Oct 2021 05:04:26 -0400 Received: from outbound-smtp62.blacknight.com ([46.22.136.251]:35493 "EHLO outbound-smtp62.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234961AbhJSJEY (ORCPT ); Tue, 19 Oct 2021 05:04:24 -0400 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp62.blacknight.com (Postfix) with ESMTPS id 3949BFBEEF for ; Tue, 19 Oct 2021 10:02:10 +0100 (IST) Received: (qmail 8615 invoked from network); 19 Oct 2021 09:02:10 -0000 Received: from unknown (HELO stampy.112glenside.lan) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPA; 19 Oct 2021 09:02:09 -0000 From: Mel Gorman To: Andrew Morton Cc: NeilBrown , Theodore Ts'o , Andreas Dilger , "Darrick J . Wong" , Matthew Wilcox , Michal Hocko , Dave Chinner , Rik van Riel , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Linux-MM , Linux-fsdevel , LKML , Mel Gorman Subject: [PATCH 5/8] mm/page_alloc: Remove the throttling logic from the page allocator Date: Tue, 19 Oct 2021 10:01:05 +0100 Message-Id: <20211019090108.25501-6-mgorman@techsingularity.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211019090108.25501-1-mgorman@techsingularity.net> References: <20211019090108.25501-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The page allocator stalls based on the number of pages that are waiting for writeback to start but this should now be redundant. shrink_inactive_list() will wake flusher threads if the LRU tail are unqueued dirty pages so the flusher should be active. If it fails to make progress due to pages under writeback not being completed quickly then it should stall on VMSCAN_THROTTLE_WRITEBACK. Signed-off-by: Mel Gorman --- mm/page_alloc.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 78e538067651..8fa0109ff417 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4795,30 +4795,11 @@ should_reclaim_retry(gfp_t gfp_mask, unsigned order, trace_reclaim_retry_zone(z, order, reclaimable, available, min_wmark, *no_progress_loops, wmark); if (wmark) { - /* - * If we didn't make any progress and have a lot of - * dirty + writeback pages then we should wait for - * an IO to complete to slow down the reclaim and - * prevent from pre mature OOM - */ - if (!did_some_progress) { - unsigned long write_pending; - - write_pending = zone_page_state_snapshot(zone, - NR_ZONE_WRITE_PENDING); - - if (2 * write_pending > reclaimable) { - congestion_wait(BLK_RW_ASYNC, HZ/10); - return true; - } - } - ret = true; - goto out; + break; } } -out: /* * Memory allocation/reclaim might be called from a WQ context and the * current implementation of the WQ concurrency control doesn't -- 2.31.1