Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Oct 2021 11:14:02 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
cc:     linux-input@vger.kernel.org, Ash Logan <ash@heyquark.com>,
        =?ISO-8859-15?Q?Jonathan_Neusch=E4fer?= <j.ne@posteo.net>,
        =?ISO-8859-2?Q?Barnab=E1s_P=F5cze?= <pobrn@protonmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org,
        "Daniel J. Ogorchock" <djogorchock@gmail.com>
Subject: Re: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U
 gamepad
In-Reply-To: <20210921150837.ingexwsauvxgluca@luna>
Message-ID: <nycvar.YFH.7.76.2110191112490.12554@cbobk.fhfr.pm>
References: <20210502232836.26134-1-linkmauve@linkmauve.fr> <20210519085924.1636-1-linkmauve@linkmauve.fr> <20210921150837.ingexwsauvxgluca@luna>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, 21 Sep 2021, Emmanuel Gil Peyrot wrote:

> > This driver is for the DRC (wireless gamepad) when plugged to the DRH of
> > the Wii U, a chip exposing it as a USB device.
> 
> Hi, I’d like to request a review on this series.  I’ve been using it
> with success for quite some months, and from a self-review after not
> having touched it for as long it still looks correct. :)
> 
> Thanks!

[ CCing Daniel ]

Thanks for the patch, and sorry for the delay in the review.

The code looks good to me, the only question/request I'd have is -- would 
it be possible to adhere to the driver naming standards, and actually 
incorporate the support to existing hid-nintendo driver? Or is there any 
substantial reason which I don't see why this wouldn't be a good idea?

Thanks,

-- 
Jiri Kosina
SUSE Labs