Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp263745pxb; Tue, 19 Oct 2021 02:19:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPh7bZCxmRsBwDlxORxcYM5QuKfsoLIpTZzRy5Cu041yYUKqIhfKjwT+1tUf038cDByI2h X-Received: by 2002:a17:907:784b:: with SMTP id lb11mr36008734ejc.307.1634635191516; Tue, 19 Oct 2021 02:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634635191; cv=none; d=google.com; s=arc-20160816; b=0VvneP1FoVXZVJCnNnyyd6WP9LGYKIi0DsGLMLgYJkDBQ/jjuVzr04CiQ37StZG4vo B6zPPKfY7q7tfONih+74ULVGl/foUGUNAFRw60VSfqo+qCtDN7nmnvPKVj5Qd3eP4yat YsFFl1NHx7NVWNbja7ikpNcraNb1+fbfei0DjspsgU791rbBxL5K5/q0BpV3sONiKhuo Y5K3FOw2VDhd7AbwsdPIbyTtcC9FaWIgpfVh3K8MmSZLPDI2BS/P/pxme4EOe6mbs9iH deHNbU+uUbTDvQcOE7B2jNC7wFpZqrjsYxzof4UGZn2Wz4n5POMx0l/hyjKbp8UZ/w3l SyOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=WIoDFGTR1tUN8iq8N6UKnEIdiudG6n3C/20gEXgSfdM=; b=a2mkxwTaCnublKTaMLD9VJgP2W240msvP/XR6Nv4F+9ydgLldXkUwhChrlYFZdEGtT moFPI/BuMLkSU8isBXr2mTYv5qNDcIy2KsplEOMvUhJh/+gocZ7XfouMqyYHQQ5n56Pl Q7evtdDS7abd0fVTlA+8e7Oj+3/R2HXtYHoGHmg4hRG3hl2wVRXNHskCj5oL/ayZHLzU 4mrK6f8obYW6q3TJYyJ1QP7X2e/+PrZzU79Vsz7t66YmVSsKEx/u15BgfxC2Zl6KAwVk 0J/HrijPN2v5CnQQFeZu/PNtCBgNJPDwk73s4bRSlpx8Wl/h2XwQfHbU3YhzeVag0vhx FIBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ud50Yy8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m29si26368158edb.44.2021.10.19.02.19.25; Tue, 19 Oct 2021 02:19:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ud50Yy8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234969AbhJSJTx (ORCPT + 99 others); Tue, 19 Oct 2021 05:19:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:60704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbhJSJTx (ORCPT ); Tue, 19 Oct 2021 05:19:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE6B86115A; Tue, 19 Oct 2021 09:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634635060; bh=9+ooGHjkwtByMB5Ja9m1czBL6YEiNK/4UYkm9XccbCg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ud50Yy8Zy/2WW9+vZ6arLcvnnCfO8iQ6LkgxfBgsBSSe86J/SYkeFPOeWPpK0wvoY 4HvHzASNkLxoTVXtGixFYNXOHAGDfEUPW7EQpWgs6vIRHR7M5sY81AiooBv4BQkdvS nt/6/BOoJYDTvpCt4PiVG4ZLIqRxMi13dMChGmdOt/XcJpND3au2hqumIMlcZUj3tv JxEjd8s9fdR+7Hja8LDl4y5zZaiR+jsevGWguLs4IGvqjEZTHqVeVCHxzMF+boJ6Yk voDL7HhxuYSb3xI/o8KykaF3m9s8RSWQdtzZog31Rt9pNdcwDyelVp8dhi8yrOkWFH A2lnTkJUe8xdA== Date: Tue, 19 Oct 2021 11:17:37 +0200 (CEST) From: Jiri Kosina To: =?ISO-8859-15?Q?Vin=EDcius_Angiolucci_Reis?= cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, angiolucci@gmail.com Subject: Re: [PATCH] HID: hid-asus.c: Maps key 0x35 (display off) to KEY_SCREENLOCK In-Reply-To: <20211008222327.9324-1-angiolucci@gmail.com> Message-ID: References: <20211008222327.9324-1-angiolucci@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Oct 2021, Vinícius Angiolucci Reis wrote: > On Windows systems, ASUS laptops uses the "turn display off" key > (usually fn+f6) to turn both display and keyboard backlit off. On Linux > systems, this key has no effect at all since most desktop enviroments > don't deal with KEY_DISPLAY_OFF. By mapping it to KEY_SCREENLOCK > instead, would enable desktop environments to handle this key as a > screen lock intent from the user, out of the box. > > Signed-off-by: Vinícius Angiolucci Reis Applied, thanks. -- Jiri Kosina SUSE Labs