Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp272280pxb; Tue, 19 Oct 2021 02:33:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCjaKQYxuQASquB2HCTttLJUbFyVj9bMeLkRSvZ61RR8Gd2ZgiAZWN+8KZLACF6w8/Cfz+ X-Received: by 2002:a17:90b:1646:: with SMTP id il6mr5133970pjb.129.1634635985390; Tue, 19 Oct 2021 02:33:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634635985; cv=none; d=google.com; s=arc-20160816; b=u1uhhWHnMYB9/0lpD2J/ccxDgJwtsgm6arQMdkar1yJdIveW2Cw1ztrNPNz6Mf6m5H KxjTIBZdZKlxK0WSasCLCBBSIVt7V44lPxRxe2uSxxPIl/88zgvwv7WkkELtuQnPe6ZH Is+j7zrRwu/UwLxZ0d84URjTCRcbq/+ghIz5Aj4YXGQ0B3nNUgLUlIZDrYzGRwfSvjEz YSJDU9WAlj6+0M+QSbl+lFJOs4CIjAmaDjDTKJB76vCDU4L0pHl2Z7bYZE4QRHf8Kdx8 kjuNMJFxjQn0onFfknfiAOIdke/G/NI/xi3SBHx25Wga2EA8PK4eC7UKmizqVlyQgZ4O IwqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=BvN5MqXfItStN33Qnl7exwCRxV/M8dne5uyvUmwQTdM=; b=Thl1adWTDRvrqyTnniBqNsQqYiVI4aG5w40W+oVZ7JkdjOT8SOr/cqVsULOZKl7jbg LXssM7TzQYA5qLxOCKlc7rO/9Upbd82JTPHtaGBoxqR12qEZbpZESFymTRazduz4zGVm 89qaiTJGi3wTzM/06XjVsajKIktlDGOjTOH+Sy930SHIPkaa8wd2vzwE7HyJ+SHADLcY sqQ+iqnt2Y6OYuahL//e30rmslCFpmd8MwjMHvK5vJKdjnxueNSocT7jKAu57r/MOZVd yjf34gXpa0zx578OiSeMXusiQSHdMGGRNYltojkRIY/cxP+Bc6zGYyFomhJuqAvlsF/j sWNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b2si2827694pjl.24.2021.10.19.02.32.53; Tue, 19 Oct 2021 02:33:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234843AbhJSJeG (ORCPT + 99 others); Tue, 19 Oct 2021 05:34:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbhJSJeF (ORCPT ); Tue, 19 Oct 2021 05:34:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05AB5C06161C for ; Tue, 19 Oct 2021 02:31:53 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mclTH-0005zA-7A; Tue, 19 Oct 2021 11:31:47 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-6267-dd6f-bd00-49b6.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:6267:dd6f:bd00:49b6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 49884697F8B; Tue, 19 Oct 2021 09:31:44 +0000 (UTC) Date: Tue, 19 Oct 2021 11:31:43 +0200 From: Marc Kleine-Budde To: Cai Huoqing Cc: Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: mscan: mpc5xxx_can: Make use of the helper function dev_err_probe() Message-ID: <20211019093143.2cmc4ft755fu2ou5@pengutronix.de> References: <20210915145726.7092-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z5bbuhray6wmbnlw" Content-Disposition: inline In-Reply-To: <20210915145726.7092-1-caihuoqing@baidu.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z5bbuhray6wmbnlw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15.09.2021 22:57:25, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > And using dev_err_probe() can reduce code size, and simplify the code. >=20 > Signed-off-by: Cai Huoqing Applied to linux-can-next/testing. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --z5bbuhray6wmbnlw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFukHwACgkQqclaivrt 76lP4wgAm1KRGmS9M+MjK6tmtI5Fp7BYKt/SpQbQQwvtuGSqdY4RwIX+Mayfq/TO hrhHzjQ3ecdH03A1bjl7W5QTMyxBGoMFWXnyNl0NgX+8aGaWOzO3DXdThuXNubgk YKHa/pmBM4nlwpKvvp4EuFZQVDkmQf7oQFlaciaWhv8UX9SfjThNmhEbbmRwRbru +aPQc6Vpi+mFVkqL9dDnChVIk8qDEI/QAny1pRVnGzG+0TdEiLJVNYcoULYvTS5s UgrKyUDsyWVGZdOXwKPabfoCxgt+ar/D4lVLBdxcgZuvg5Y4iq0nQJH/0MLpJB2g CaFJbOR0xoyoPoiXkdR4xM6nVDxNfA== =phmZ -----END PGP SIGNATURE----- --z5bbuhray6wmbnlw--