Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp293327pxb; Tue, 19 Oct 2021 03:04:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5n49//w7eEQyghe1mMXFp/kiwaRZC00/PNDi7IupEiNG+L0ihFZjyBZPUSByYsKBZYxB8 X-Received: by 2002:a17:90a:2902:: with SMTP id g2mr5329195pjd.161.1634637875769; Tue, 19 Oct 2021 03:04:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634637875; cv=none; d=google.com; s=arc-20160816; b=vuKHFwVM4Kwkyu5uIW+OVLZVJkeQX2cpUfdxLqoM2eMs9TxffpchGvJ+XKbJRpAeBD PMDmoE/Ffr9ICTLbHlsKLfV3K4sND0uXD+aRoUPS06OLdDE4TwFBRnKn9RtTIxcxtRgu QAID6tUBJ7HCJp9bVKa3fv6MEvdkpH3pR2hGvUxbut2lARO0DMS5cFj8BDhru7003B+X NAhFYigNNC8Lk9zwBPSe0UWL/ZnzpieyhvKJ2hj/x/yQ8hOahtBuId0bXZUrULyp+008 wsvMRjTKTSMpO3HftgcId+YDIyaL5jqTlm9CmN8O2BMSIQlc2pfPj01LJ/o0hbjmH7KY 6Xgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=kIYuaIJUgq+igOSriAhcSoME/C6TC4j1y6bbQepfyp8=; b=JF+09gE++CmcJgOKTR/x5rInA+Qp98usrPzPCe9ZoubK9ko/4l72/rGNRWpA7J8UL0 RxjrO/EpX20EXB62eOpmkwhgUkYHsj6beEMOrQMI3kyR87GFJiVC/HLbjlrtnVMPaRKR rGsfrToPl1pdW0Jq9pV4LbgRqBGiO/JhxIhy3CEmIL8ovz6BKYBuZe9Z8ETw26m2jYTp ueCz/c0XIVuCVYPSrlZkkk/ZBsYV8deopHSz+9CXzWEJG9ZdCGVpDqFsEdDQD5sHHwQ9 E/n5ComV+IDpNdJ//MS9RQYJxbr/Gn24WuQEiY63jEOszyrPWLQCbw9byLxhtljxXPIQ p6Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si12317751plo.236.2021.10.19.03.04.20; Tue, 19 Oct 2021 03:04:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235166AbhJSKDA (ORCPT + 99 others); Tue, 19 Oct 2021 06:03:00 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:44690 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234955AbhJSKC7 (ORCPT ); Tue, 19 Oct 2021 06:02:59 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.5]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee1616e9737608-fa8e3; Tue, 19 Oct 2021 18:00:25 +0800 (CST) X-RM-TRANSID: 2ee1616e9737608-fa8e3 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr03-12003 (RichMail) with SMTP id 2ee3616e97244be-dc62a; Tue, 19 Oct 2021 18:00:25 +0800 (CST) X-RM-TRANSID: 2ee3616e97244be-dc62a From: Tang Bin To: jic23@kernel.org, lars@metafoo.de, heiko@sntech.de Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH 3/3] iio: adc: twl6030-gpadc: Use of_device_get_match_data to simplify code Date: Tue, 19 Oct 2021 18:00:13 +0800 Message-Id: <20211019100013.27312-4-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 In-Reply-To: <20211019100013.27312-1-tangbin@cmss.chinamobile.com> References: <20211019100013.27312-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Retrieve OF match data, it's better and cleaner to use 'of_device_get_match_data' over 'of_match_device'. Signed-off-by: Tang Bin --- drivers/iio/adc/twl6030-gpadc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c index c6416ad79..0859f3f7d 100644 --- a/drivers/iio/adc/twl6030-gpadc.c +++ b/drivers/iio/adc/twl6030-gpadc.c @@ -867,17 +867,14 @@ static int twl6030_gpadc_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct twl6030_gpadc_data *gpadc; const struct twl6030_gpadc_platform_data *pdata; - const struct of_device_id *match; struct iio_dev *indio_dev; int irq; int ret; - match = of_match_device(of_twl6030_match_tbl, dev); - if (!match) + pdata = of_device_get_match_data(dev); + if (!pdata) return -EINVAL; - pdata = match->data; - indio_dev = devm_iio_device_alloc(dev, sizeof(*gpadc)); if (!indio_dev) return -ENOMEM; -- 2.20.1.windows.1