Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp316578pxb; Tue, 19 Oct 2021 03:35:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYUrYra70cZidPyAAU5va+hNl3AJfu3SJ4bDiSipumxj6HSTXzwlT+u/LdKpUEQNcs7AG1 X-Received: by 2002:a05:6a00:181c:b0:44c:bf17:e8ad with SMTP id y28-20020a056a00181c00b0044cbf17e8admr34866927pfa.67.1634639757914; Tue, 19 Oct 2021 03:35:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634639757; cv=none; d=google.com; s=arc-20160816; b=vSsvjTMlEVuEvS4YWgdw3UIiAdQvvxey1bBP+IGozKXwCtOTKAqE7VXxkey4h4dRCd WJQzO7AP6Jz+zmJ7jDwBLwIPAgVRjN94P+Ln/zHewASJAZcYyr3/t6141dqVISVWBEob sfc+n92PJ3kY75jTvODDmnMaQpuYlX/CLnjHulnu53tPkDR4ZAgwXPBmDDlZnCV8ZHZP MtjsDvFDBcelE5GzRE7pdVU2rw1wqfTirQMM9N8ukx7isklusN46glneKD8AcwSxk99m C4LCWOAQ2mrDnla84r7EG4Vg2rxqzRYZz8BMk2AF5jD3n0dqeBfEtr2mGQiiDl3KldZQ gNWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=IpcYl6X8FtmaNpPVMZUUfggRSLNdsvYUxbHeE0Kbz8k=; b=IKEPivmqN8IMG/f4f02Ott5tZ+ISaXfMUBUjg+Odn9qJuJa5WzycIDttqjMtm/ut82 d3Yv6s/XwOpHEEBY+d3MiqLgSD3fy6bJeMxd+7kr/jcB1kJMdqBWKO6niGsvnJOkepPd dpnslVZK2WXVHpsrFzAomwU4f+JSQhWuD//nEPn+Ymh4x37Vif42/LZBObXzjmQ4cKzT bCEu3xLPXsztrsiS/N0+hCRvvbagJXoA644QZDF3ei/nUVaK+pojkFc9d8tAj+y7lxQc ZXkMWEe0hPwZjJTiHoQSDpQcsFmTZEsMtub5LlCyMbJXVp0byje7DACM7wxcwjZkB4jy m5pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=S0wE63q5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s196si20101659pgs.539.2021.10.19.03.35.45; Tue, 19 Oct 2021 03:35:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=S0wE63q5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235178AbhJSKhC (ORCPT + 99 others); Tue, 19 Oct 2021 06:37:02 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]:45497 "EHLO gandalf.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235235AbhJSKgy (ORCPT ); Tue, 19 Oct 2021 06:36:54 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4HYVVS3SP1z4xd4; Tue, 19 Oct 2021 21:34:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1634639680; bh=IpcYl6X8FtmaNpPVMZUUfggRSLNdsvYUxbHeE0Kbz8k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=S0wE63q5BhyQ4pY9u+YsaZoRIr8qSQooLpGUpDKN9UyYQ3T6hOXR5u61QrwOplfDd WTLWU4ZXhhdDgHXnPXotymZYhqZqsa5+7LpGgEN49q2fO4jsfAsiWy2u/R/FD38L01 wcKJY1tFO27NmwWMH7KbpOFUgG6Jb6xuYclU4rP6YxiNAqsSDYLAHBrT9DrIQYyafR UqhCaSK++qYQW83iMAxs38jj6j2cEvdqIXYOBshZU9BLQW+RluCGTUUqcmXh8ANtQI SHA6lzra1uwXjONfqTYkTQ2x2uy0z6pCyRrXPAc2HOR+AwwqLHTFLbAamhQUzQxxRl 9qFZva75Vlhbg== From: Michael Ellerman To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH 5.4 34/69] KVM: PPC: Book3S HV: Fix stack handling in idle_kvm_start_guest() In-Reply-To: <20211018132330.615103813@linuxfoundation.org> References: <20211018132329.453964125@linuxfoundation.org> <20211018132330.615103813@linuxfoundation.org> Date: Tue, 19 Oct 2021 21:34:39 +1100 Message-ID: <87k0i9cngg.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > From: Michael Ellerman > > commit 9b4416c5095c20e110c82ae602c254099b83b72f upstream. > > In commit 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in > C") kvm_start_guest() became idle_kvm_start_guest(). The old code > allocated a stack frame on the emergency stack, but didn't use the > frame to store anything, and also didn't store anything in its caller's > frame. Please drop this for now, it's exposed some other bugs. cheers