Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp328786pxb; Tue, 19 Oct 2021 03:53:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4wP0TrPWC/WKjiOIBQi4I52g4aMNqrSG7PE9CysOe5vVNX84QjUqMHwkIUtbuEg5mT7+S X-Received: by 2002:a05:6402:3588:: with SMTP id y8mr51468454edc.285.1634640815684; Tue, 19 Oct 2021 03:53:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634640815; cv=none; d=google.com; s=arc-20160816; b=KOKOqDBjg+ZEEpsX8pfFl/6ZFNb+iM5w8VCq7zpd+yqKJyVU7ZTyR/MQ2GjKaB7q2R vpeKELlxuVZV4RdaVOao3szKbo6d3OHuWwPXI/BwRAH7+pM8aSJNCJ/ZEXBIhanoAXM/ E4EgfbpXKg/zW72c07DrbfVOSL1sROFox8jbdoaCWTti2qZP1OS7tIppI3UllgynhUPH 5rgKO2HlIHlBxQ9yjIzxG6lHiC9Izw68Fh/K94tdtK/AASF1Ll8Sh2lfa+uGDZ6mrewG 5N4cpieZ26cCW97O7mBpikha4yVD5sykODbiR/kgNPF361PjSkB1V/0oe0CON23LJYTU d9cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=9Df9o9MxP3FsMkqyOchfdtIbblt5dcCWY2fdyb0Ffe4=; b=HXFYPT4bsYGwFTuRM4nTB36oqvAZT+4VQPA5o4Ugah+1ERTN8JQ3Afdbqm0UpeaDGR wCdsCRvR66dxhlKkSyg6zF8RKI5rDm4NLjxW4fsiboyBphDV/j8Y3h4FEJzQpiecOVEP wDnLCHXC7qk7tjLI8XmB1d+Lqq8XRwIKrxe+5iHbdgTlppVqVoh+yuO+gTcoTp3gFt/B tagXxRzuSevok8FRDJs0xJc843+1IjykYPcpXS+ixOc1HG7hRVSObS0iYY3cCILevrut ICMix0eazNHumpUn/CEpZ0WrqPnEb5rUrAl+zrOGkWnYiW8BdpBjfMG7mPRejTEjYwuT zkiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si23212727ejc.561.2021.10.19.03.53.11; Tue, 19 Oct 2021 03:53:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235243AbhJSKxa (ORCPT + 99 others); Tue, 19 Oct 2021 06:53:30 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:48397 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235180AbhJSKx2 (ORCPT ); Tue, 19 Oct 2021 06:53:28 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R411e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UsvUfEV_1634640657; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UsvUfEV_1634640657) by smtp.aliyun-inc.com(127.0.0.1); Tue, 19 Oct 2021 18:51:13 +0800 From: Jiapeng Chong To: aacraid@microsemi.com Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, chongjiapeng Subject: [PATCH] scsi: core: return -ENOMEM on ips_init_phase1() allocation failure Date: Tue, 19 Oct 2021 18:50:55 +0800 Message-Id: <1634640655-20667-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: chongjiapeng Fixes the following smatch warning: drivers/scsi/ips.c:6901 ips_init_phase1() warn: returning -1 instead of -ENOMEM is sloppy. Reported-by: Abaci Robot Fixes: dd00cc486ab1 ("some kmalloc/memset ->kzalloc (tree wide)") Signed-off-by: chongjiapeng --- drivers/scsi/ips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index 498bf04499ce..2ce97f407d18 100644 --- a/drivers/scsi/ips.c +++ b/drivers/scsi/ips.c @@ -6898,7 +6898,7 @@ ips_init_phase1(struct pci_dev *pci_dev, int *indexPtr) if (ha == NULL) { IPS_PRINTK(KERN_WARNING, pci_dev, "Unable to allocate temporary ha struct\n"); - return -1; + return -ENOMEM; } ips_sh[index] = NULL; -- 2.19.1.6.gb485710b