Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp332158pxb; Tue, 19 Oct 2021 03:57:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf2Pwz2YoxNucKewhEMyzOkNoiqKlvnnZgT96qHl2LFEuaeSNT3h7yVFCw1J9AsW8jVEb3 X-Received: by 2002:a17:906:2606:: with SMTP id h6mr37579335ejc.301.1634641079690; Tue, 19 Oct 2021 03:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634641079; cv=none; d=google.com; s=arc-20160816; b=FklsODqYKNkFeUl/yFUBvUAi2QrofuCQUs93uXVPypfFwlCajCRhSriprW/7Lrf5b4 M/K9NpEBHKC+9TKGFE010YeVfoqxfVpQ5Zx1Cbf947HyedBWBuHWKDXBCz4uvyiTvpkV +N8EphAP8h2oMAE6sCZ9XL6Dq+nF0x7yO8IVe9bEuaqe7j87PM1UuVM6IoeyObWzq5jJ +xz82DOuxzGTvS+ITWQGXgk7pzIhKSzDKz1LL/q9fRLWiqleEZB0TXWYy7fugzJNnedP s2CMfeg3GWLmRDIk3YmJl3rP22NnC+4LjFUHlf+ppGEIC9vQJWRKAITIkgTOJxhtnxUc Bc8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=x2ytmbg7gwsAE45QXX+LTY1Rs6nJEpauqSbvOn/silc=; b=RhPm708A6DYWUuXsQFagioOV8ZmzyyMClpqgau6oJyvpOiIberBuzZG3u2f3imJAwr iZvLWR1IkjvqOjGs4T6DtztepGiDG0GTm0GbriwpMbXUvkCcsvxbhetY9Xa0sbzQI+sL ACZlZf4pTa1uzHm2h0HeYu0ZbspL3c0kswLyI6icuKe2o+mnvI8nXc9TnBynxpi2f81k 5T5iY59cHw1njnn+3MylU32Cj2bnTU3qhmUqe5+OlerSm2ZDhLj3nOWK29frO6dlIU/d JoiZG8aaNa/QSitd50EM4B9kFy52PmDwCZRrHQvjG7rwNooMvdjbPlgKGDKjDvneiTKD lnSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=n7TTWWOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y21si23758435ejq.409.2021.10.19.03.57.36; Tue, 19 Oct 2021 03:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=n7TTWWOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235326AbhJSK51 (ORCPT + 99 others); Tue, 19 Oct 2021 06:57:27 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]:34981 "EHLO gandalf.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235305AbhJSK5S (ORCPT ); Tue, 19 Oct 2021 06:57:18 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4HYVy06QWHz4xbb; Tue, 19 Oct 2021 21:55:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1634640905; bh=x2ytmbg7gwsAE45QXX+LTY1Rs6nJEpauqSbvOn/silc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=n7TTWWOBd6RX+p/IN+p268kU2u6ImzN06R5YXKjhPZBFCVaR2Ks6FdIxmAwcuyCio bOXGp8dEpDYRQqSjdUnqKrPpS6v0+Dl7qtTq3Dhgf8kTm3UapvTGpCURinNTbEIl4X 4LRr4MdQsBZRPlIVOtg3KZWbB9jig0DIdXujL7V524VLdShFemNJLtKFZh1XGEgKn8 +StDoM1BkHq3l7AuAzflrxKtO5L1K3iVG8FoNMm4e4RcR+1ndug1Z+ehePaVwA32IZ ZdD0MYcH4gnm6Q7iwg5aM2/hwg4YlTbj3mCa61a/oP7ZV9NIct/dqnvB18oGCChpzA EYqh4NxBNv+Vg== From: Michael Ellerman To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH 5.14 060/151] KVM: PPC: Book3S HV: Fix stack handling in idle_kvm_start_guest() In-Reply-To: <20211018132342.644684017@linuxfoundation.org> References: <20211018132340.682786018@linuxfoundation.org> <20211018132342.644684017@linuxfoundation.org> Date: Tue, 19 Oct 2021 21:55:04 +1100 Message-ID: <87a6j5cmif.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > From: Michael Ellerman > > commit 9b4416c5095c20e110c82ae602c254099b83b72f upstream. > > In commit 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in > C") kvm_start_guest() became idle_kvm_start_guest(). The old code > allocated a stack frame on the emergency stack, but didn't use the > frame to store anything, and also didn't store anything in its caller's > frame. Please drop this and the next patch. cheers