Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp332945pxb; Tue, 19 Oct 2021 03:59:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoK30NMgToQ07AsdhoDRwxOjW5nWYrB5qWbdHFV52ZlOhu/bx3qmEWfKn5XoHOcpjFUfDv X-Received: by 2002:a17:906:4482:: with SMTP id y2mr37504062ejo.484.1634641144104; Tue, 19 Oct 2021 03:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634641144; cv=none; d=google.com; s=arc-20160816; b=My/bePxjyrTYTBdeBfjdAYRedUeiSgThWn/gitBf0C0KuTKzeVZGKEzdo7zR7xKq5F IyXmeWXf3F69/C9h3QYR0f4XnJE3ULiB0Fs1Qf/AkQn7fmMrQ9sYTwL4Lfw/ivtiF0ga wOn0uZnQ993DQs2aRiidydj/pfKFGutWCzsJOiU/f2xaOOb/hpDMIq8Cx8yjXELZpxzO O2r56q24LtjUcq4QAcgtv9lABs5a9Lzi+xCJrWL0Y0hQ8QS4GFLg7kHtMbdBYLFZNY/c 3M2d7HHegKEzqcJu4CO4KAblE+8Zp9pOetzWDZ1W414suucNKS5/Lja24gLZaaDOV5fH QR1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=x2ytmbg7gwsAE45QXX+LTY1Rs6nJEpauqSbvOn/silc=; b=BtKJO4FBm3Ez5wT7a8DLjhqkpeHPoQU4WapTPNOY5X3JEs4Wo9kh4n1E+Tnl4/QvH5 yKPeQFkdncCTh14e/Wn2lLb3pmsM31cf7PyYHHmtCOMDlNLfsoOPQ+Z806rsSo9NdgiV 46+euGGWGYUo9TpS8cZ0o/wxm+o5Fm05VZ0QIV8lVRWhxbw96z5uTam6Y75e5pyTDyJ6 tbUuMO6UmE7plCZdlZ7pnYFfwOc3Lw92R62XH6ojeLFz50ORyew+wATMfN5sGk8PR6u2 hj0D2O6SzeYYPdDOem4vVPSF+Z+KeHz8splN7s9IzjoX6/l1JKa2otOn0zADDd4pscvt boUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=BeqNtxj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p15si30221319edj.83.2021.10.19.03.58.40; Tue, 19 Oct 2021 03:59:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=BeqNtxj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235243AbhJSK5C (ORCPT + 99 others); Tue, 19 Oct 2021 06:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhJSK5A (ORCPT ); Tue, 19 Oct 2021 06:57:00 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee2:21ea]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CDB2C06161C; Tue, 19 Oct 2021 03:54:48 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4HYVxf5rHzz4xbT; Tue, 19 Oct 2021 21:54:46 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1634640886; bh=x2ytmbg7gwsAE45QXX+LTY1Rs6nJEpauqSbvOn/silc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BeqNtxj9fcgJchbZO6CK+C3piBovokudXm+CZw8VBvty/2RuMhx1zq2Zf+CgYYMTo mUip8akC+86F8Y9Hlx853M04ynfolpXmKULXXWs5IYPsm5WgY3gLYiuB12ECWqzVYk F2yZt8Mx3TqleISfcp5brtwBzj2bQg841FxUMrNmSxbwnIss9ZV+jXCmeR+vVqMplZ EdB+RiFwpUIzKewXD0axRXVOCiwIKjoKigHNVJBYHtLkzmG44V5wZavAyi6Px5Y1u8 BijuL8eR7ftqIeLyJpy0/IXt856omumNIdMayj9ozEoJE4Gy7tZC55stDBy4y43BNw BFu/lsV8omS2w== From: Michael Ellerman To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH 5.10 044/103] KVM: PPC: Book3S HV: Fix stack handling in idle_kvm_start_guest() In-Reply-To: <20211018132336.219642035@linuxfoundation.org> References: <20211018132334.702559133@linuxfoundation.org> <20211018132336.219642035@linuxfoundation.org> Date: Tue, 19 Oct 2021 21:54:46 +1100 Message-ID: <87czo1cmix.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > From: Michael Ellerman > > commit 9b4416c5095c20e110c82ae602c254099b83b72f upstream. > > In commit 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in > C") kvm_start_guest() became idle_kvm_start_guest(). The old code > allocated a stack frame on the emergency stack, but didn't use the > frame to store anything, and also didn't store anything in its caller's > frame. Please drop this and the next patch. cheers