Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Oct 2021 15:05:07 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Tsuchiya Yuto <kitakar@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Andy Shevchenko <andy@kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] ACPI / PMIC: Add i2c address to
 intel_pmic_bytcrc driver
Message-ID: <YW60cwMHNoTYgQL6@smile.fi.intel.com>
References: <20211017161523.43801-1-kitakar@gmail.com>
 <20211017161523.43801-2-kitakar@gmail.com>
 <3e6428f1-9411-fac6-9172-1dfe6de58c28@redhat.com>
 <23d641620aebd1aa47fd73d040dec4ad8974d03d.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23d641620aebd1aa47fd73d040dec4ad8974d03d.camel@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 19, 2021 at 08:56:04PM +0900, Tsuchiya Yuto wrote:
> On Mon, 2021-10-18 at 11:16 +0200, Hans de Goede wrote:
> > On 10/17/21 18:15, Tsuchiya Yuto wrote:

...

> > Tsuchiya, can you give the attached patch a try.
> 
> Thanks!
> 
> I tried your attached patch, and I can confirm that it's working as
> expected.
> 
> Now it's using cht one:
> 
>         $ ls /sys/devices/pci0000:00/808622C1:05/i2c-5/i2c-INT33FD:00
>         cht_crystal_cove_pmic  crystal_cove_gpio  crystal_cove_pwm  driver  firmware_node  modalias  name  power  subsystem  uevent
> 
> and the function intel_soc_pmic_exec_mipi_pmic_seq_element() is also
> working with atomisp driver.

To be formal you may give a dedicated tag here, i.e. Tested-by:.
It will be easier for tools, such as `b4`, to catch it up
and not forget.

-- 
With Best Regards,
Andy Shevchenko