Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp408993pxb; Tue, 19 Oct 2021 05:31:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9xJS2hUngwC7FsujtYu4QpOHtw0OQxtH+LDHgzEcQKSK2z749mbWYlVu7g1IqnCxHAyvm X-Received: by 2002:a17:906:d8d5:: with SMTP id re21mr38381596ejb.110.1634646695165; Tue, 19 Oct 2021 05:31:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634646695; cv=none; d=google.com; s=arc-20160816; b=EybpPgr+biqnHgmmSZUhZQpgZId2G+yxUO1YxyOKUS4BdxaCBSuZICdqNk8dPVrX+o B0lFlnAFWnkyl1jqICd6ncMVQIAv45teuLsyqTGp8KQs7pz4zuY9GYlm8adg8eDjZfN/ ZNCyHpmSCmjo6hFPn885FaaDOmSTCaPlaO/t6O2uVzGr3Gte13lZlY9/99wnd6dOuEzx 438wcT117/USHWpukO3qnID9q1clN95AHt9CU5slsfLXQS8LrXoswDq/1gmtoZZ9ubRk +teOkYzLemU2c1Qy8mePlQSN2kfxlph61ZUXhviTudHQp0svkLOM3rtJ8sS67pvyHFzr ZIsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4KPabGMaD3wPi9aIZhTTDGiCmqEZZ5KOQzX/xnMFK5c=; b=RM3qizNUYFhjWBvzTaOle8l1X7ugOMUAHrSxlvadFvlyZv8zWRopSt/evOvM/HqkwD 30gv+w5/fczPqPaS1eyZOSm9ILE6K2BY2HQHxnNWbeyNNg/v0bgb9OmsUmLxSOI9fwzF v+9bEtnWcYRg8PAVmqhGD28NIJgW7PAK8j+VYz58nhhmzG1slve9MYv5cb/o04QSH0zK kqqDACD1aqgr+5SUtIMmbys+lAb+uCrtvFHhHdtrWpTnek2IPFOA7/BNOHpdQwIcVdmO ogO+N+gsaefvga+s0SvEvpyDtzf+kC8zXOjglOSj2RtM9fRUrOQmbcN50/NuXa/vM27A mJsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=VhBMmqOH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si24007561ejs.393.2021.10.19.05.31.03; Tue, 19 Oct 2021 05:31:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=VhBMmqOH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234316AbhJSMbY (ORCPT + 99 others); Tue, 19 Oct 2021 08:31:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46496 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhJSMbW (ORCPT ); Tue, 19 Oct 2021 08:31:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4KPabGMaD3wPi9aIZhTTDGiCmqEZZ5KOQzX/xnMFK5c=; b=VhBMmqOHyvEmQuDl3D8SGZQPPM xFEqu3sRwnKlaXlypIFyzG7eMiNc7mf/R7H1crPxPT3+xkgRzZDm8Y9TZTShnxLDhChIp56acq1Xg ghzKcxNFng2fA/V4bjy06voGS4M6yyfDzg689NC8nnmS/s64dFXhIjClXmAVOKCIwkOg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mcoEn-00B4gv-5L; Tue, 19 Oct 2021 14:29:01 +0200 Date: Tue, 19 Oct 2021 14:29:01 +0200 From: Andrew Lunn To: Jie Luo Cc: Luo Jie , hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH v3 03/13] net: phy: at803x: improve the WOL feature Message-ID: References: <20211018033333.17677-1-luoj@codeaurora.org> <20211018033333.17677-4-luoj@codeaurora.org> <0ba3022d-9879-bf85-251d-3f48b9cff93b@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ba3022d-9879-bf85-251d-3f48b9cff93b@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Andrew, > > when this register AT803X_INTR_STATUS bits are cleared after read, we can't > clear only WOL interrupt here. O.K. But you do have the value of the interrupt status register. So you could call phy_trigger_machine(phydev) if there are any other interrupt pending. They won't get lost that way. Andrew