Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Oct 2021 14:48:47 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
Cc:     kuba@kernel.org, mickeyr@marvell.com, serhiy.pshyk@plvision.eu,
        taras.chornyi@plvision.eu, Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Vadym Kochan <vkochan@marvell.com>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: marvell: prestera: add firmware v4.0
 support
Message-ID: <YW6+r9u2a9k6wKF+@lunn.ch>
References: <1634623424-15011-1-git-send-email-volodymyr.mytnyk@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1634623424-15011-1-git-send-email-volodymyr.mytnyk@plvision.eu>
Precedence: bulk

On Tue, Oct 19, 2021 at 09:03:43AM +0300, Volodymyr Mytnyk wrote:
> From: Volodymyr Mytnyk <vmytnyk@marvell.com>
> 
> Add firmware (FW) version 4.0 support for Marvell Prestera
> driver. This FW ABI will be compatible with future Prestera
> driver versions and features.
> 
> The previous FW support is dropped due to significant changes
> in FW ABI, thus this version of Prestera driver will not be
> compatible with previous FW versions.

So we are back to breaking any switch already deployed using the
driver with the older firmware. Bricks in broom closets, needing
physical access to fix them. Was nothing learnt from the upgrade from
v2 to v3 with its ABI breakage and keeping backwards support for one
version? Do you see other vendors making ABI breaking changes to there
firmware?

Why would anybody decide to use Marvell, when you can use Microchip
devices an avoid all these problems?

	Andrew