Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211019090020.11724-1-Meng.Li@windriver.com>
References: <20211019090020.11724-1-Meng.Li@windriver.com>
Subject: Re: [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, meng.li@windriver.com
To:     Meng Li <Meng.Li@windriver.com>, geert+renesas@glider.be,
        magnus.damm@gmail.com, robh+dt@kernel.org
Date:   Tue, 19 Oct 2021 15:42:33 +0100
Message-ID: <163465455377.2083150.11106861856940757460@Monstersaurus>
User-Agent: alot/0.9.2
Precedence: bulk

Quoting Meng Li (2021-10-19 10:00:20)
> The gpio5-pin9 is used as the interrupt pin of i2c external
> gpio chip, so set this pin as input by default.

Is a GPIO hog the right way to do this?
Shouldn't the other GPIO chip be modelled in DT and reference the gpio
interrupt line from there in its interrupt property?

I assume by 'external gpio chip' you mean one which is permanantly
attached to the ULCB Kingfisher board, and not a custom addition?

--
Regards
Kieran

>=20
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/d=
ts/renesas/ulcb-kf.dtsi
> index 202177706cde..8986a7e6e099 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -205,6 +205,15 @@
>         };
>  };
> =20
> +&gpio5 {
> +       gpio_exp_77_int {
> +               gpio-hog;
> +               gpios =3D <9 0>;
> +               input;
> +               line-name =3D "gpio-exp-77-int";
> +       };
> +};
> +
>  &i2c4 {
>         i2cswitch4: i2c-switch@71 {
>                 compatible =3D "nxp,pca9548";
> --=20
> 2.17.1
>