Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp546461pxb; Tue, 19 Oct 2021 08:09:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyA1CpaVptdZ4tGDqpOfEeRIrV1dMzmTn1+lhXjKdjJJki+w/+Tlmh2VK5qUG7n6DMa5OwP X-Received: by 2002:a17:906:b819:: with SMTP id dv25mr38844444ejb.21.1634656145803; Tue, 19 Oct 2021 08:09:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634656145; cv=none; d=google.com; s=arc-20160816; b=Wxgs+2WYPnSVvejOC+jaXw1mz+KgxLoaw2Or3ten5Om3DZ7XZzS3DefNpJSKOnYdTg WsVqpY6TZ+e3v1TwzwUMA2epW2Sf8vmOo5yNAkoj8mTt8vOwBnCQP4kf5gadW/x9A5p9 ENh8j/KQVHOpl7UGc5GLcEMI6ButP0x/6Y+YgpYVQ9GDiXyD1uSsB5V3AtnzNZ5qpEye c5ZsfBBNmooph2Q01f+3e5/NuwUlFvJQMRYNSYUAgYxx1wCxTnVsAm14beKKOZzxwBKz rsebfT8cU3ImvNh8IBwRnYcvc/ajqaAJd28DxQVJt/Z+TRcpAgHP9cp9GCYBHgV1rzKS KtSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=w8h8UgX4zPVY1GptnR/Vh7lzdehVtwHAOiUbbpM+Qj4=; b=sTg9KyWLzcL4L0d0iGnjET0xy9yA0mEQ5T7j460x4QbHg9LQuMXFc0OXVWnRg16OYc oArK2Zar85ctzpgoXVESowqmRZdgHeB9qIKZfTWduCOu0KEe5meMvCs9syDGYHh7Zglv xvE0kczoXR+Wp7qX6TFiSV21+hBUCmZvhPG7YLV2u1PaAFFpiUiwzWsQRhP2ZfL3LxEK ARfTCt2sPT55L0aYU3/7LxBSOaVXvm1cTqTZZMcz2zc8jAg54xes9lmLQx7Wc0OWZv/6 /ah7BX+FzNzOaLOEmYw3h5F6fddmLhE7/Cy7s0YLWsgPoGDcwW5lEvjnJf9a1olSevoB aziw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RhcIXXlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jt14si26075739ejc.187.2021.10.19.08.08.38; Tue, 19 Oct 2021 08:09:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RhcIXXlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232083AbhJSPIg (ORCPT + 99 others); Tue, 19 Oct 2021 11:08:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:56524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232316AbhJSPId (ORCPT ); Tue, 19 Oct 2021 11:08:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9FC16115A; Tue, 19 Oct 2021 15:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634655980; bh=McyFOJTAzTyYw41z1YF9eETGWDWdlZDxE9H0XbVk8m4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RhcIXXlISyAo2Cp3KUlwK4daus2D5a3p6b8jRrPTNwxwC9VY9xe/ITz1XqrpInmWD tZV1+o4jkd9GDy1srZp48JU5tVK1LEQ1JMklLeh6MU965FHX/OpBjOElx3APkAni69 z3QAq6tj9rfzE/RhPdGPSNz6Qe/kI9VmozvIqYWSYPlTXnxO9fuVvHIw/AEsmP1uL/ uJmo3HMICI6UotOqZjzUW2OKqktF5Bde9idyb83xWc/b5xkAQWpsBvY0y219iXl1lQ NqgLdBmtS6bKigYdrEk37wBcXBuRHJTda6ibxMCcXfyJPgehVAZqNRDavYTe/i+s/J xvrrhDO8GydaQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0BB2D410A1; Tue, 19 Oct 2021 12:06:16 -0300 (-03) Date: Tue, 19 Oct 2021 12:06:16 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Jin Yao , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Kees Cook , Sami Tolvanen , Nick Desaulniers , Andrew Morton , Jacob Keller , Zhen Lei , ToastC , Joakim Zhang , Felix Fietkau , Jiapeng Chong , Song Liu , Fabian Hemmer , Alexander Antonov , Nicholas Fraser , Adrian Hunter , Denys Zagorui , Wan Jiabing , Thomas Richter , Sumanth Korikkar , Heiko Carstens , Changbin Du , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , Stephane Eranian Subject: Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. Message-ID: References: <20211015172132.1162559-1-irogers@google.com> <20211015172132.1162559-22-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211015172132.1162559-22-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Oct 15, 2021 at 10:21:32AM -0700, Ian Rogers escreveu: > By allowing modifiers on metrics we can, for example, gather the > same metric for kernel and user mode. On a SkylakeX with > TopDownL1 this gives: > > $ perf stat -M TopDownL1:u,TopDownL1:k -a sleep 2 > > Performance counter stats for 'system wide': Hi Ian, can you please take a look on this? this is on my perf/core branch. - Arnaldo [root@five ~]# perf test -vv "for cgroups" 70: Event expansion for cgroups : --- start --- test child forked, pid 992568 Using CPUID AuthenticAMD-25-21-0 libpfm was not enabled metric expr 1 / IPC for CPI parsing metric: 1 / IPC metric expr instructions / cycles for IPC parsing metric: instructions / cycles found event instructions found event cycles Parsing metric events '{instructions/metric-id=instructions/,cycles/metric-id=cycles/}:W' copying metric event for cgroup 'A': instructions (idx=0) copying metric event for cgroup 'B': instructions (idx=0) copying metric event for cgroup 'C': instructions (idx=0) free(): double free detected in tcache 2 test child interrupted ---- end ---- Event expansion for cgroups: FAILED! [root@five ~]# ⬢[acme@toolbox perf]$ git bisect bad c067335fcbfc67c36663dabdb9ccaa96badf9359 is the first bad commit commit c067335fcbfc67c36663dabdb9ccaa96badf9359 Author: Ian Rogers Date: Thu Oct 7 09:56:47 2021 -0700 perf metric: Allow modifiers on metrics. By allowing modifiers on metrics we can, for example, gather the same metric for kernel and user mode. On a SkylakeX with TopDownL1 this gives: