Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp558590pxb; Tue, 19 Oct 2021 08:22:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIY9tuQblE1kQftDn5W1sUtxXBactqZLvi79gGNRtN26KeRTDxl7kJf9V33cduh6wIWMfD X-Received: by 2002:a17:907:8a27:: with SMTP id sc39mr38175160ejc.567.1634656927224; Tue, 19 Oct 2021 08:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634656927; cv=none; d=google.com; s=arc-20160816; b=rWUNGhWPw5gnVap2Xoq8zkoXSrH4CGENVgsBMSPcsV2oYnTO3Es0/vy5S5Lgsl1cgW cbJG0AH4FyWbDVF/6e/Tm0lWIqxPq8pFlROE1OKDq00uoWF0yHdlX61FUUij/vzhert4 4Aor6Rdbq+kcDCU4MFl9GCZXOwtsyzvN65Fpvq2S45T40TfXSImCzYHhmh/4wkTpGVec fW2B+WwhpfujqoPkhWt4OXHFC9qf0xmNUhX8DIO5V5pGiXNovEie/2FZMKpQYsKHhgs0 gKO0ieaGiUmqCVW8D3bhrdgfBf+Tqqr4wF0FMtuDtYVn4zTJFZSAJt3kX/j1Wgz1iFZv caeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=o6kZYqO8qEZ9bkJ+adGKvUWk/uhdx+YslukCtlL9cpg=; b=T6VedwrfERVO34gjPlMy2U3+ckn0zDKHeq9SwwaX3OdbzXRhRUeULOqGlBmjt6oruz xpSZex7FhbKIMq/ojKI14tl9GOZbTVR2Ge0IPfVhpEhk+KAyJFJxoijrFHjPEHHG/Cj3 CiK2OMRhJxCip+GPlCxoFcbmzO8yE8F7NBERgfJOjrYZhUY+vaEYMsSPcyhPwxcbz1Cs hfDlulEkRyxHx/yte2AiaEErRVoNQR2zQWOMAZ47RrzbZqbS+VaDthq2SAjajT0CQv8E J4rmmFp55eOR/PXpJ1XnM3Zh6FEXdqURsh7kLWd/jEAYkyy2OK2G3h3vqTd68/vUnmQs Sb/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bt6/2z+z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x14si22371075edr.311.2021.10.19.08.21.43; Tue, 19 Oct 2021 08:22:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bt6/2z+z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbhJSPT1 (ORCPT + 99 others); Tue, 19 Oct 2021 11:19:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:37766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232764AbhJSPTZ (ORCPT ); Tue, 19 Oct 2021 11:19:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA79160FE8; Tue, 19 Oct 2021 15:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634656633; bh=Jghv2qiCrh2T7drOu62Q4awOcshsMbwP6PP7jKtWi1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bt6/2z+zIvp3TGsSWODu3BRbZl/jMTKSeavPb3jIviUjQZxXnA1qxzkmSohvP51+5 kItHqxMjndylgZGkBFyz6PxLCVy+00T0kQ1gt8I/ZuICj9C/g4F8YdyLBv+Zl7WyIa I9i7QPu7PoHTDDM6efQupm1mui2UgNwlRBammTMeOUYOHivQCGcXw0E7N1Qf6pVACs u0wUpLqodUtFSjx7E3mgpIambACpOFtnO1DUhx2GTDIeRaM67EnabjZWJhNOxLSXBP tgebH79ygtLLPKKpU0K2TJ/pjKELGxV4iE2UYf76fKcSxfJ/IeRj8CGXVT91j9nXdB +ar7TEdcKN+1g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 38F12410A1; Tue, 19 Oct 2021 12:17:10 -0300 (-03) Date: Tue, 19 Oct 2021 12:17:10 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Jin Yao , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Kees Cook , Sami Tolvanen , Nick Desaulniers , Andrew Morton , Jacob Keller , Zhen Lei , ToastC , Joakim Zhang , Felix Fietkau , Jiapeng Chong , Song Liu , Fabian Hemmer , Alexander Antonov , Nicholas Fraser , Adrian Hunter , Denys Zagorui , Wan Jiabing , Thomas Richter , Sumanth Korikkar , Heiko Carstens , Changbin Du , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , Stephane Eranian Subject: Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. Message-ID: References: <20211015172132.1162559-1-irogers@google.com> <20211015172132.1162559-22-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 19, 2021 at 12:13:52PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Oct 19, 2021 at 12:06:17PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Oct 15, 2021 at 10:21:32AM -0700, Ian Rogers escreveu: > > > By allowing modifiers on metrics we can, for example, gather the > > > same metric for kernel and user mode. On a SkylakeX with > > > TopDownL1 this gives: > > > > > > $ perf stat -M TopDownL1:u,TopDownL1:k -a sleep 2 > > > > > > Performance counter stats for 'system wide': > > > > Hi Ian, can you please take a look on this? this is on my perf/core > > branch. > > I processed the first version of this series, reviewed by Andi, can you > please submit the diff from one to the other? The interdiff from the 21st patch on the first batch versus on the v2 batch is below, but it doesn't apply to my current perf/core branch, lemme push it to tmp.perf/core... - Arnaldo ⬢[acme@toolbox perf]$ interdiff ~/wb/old.patch ~/wb/new.patch diff -u b/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c --- b/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -1308,8 +1308,7 @@ int ret; *out_evlist = NULL; - ret = metricgroup__build_event_string(&events, ids, modifier, - has_constraint); + ret = metricgroup__build_event_string(&events, ids, has_constraint); if (ret) return ret; @@ -1324,7 +1323,8 @@ ids__insert(ids->ids, tmp); } - ret = metricgroup__build_event_string(&events, ids, has_constraint); + ret = metricgroup__build_event_string(&events, ids, modifier, + has_constraint); if (ret) return ret; @@ -1568,7 +1568,10 @@ return -ENOMEM; new_expr->metric_expr = old_expr->metric_expr; - new_expr->metric_name = old_expr->metric_name; + new_expr->metric_name = strdup(old_expr->metric_name); + if (!new_expr->metric_name) + return -ENOMEM; + new_expr->metric_unit = old_expr->metric_unit; new_expr->runtime = old_expr->runtime; ⬢[acme@toolbox perf]$