Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210924115032.29684-1-o.rempel@pengutronix.de>
 <19b2ab33-aa56-75fb-f6ef-3c928be9c50c@linaro.org> <20211019115151.GC16320@pengutronix.de>
 <df3f527d-22f3-b58d-a546-bdd8d312505c@linaro.org> <20211019125929.GD16320@pengutronix.de>
In-Reply-To: <20211019125929.GD16320@pengutronix.de>
From:   Petr Benes <petrben@gmail.com>
Date:   Tue, 19 Oct 2021 19:28:53 +0200
Message-ID: <CAPwXO5Z8k9TZ4y6ZTFrv-2TK7Lv8Y28LDSTXpT8s4oPPDxupYw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] thermal: imx: implement runtime PM support
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
        linux-kernel@vger.kernel.org,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        David Jander <david@protonic.nl>,
        Zhang Rui <rui.zhang@intel.com>,
        Fabio Estevam <festevam@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= <michal.vokac@ysoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

We dropped Michal from the loop. Adding him back.

On Tue, 19 Oct 2021 at 14:59, Oleksij Rempel <o.rempel@pengutronix.de> wrot=
e:
>
> On Tue, Oct 19, 2021 at 01:55:32PM +0200, Daniel Lezcano wrote:
> > On 19/10/2021 13:51, Oleksij Rempel wrote:
> > > Hi Daniel,
> > >
> > > On Tue, Oct 19, 2021 at 01:04:46PM +0200, Daniel Lezcano wrote:
> > >> On 24/09/2021 13:50, Oleksij Rempel wrote:
> > >>> Starting with commit d92ed2c9d3ff ("thermal: imx: Use driver's loca=
l
> > >>> data to decide whether to run a measurement") this driver stared us=
ing
> > >>> irq_enabled flag to make decision to power on/off the thermal core.=
 This
> > >>> triggered a regression, where after reaching critical temperature, =
alarm
> > >>> IRQ handler set irq_enabled to false,  disabled thermal core and wa=
s not
> > >>> able read temperature and disable cooling sequence.
> > >>>
> > >>> In case the cooling device is "CPU/GPU freq", the system will run w=
ith
> > >>> reduce performance until next reboot.
> > >>>
> > >>> To solve this issue, we need to move all parts implementing hand ma=
de
> > >>> runtime power management and let it handle actual runtime PM framew=
ork.
> > >>>
> > >>> Fixes: d92ed2c9d3ff ("thermal: imx: Use driver's local data to deci=
de whether to run a measurement")
> > >>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > >>
> > >> Thanks for this fix.
> > >>
> > >> Petr or Oleksij,
> > >>
> > >> could you confirm it is tested and working without CONFIG_PM ?
> > >
> > > Petr was right, no it is not working without PM.
> > Ok, thanks.
> >
> > I suppose the fix is related to the initialization of the sensor which
> > should be enabled with/out pm_runtime, right ?
>
> No, i did sanity check on pm_runtime_put() within the probe. Without PM
> it will properly return ENOSYS, so I aborted the probe. Looks like I
> should ignore return value on this function like every driver is doing
> it.
>
> >
> >
> > --
> > <http://www.linaro.org/> Linaro.org =E2=94=82 Open source software for =
ARM SoCs
> >
> > Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> > <http://twitter.com/#!/linaroorg> Twitter |
> > <http://www.linaro.org/linaro-blog/> Blog
> >
>
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  =
|
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|